Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Cloud Function gen1 #152

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Use Cloud Function gen1 #152

merged 1 commit into from
Sep 20, 2024

Conversation

chez-shanpu
Copy link
Contributor

@chez-shanpu chez-shanpu commented Sep 19, 2024

The latest CloudSDK uses Cloud Function gen2 by default and it needs other APIs and IAM Roles because it uses Cloud Run.
Currently neco-gcp doesn't have to use gen2, so this PR set --no-gen2 and neco-gcp will use gen1 explicitly.

@chez-shanpu chez-shanpu changed the title Use CloudRun gen1 Use Cloud Function gen1 Sep 20, 2024
Signed-off-by: Tomoki Sugiura <[email protected]>
Copy link
Contributor

@masa213f masa213f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chez-shanpu chez-shanpu merged commit c82396a into main Sep 20, 2024
1 check passed
@chez-shanpu chez-shanpu deleted the use-gen1 branch September 20, 2024 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants