Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support k8s 1.27 and update dependencies #254

Merged
merged 13 commits into from
Oct 11, 2023
Merged

Support k8s 1.27 and update dependencies #254

merged 13 commits into from
Oct 11, 2023

Conversation

ysksuzuki
Copy link
Contributor

No description provided.

yokaze and others added 12 commits October 5, 2023 13:00
@yokaze @ysksuzuki
Update Actions versions
4ab5236 
Signed-off-by: Daichi Sakaue <[email protected]>
@yokaze @ysksuzuki
Update Ginkgo and Gomega
a9e9757 
Signed-off-by: Daichi Sakaue <[email protected]>
@yokaze @ysksuzuki
Update Prometheus libraries
c3b0b15 
Signed-off-by: Daichi Sakaue <[email protected]>
@yokaze @ysksuzuki
Update grpc and protobuf
103bb1c 
Signed-off-by: Daichi Sakaue <[email protected]>
@yokaze @ysksuzuki
Update go.mod
0368957 
Signed-off-by: Daichi Sakaue <[email protected]>
@yokaze @ysksuzuki
Update controller-tools and protoc
4148eef 
Signed-off-by: Daichi Sakaue <[email protected]>
@yokaze @ysksuzuki
Update kind
a62760a 
Signed-off-by: Daichi Sakaue <[email protected]>
@yokaze @ysksuzuki
Update kind to 0.19.0
d39c856 
Signed-off-by: Daichi Sakaue <[email protected]>
@ysksuzuki
Add CGO_ENABLED=0 when building the echoServer
3dab7d3 
to fix the glibc divergence between a build and a runtime environment.

Signed-off-by: Yusuke Suzuki <[email protected]>
@ysksuzuki
Update tools for e2e test
ac96897 
Signed-off-by: Yusuke Suzuki <[email protected]>
@ysksuzuki
Update networking libraries
95726c4 
Signed-off-by: Yusuke Suzuki <[email protected]>
@ysksuzuki
Update zap
b03b9dc 
Signed-off-by: Yusuke Suzuki <[email protected]>
@ysksuzuki
Copy link
Contributor Author

ysksuzuki commented Oct 5, 2023 •
edited
Loading

Note:

Kube-openapi breaks backwards compatibility. So we need to use the commit before it changes gnostic-models. Otherwise we get the error bellow.
kubernetes/client-go#1269 (comment)

(This PR is using kube-openapi v0.0.0-20230525220651-2546d827e515 to fix the error)

~/go/pkg/mod/k8s.io/[email protected]/applyconfigurations/meta/v1/unstructured.go:64:38: cannot use doc (variable of type *"github.com/google/gnostic/openapiv2".Document) as *"github.com/google/gnostic-models/openapiv2".Document value in argument to proto.NewOpenAPIData

@ysksuzuki
Upgrade k8s libraries
b3029c6 
Signed-off-by: Yusuke Suzuki <[email protected]>
@ysksuzuki
Copy link
Contributor Author

ysksuzuki commented Oct 5, 2023 •
edited
Loading

Note:

go-grpc-middleware v2 has been released. This PR hasn't upgraded from v1 to v2 yet.
https://github.com/grpc-ecosystem/go-grpc-middleware#changes-compared-to-v1

@ysksuzuki ysksuzuki mentioned this pull request Oct 5, 2023
Closed
@terassyi terassyi requested a review from yokaze October 6, 2023 02:03
@terassyi terassyi marked this pull request as ready for review October 6, 2023 02:04
@terassyi
Copy link
Contributor

terassyi commented Oct 6, 2023

We will work on go-grpc-middleware v2 migration in another PR.
Because this migration needs a lot of changes.

yokaze
yokaze approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@yokaze yokaze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yokaze yokaze merged commit 4c63252 into main Oct 11, 2023
@yokaze yokaze deleted the k8s-1.27-rebased branch October 11, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yokaze yokaze yokaze approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ysksuzuki @terassyi @yokaze