Adjustment network component resources #695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zeroalphat <[email protected]>
Signed-off-by: zeroalphat <[email protected]>
zeroalphat
force-pushed
the
adjustment-network-component-resources
branch
from
bd1eb92 to
aaabc06
Compare
zeroalphat
requested review from
YZ775 and
masa213f
and removed request for
YZ775
masa213f
reviewed
Jan 11, 2024
static/node-dns.yml
Outdated
| @@ -58,6 +58,10 @@ spec: | |||
| mountPath: /etc/unbound | |||
| - name: var-run-unbound | |||
| mountPath: /var/run/unbound | |||
| resources: | |||
| requests: | |||
| cpu: 28m | |||
There was a problem hiding this comment.
I think 28m is too precise. How about rounding up to 50m?
Signed-off-by: zeroalphat <[email protected]>
Signed-off-by: zeroalphat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
28m50m