Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust QPS for querying kube-apiserver to 50 #36

Merged
merged 1 commit into from
Nov 29, 2021
Merged

Adjust QPS for querying kube-apiserver to 50 #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion cmd/accurate-controller/sub/root.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,10 @@ import (
"sigs.k8s.io/controller-runtime/pkg/log/zap"
)

const defaultConfigPath = "/etc/accurate/config.yaml"
const (
defaultConfigPath = "/etc/accurate/config.yaml"
defaultQPS = 50
)

var options struct {
configFile string
Expand All @@ -23,6 +26,7 @@ var options struct {
leaderElectionID string
webhookAddr string
certDir string
qps int
zapOpts zap.Options
}

Expand Down Expand Up @@ -67,6 +71,7 @@ func init() {
fs.StringVar(&options.leaderElectionID, "leader-election-id", "accurate", "ID for leader election by controller-runtime")
fs.StringVar(&options.webhookAddr, "webhook-addr", ":9443", "Listen address for the webhook endpoint")
fs.StringVar(&options.certDir, "cert-dir", "", "webhook certificate directory")
fs.IntVar(&options.qps, "apiserver-qps-throttle", defaultQPS, "The maximum QPS to the API server.")

goflags := flag.NewFlagSet("klog", flag.ExitOnError)
klog.InitFlags(goflags)
Expand Down
9 changes: 8 additions & 1 deletion cmd/accurate-controller/sub/run.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,14 @@ func subMain(ns, addr string, port int) error {
return fmt.Errorf("unable to load the configuration file: %w", err)
}

mgr, err := ctrl.NewManager(ctrl.GetConfigOrDie(), ctrl.Options{
restCfg, err := ctrl.GetConfig()
if err != nil {
return fmt.Errorf("failed to get REST config: %w", err)
}
restCfg.QPS = float32(options.qps)
restCfg.Burst = int(restCfg.QPS * 1.5)

mgr, err := ctrl.NewManager(restCfg, ctrl.Options{
Scheme: scheme,
NewClient: cluster.NewCachingClient,
MetricsBindAddress: options.metricsAddr,
Expand Down
1 change: 1 addition & 0 deletions docs/accurate-controller.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ watches:
Flags:
--add_dir_header If true, adds the file directory to the header
--alsologtostderr log to standard error as well as files
--apiserver-qps-throttle int The maximum QPS to the API server. (default 50)
--cert-dir string webhook certificate directory
--config-file string Configuration file path (default "/etc/accurate/config.yaml")
--health-probe-addr string Listen address for health probes (default ":8081")
Expand Down