Bump Kubernetes version to v1.31 and update related dependencies #152
Conversation
012xx
force-pushed
the
container-updates
branch
5 times, most recently
from
d35cc5c to
91a419c
Compare
012xx
changed the title
012xx
force-pushed
the
container-updates
branch
from
91a419c to
2d808cc
Compare
.github/workflows/helm.yaml
Outdated
| - name: Set up chart-testing | ||
| uses: helm/chart-testing-action@v2.2.1 | ||
| uses: helm/chart-testing-action@v2.7.0 |
There was a problem hiding this comment.
helm/chart-testing-action is not an action created by a verified creator, so you need to check and specify the full commit hash.
ref. https://github.com/marketplace?query=helm&verification=verified_creator&type=actions
.github/workflows/helm.yaml
Outdated
| @@ -33,10 +33,10 @@ jobs: | |||
| run: ct lint --config ct.yaml | |||
|
|
|||
| - name: Create kind cluster | |||
| uses: helm/kind-action@v1.10.0 | |||
| uses: helm/kind-action@v1.12.0 | |||
There was a problem hiding this comment.
helm/kind-action is not an action created by a verified creator, so you need to check and specify the full commit hash.
| @@ -37,26 +37,26 @@ jobs: | |||
| export TAG=$(curl -s "https://api.github.com/repos/cybozu-go/accurate/releases/latest" | jq -r .tag_name) | |||
| echo "GORELEASER_PREVIOUS_TAG=${TAG}" >> $GITHUB_ENV | |||
| - name: GoReleaser | |||
| uses: goreleaser/goreleaser-action@f82d6c1c344bcacabba2c841718984797f664a6b # v4.2.0 | |||
| uses: goreleaser/goreleaser-action@9ed2f89a662bf1735a48bc8557fd212fa902bebf # v6.1.0 | |||
There was a problem hiding this comment.
There are some breaking changes in the goreleaser/goreleaser-action between these versions. Could you describe any actions you took, or if you didn't, please explain the reason?
ref. https://github.com/goreleaser/goreleaser-action/releases
(I guess you dealt with the breaking changes by https://github.com/cybozu-go/accurate/pull/152/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52R119.)
There was a problem hiding this comment.
- Fixed a deprecated notation in the Makefile.
goreleaser build --snapshot --rm-dist->goreleaser build --snapshot --clean
https://goreleaser.com/deprecations/#-rm-dist - .goreleaser.yaml Version Fixes(Error: “Only version: 2 configuration files are supported, your configuration file is version: 0, please update it”.)
- Fixed a deprecated notation in the .goreleaser.yaml
https://goreleaser.com/deprecations/#archivesformat
format: tar.gz'->formats: [ 'tar.gz' ]
hibiki_takehara@ubuntufocal:~/accurate$
k8s:minikube> goreleaser check # using latest v2
• checking path=.goreleaser.yaml
• 1 configuration file(s) validated
• thanks for using GoReleaser!
hibiki_takehara@ubuntufocal:~/accurate$
k8s:minikube>
PROJECT
Outdated
| @@ -1,6 +1,6 @@ | |||
| domain: cybozu.com | |||
| layout: | |||
| - go.kubebuilder.io/v3 | |||
| - go.kubebuilder.io/v4 | |||
There was a problem hiding this comment.
This file should not be edited manually but with kubebuilder. If you upgrade kubebuilder, you need to follow the migration guide I think.
ref. https://book.kubebuilder.io/migration/v3vsv4
@zoetrope Could you give us your opinion whether to upgrade kubebuilder?
There was a problem hiding this comment.
(FYI)
I set up go.kubebuilder.io/v3/v4 in PROJECT referring to https://book.kubebuilder.io/plugins/available/go-v4-plugin and https://book.kubebuilder.io/reference/project-config.html?highlight=webhookVersion:#example
There was a problem hiding this comment.
As we discussed, please revert the change of kubebuilder from v4 to v3 and leave a comment referring to that.
There was a problem hiding this comment.
After discussing it as a team, we decided to stick with Kubebuilder version 3. Upgrading would involve significant changes to the directory structure and other areas, with minimal return on investment. For more details, see the reference: https://github.com/kubernetes-sigs/kubebuilder/releases/tag/v4.3.0
PROJECT
Outdated
| @@ -1,6 +1,6 @@ | |||
| domain: cybozu.com | |||
| layout: | |||
| - go.kubebuilder.io/v3 | |||
| - go.kubebuilder.io/v4 | |||
There was a problem hiding this comment.
As we discussed, please revert the change of kubebuilder from v4 to v3 and leave a comment referring to that.
Overview
Bump Kubernetes version to v1.31 and update related dependencies
What
make check-generateSkipNameValidationWhy
Regular container updates
k8s 1.31 updated