Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX : IOS registration not work after an unregistration , Ios caller number display added, only if the client is not registered and a default name is not provided the caller number will display #246

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

bazl-E
Copy link

@bazl-E bazl-E commented Jul 17, 2024

feat: Preserve device token for VoIP push notifications

Preserve the device token for VoIP push notifications to avoid the need for users to restart the app to obtain a new device 
token. Removing the device token from UserDefaults caused registration failures.

fix: IOS not displaying the caller number

if the user doesn't set a default caller name it will display the incoming caller number,
if the already set a value, the user 
has to call 

await TwilioVoice.instance.setDefaultCallerName('');
to make this work

bazl-E added 2 commits June 27, 2024 16:59
Preserve the device token for VoIP push notifications to avoid the need for users to restart the app to obtain a new device token. Removing the device token from UserDefaults caused registration failures.

fix : IOS not displaying caller number

if the user doesn't set a default caller name it will display the incoming caller number , if the already set a value user has to call [await TwilioVoice.instance.setDefaultCallerName('');] to make this work
@bazl-E bazl-E changed the title FIX : IOS registration not work after an unregistration , Ios caller number display added only if the client is not registered and a default name is not provided FIX : IOS registration not work after an unregistration , Ios caller number display added, only if the client is not registered and a default name is not provided the caller number will display Jul 17, 2024
bazl-E added 3 commits July 17, 2024 19:31
Update the handling of the localized caller name in the `SwiftTwilioVoicePlugin.swift` file. Instead of using the `clients` dictionary to retrieve the caller name, always use the `formatUSPhoneNumber` function to format the caller's phone number. This ensures consistency and avoids potential issues with missing or incorrect caller names.

Note: This commit message follows the established convention of starting with a verb in the imperative form, followed by a concise description of the changes made.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant