Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Add missing manage own calls Android permission #198

Merged
merged 6 commits into from
Nov 10, 2023

Conversation

cybex-dev
Copy link
Owner

According to Android documentation, the MANAGE_OWN_CALLS permission isn't required for system-managed ConnectionService APIs.

The Android system however requires the permission for Android 13 and lower. If not provided (atleast declared in AndroidManifest.xml), the app crashes with a SecurityException.

Changes include:

  • Update to Android Manifest
  • Add native implementation, and safety catch for security exception
  • Add method channel implementation
  • Update example

@cybex-dev cybex-dev self-assigned this Nov 10, 2023
@cybex-dev cybex-dev linked an issue Nov 10, 2023 that may be closed by this pull request
@cybex-dev cybex-dev added Android bug Something isn't working labels Nov 10, 2023
@cybex-dev cybex-dev merged commit 2b144df into master Nov 10, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant