Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 'banUnknown' JSON Schema option #237

Closed
plroebuck opened this issue Apr 4, 2018 · 0 comments
Closed

Remove 'banUnknown' JSON Schema option #237

plroebuck opened this issue Apr 4, 2018 · 0 comments
Assignees
@plroebuck
Labels
bug

Comments

@plroebuck
Copy link
Collaborator

The old 'chai2-json-schema' dependency had a banUnknown property and used it internally as an argument to tv4.validateResult(). When #55 was implemented, the property was just transitioned to tv4 module export. Unfortunately, that also rendered it useless for its intended purpose. Our unit tests still passed as none were really testing this option. As such, the code has essentially been using banUnknown = false for several years now. While its intent could be trivially added to the existing validation routine, I'm unconvinced we should. There seem to be two schools of thought on the capability, without consensus. Per ajv-validator/ajv#238, the ajv developer doesn't intend to support it.
plroebuck added a commit that referenced this issue Apr 4, 2018
@plroebuck
fix(lib/test.coffee,test/unit/test-test.coffee): Remove unused banUnk…
9e37eb8 
…nown property

Removed banUnknown property from tv4 exported module.

Fixes: #237
@plroebuck plroebuck self-assigned this Apr 4, 2018
@plroebuck plroebuck added the bug label Apr 4, 2018
@plroebuck plroebuck mentioned this issue Apr 11, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plroebuck plroebuck

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@plroebuck