Cleanup simulation reset in launch files #764
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to conclusions in #655.
webots_ros2_mavic
andwebots_ros2_tesla
can be simplified to benefit from therespawn
parameter.webots_ros2_epuck
,webots_ros2_tiago
andwebots_ros2_turtlebot
are cleaned-up to remove the reset functionality, as there is no clear solution to restart nav2 and rviz nodes. The manual solution with multiple launch files is documented in Limitations when resetting simulations #655 but won't be implemented in the package. However, it will also be documented in a new tutorial in the official ROS documentation on how to handle the reset button depending on the nodes of the package.webots_ros2_universal_robot
is also dadapted for consistency.