Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup simulation reset in launch files #764

Merged
merged 5 commits into from
Jun 7, 2023

Conversation

ygoumaz
Copy link
Contributor

@ygoumaz ygoumaz commented Jun 6, 2023

Follow-up to conclusions in #655.

  • webots_ros2_mavic and webots_ros2_tesla can be simplified to benefit from the respawn parameter.
  • webots_ros2_epuck, webots_ros2_tiago and webots_ros2_turtlebot are cleaned-up to remove the reset functionality, as there is no clear solution to restart nav2 and rviz nodes. The manual solution with multiple launch files is documented in Limitations when resetting simulations #655 but won't be implemented in the package. However, it will also be documented in a new tutorial in the official ROS documentation on how to handle the reset button depending on the nodes of the package.
  • webots_ros2_universal_robot is also dadapted for consistency.

@ygoumaz ygoumaz self-assigned this Jun 6, 2023
@ygoumaz ygoumaz added bug Something isn't working cleanup labels Jun 6, 2023
@ygoumaz ygoumaz added this to the 2023.1.0 milestone Jun 6, 2023
@ygoumaz ygoumaz added bug Something isn't working and removed bug Something isn't working labels Jun 6, 2023
@ygoumaz ygoumaz marked this pull request as ready for review June 7, 2023 08:05
@ygoumaz ygoumaz marked this pull request as draft June 7, 2023 08:05
@ygoumaz
Copy link
Contributor Author

ygoumaz commented Jun 7, 2023

Test failures are not related to this PR, but to a change in Iron and Rolling testing.

@ygoumaz ygoumaz marked this pull request as ready for review June 7, 2023 08:46
@ygoumaz ygoumaz requested a review from omichel June 7, 2023 08:47
Copy link
Member

@omichel omichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@ygoumaz ygoumaz merged commit 720cb0c into master Jun 7, 2023
@ygoumaz ygoumaz deleted the cleanup-sim-reset-launch-files branch June 7, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cleanup
Development

Successfully merging this pull request may close these issues.

2 participants