Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Utilize webots_ros2_driver in Universal Robot examples #286

Merged
merged 40 commits into from
Sep 16, 2021
Merged

Utilize webots_ros2_driver in Universal Robot examples #286

merged 40 commits into from
Sep 16, 2021

Conversation

lukicdarkoo
Copy link
Member

@lukicdarkoo lukicdarkoo commented Aug 31, 2021 •
edited
Loading

Tasks

  • Utilize webots_ros2_driver
  • Add system tests
  • Squash multiple examples
    • webots_ros2_demos: Moved to webots_ros2_universal_robot
    • webots_ros2_ur_e_description: Deleted. URDF obtained from wb_robot_get_urdf() is used instead of URDFs provided in the webots_ros2_ur_e_description package. Ideally, we will implement this in the future.
    • webots_ros2_abb: Deleted. The example wasn't providing any added value.
    • webots_ros2_universal_robot/universal_robot_multiple.wbt: This is a very nice-looking simulation. I would like to keep it, but it doesn't provide any value to the Webots ROS 2 integration. Maybe we can place it in webots-projects?
  • Others:
    • Fix webots_ros2_control to set the initial state values to NaN
    • Add streaming argument to WebotsLauncher
    • Record the simulation (with rosbag2) only on failure

Summary
This PR partially addresses #239

The webots_ros2_universal_robot package now provides:

  • robot_launch.py: An example of ros2_control integration.
  • moveit_demo_launch.py: MoveIt2 integration.
  • multirobot_launch.py: An example of controlling multiple robots (boils down to namespace and environment variables configuration).

Notes

  • Documentation has to be synced.

@lukicdarkoo lukicdarkoo self-assigned this Sep 10, 2021
@lukicdarkoo lukicdarkoo added cleanup enhancement New feature or request labels Sep 10, 2021
@lukicdarkoo lukicdarkoo added this to the 1.1.2 milestone Sep 10, 2021
@lukicdarkoo lukicdarkoo marked this pull request as ready for review September 14, 2021 12:37
@lukicdarkoo lukicdarkoo requested review from a team and BenjaminHug8 September 14, 2021 12:38
BenjaminHug8
BenjaminHug8 approved these changes Sep 15, 2021
View reviewed changes
Copy link
Contributor

@BenjaminHug8 BenjaminHug8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine on my computer, thanks!
I also adapt the documentation pages related to universal robots.

@lukicdarkoo lukicdarkoo merged commit 8bc0f2a into master Sep 16, 2021
@lukicdarkoo lukicdarkoo deleted the feature-utilize-driver-ur branch September 16, 2021 07:34
omichel added a commit that referenced this pull request Oct 29, 2021
@Timple @lukicdarkoo
@omichel @stefaniapedrazzi @dzywater @BenjaminHug8 @yanick-douven
Master into Galactic (#314)
b624671 
* Fix webots_ros2_control changelog (#251)

* Update CHANGELOG.rst

* Update CHANGELOG.rst

* Update CHANGELOG.rst

* Update CHANGELOG.rst

* Update CHANGELOG.rst

* Update CHANGELOG.rst

* Update CHANGELOG.rst

* Update CHANGELOG.rst

* Update package.xml (#252)

* Added new --no-rendering option to webots launcher (#253)

* Fix library directory

* Don't use a subdirectory

* Fix warnings (#255)

* Fix warnings

* Simpler fix

* Fix Windows build (#258)

* Fix Windows build

* ID is not a member anymore

* Export C++ libController

* Fix libController

* Update module

* Fix controller spawner

* Update robot_launch.py

* Update README.md (#259)

* Fix the IMU library exportation (#262)

* Update CMakeLists.txt

* Update CMakeLists.txt

* Prepare version number for 1.1.1 (#264)

* Prepare

* Increase version number

* Use ros2 node clock for message timestamping (#263)

* Change to ros2 node clock for all devices

* Add Python plugin support to `webots_ros2_driver` (#265)

* Add Python <--> C++ test

* Prepare

* Initial prototype

* Add WebotsNode object

* Add properties

* Import the Python lib

* Improve error handling

* Cleaner

* Add node example

* Integrate the new libController

* Delete the test

* Fix copyright

* Explain

* Copyright fix

* Constructor can be private

* Print Python errors

* Fix Windows usage

* Update webots_ros2_driver/src/PythonPlugin.cpp

Co-authored-by: Olivier Michel <[email protected]>

* Update webots_ros2_driver/src/WebotsNode.cpp

Co-authored-by: Olivier Michel <[email protected]>

* Update webots_ros2_turtlebot/webots_ros2_turtlebot/plugin_example.py

Co-authored-by: Olivier Michel <[email protected]>

* Use const

Co-authored-by: Olivier Michel <[email protected]>

* Fix Rolling warnings and `ament_python_install_package` (#266)

* Fix Rolling warnings and `ament_python_install_package`

* Add to CI

* Add runtime tests (#268)

* Add WebotsLauncher

* Add test package

* Add distance sensor tests

* Add range finder test

* Add plugin test

* Fix spelling

* Add IMU test

* Improve publishing

* Add light sensor test

* Fix colcon test

* Add CI

* Use sudo

* Update

* Update with sudo

* Add missing packages

* Add cache

* Test

* Test

* Test

* Test

* Fix

* Test

* Test

* Test

* Test

* Test

* Increase timeout

* Revert camera test

* pylint

* Fix Windows arguments

* Update webots_ros2_driver/webots_ros2_driver/webots_launcher.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update webots_ros2_driver/webots_ros2_driver/utils.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update webots_ros2_driver/webots_ros2_driver/utils.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update webots_ros2_driver/webots_ros2_driver/utils.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update utils.py

* Update driver_test.wbt

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Increase the version number (#277)

* Fix URDF importer dependencies (#279)

* Update package.xml

* Update package.xml

* Update package.xml

* Update package.xml

* Update package.xml

* Fix uninitialized mWebotsXMLElement (#278)

* fix 273

* Update webots_ros2_driver/src/WebotsNode.cpp

Co-authored-by: Darko Lukić <[email protected]>

Co-authored-by: Your Name <[email protected]>
Co-authored-by: Darko Lukić <[email protected]>

* Fix 280 (#281)

* fix 273

* Update webots_ros2_driver/src/WebotsNode.cpp

Co-authored-by: Darko Lukić <[email protected]>

* let generate webots_ros2_control.lib in windows

Co-authored-by: Your Name <[email protected]>
Co-authored-by: Darko Lukić <[email protected]>

* Print tips: robot_state_publisher started or not (#283)

Print "the `robot_description` parameter is set or not "

* Revert `robot_state_publisher` check (#285)

* Utilize `webots_ros2_driver` in `webots_ros2_mavic` and `webots_ros2_turtlebot` (#269)

* Add turtlebot tests

* Convert Mavic

* Add mavic test

* clean

* Add deps

* Fix node creation

* Increase timeout

* Better

* Fix tests

* Add killall

* Add missing deps

* Wait more in CI

* Fix

* Convert universal robot

* Add rviz

* Fix

* Revert universal robot

* Delete ur changes

* Fix

* Fix to suit to pep257 convention (#290)

* init

* fixed all errors pep257

* CI

* Creation of system test for TurtleBot SLAM tutorial (#292)

* test system turtlebot tutorial SLAM

* Navigation test and put the 2 tests in a single file

* ci_after_init install foxy turtlebot3

* fix after_init

* CI

* CI after_install_target_depend

* fix

* Update test.yml

* Update ci_after_init.bash

* Update ci_after_install_target_dependencies.bash

* CI permission after_depend

* fix

* fix CI

* check packages

* fix ci ci_after_init_bash

* fix pep257

* CI pep257

* flake8 fix

* flake8

* test only SLAM

* test only slam fix

* test only slam fix flake

* Only Slam test CI

* fix exit for CI

* quit instead exit for CI

* fix CI

* Update scripts/ci_after_init.bash

Co-authored-by: Darko Lukić <[email protected]>

* Update webots_ros2_tests/test/test_system_turtlebot_tutorials.py

Co-authored-by: Darko Lukić <[email protected]>

* improved test slam

* fix merge

* Comment after_init

* Update scripts/ci_after_init.bash

Co-authored-by: Darko Lukić <[email protected]>

Co-authored-by: Darko Lukić <[email protected]>

* fix call we_camera_recognition_disable() on NULL recognition node (#294)

* Fix Lidar range (#298)

* Utilize `webots_ros2_driver` in `webots_ros2_epuck` (#296)

* initial commit progress on epuck alone scenario

* 1st draft full conversion

* system tests in dev

* basic epuck driver converted

* system tests draft

* system tests on simple epuck ok

* Apply suggestions from code review

Co-authored-by: Darko Lukić <[email protected]>

* modif review PR

* CI

* fix CI

* fix CI package test has tf2_ros

* remove testFootPrint

* fix CI driver plugin python test

* System tests for scenarios

* System tests scenarios CI foxy

* Change test plan

* more delay plan test

* more delay plan test fix flake

* fix ci rolling

* fix CI rolling nav2bringup

* fix CI rolling nav2bringup pckg required

* removed test rats scenario

* flake8

* removed file test rats scenario

* review changes

* review changes + flake

* revert changes du to Tesla PR

* fix test tools

* adapt topics name

Co-authored-by: Darko Lukić <[email protected]>

* Utilize `webots_ros2_driver` in Universal Robot examples (#286)

* Utilize `webots_ros2_driver` in Universal Robot examples

* Fix ros control

* Delete unnecessary packages

* Convert multiarmed demo

* Add description

* Convert multirobot demo

* Delete unnecessary examples

* Unused

* Begin test

* Revert

* fix

* Test

* Avoid warnings

* Test

* Test

* Test

* Update package.xml

* Update package.xml

* Update package.xml

* Add changelog

* Delete

* Missing deps

* Increase delay

* Fix

* Record

* continue

* Update package.xml

* Update package.xml

* Update webots_launcher.py

* Update test.yml

* Update test.yml

* Fix

* Change

* Longer

* Change

* Update test.yml

* Longer

* Update test_system_universal_robot.py

* Add --input and --xacro-opts arguments to allow calling xacro2proto from a launch file

* Flake8

* Delete unnecessary packages (#301)

* Delete unnecessary packages

* Delete deps

* msgs

* Add new tiago

* wip

* Fix

* fix

* Fix

* Add

* Timeout

* Lighter

* fix

* exit

* revert

* Tesla conversion from Core to Driver (#300)

* temp commit

* temp

* temp commit

* pause to dev Autoware Interface

* temp com

* Webots .so files should be ok but tesla do not see vehicle

* system tests ok

* temp com

* change in libcontroller git

* cv2 and numpy package

* remove numpy package.xml

* correction python3-cv2/numpy

* cv2 in package.xml changed in opencv

* save file

* more time test tesla

* more time test tesla 2

* added rosbag debug ci

* flake8

* package rosbag

* qos LaneFollower

* Apply suggestions from code review

Co-authored-by: Darko Lukić <[email protected]>

* Update review

* temp com

* fix windows build

* commentary python pluggin

* Qos lane follower Windows

* lane follower remove debug msg

* Compatiblity Windows and ROS Rolling

* fix flake8

* Update webots_ros2_driver/include/webots_ros2_driver/PluginInterface.hpp

Co-authored-by: Olivier Michel <[email protected]>

* update driver test function static

* update libcontroller

* fix library

* review corrections

* fix

* update libcontroller

* python warning debug removed

Co-authored-by: Darko Lukić <[email protected]>
Co-authored-by: Olivier Michel <[email protected]>

Co-authored-by: Darko Lukić <[email protected]>
Co-authored-by: Stefan Arndt <[email protected]>
Co-authored-by: Olivier Michel <[email protected]>
Co-authored-by: Stefania Pedrazzi <[email protected]>
Co-authored-by: dzyGIT <[email protected]>
Co-authored-by: Your Name <[email protected]>
Co-authored-by: BenjaminHug8 <[email protected]>
Co-authored-by: Yanick Douven <[email protected]>
BenjaminHug8 added a commit that referenced this pull request Nov 1, 2021
@BenjaminHug8 @lukicdarkoo
@Timple @omichel @stefaniapedrazzi @dzywater @yanick-douven
Merge master in develop (#312)
bc8680e 
* Fix webots_ros2_control changelog (#251)

* Update CHANGELOG.rst

* Update CHANGELOG.rst

* Update CHANGELOG.rst

* Update CHANGELOG.rst

* Update CHANGELOG.rst

* Update CHANGELOG.rst

* Update CHANGELOG.rst

* Update CHANGELOG.rst

* Update package.xml (#252)

* Added new --no-rendering option to webots launcher (#253)

* Fix library directory

* Don't use a subdirectory

* Fix warnings (#255)

* Fix warnings

* Simpler fix

* Fix Windows build (#258)

* Fix Windows build

* ID is not a member anymore

* Export C++ libController

* Fix libController

* Update module

* Fix controller spawner

* Update robot_launch.py

* Update README.md (#259)

* Fix the IMU library exportation (#262)

* Update CMakeLists.txt

* Update CMakeLists.txt

* Prepare version number for 1.1.1 (#264)

* Prepare

* Increase version number

* Use ros2 node clock for message timestamping (#263)

* Change to ros2 node clock for all devices

* Add Python plugin support to `webots_ros2_driver` (#265)

* Add Python <--> C++ test

* Prepare

* Initial prototype

* Add WebotsNode object

* Add properties

* Import the Python lib

* Improve error handling

* Cleaner

* Add node example

* Integrate the new libController

* Delete the test

* Fix copyright

* Explain

* Copyright fix

* Constructor can be private

* Print Python errors

* Fix Windows usage

* Update webots_ros2_driver/src/PythonPlugin.cpp

Co-authored-by: Olivier Michel <[email protected]>

* Update webots_ros2_driver/src/WebotsNode.cpp

Co-authored-by: Olivier Michel <[email protected]>

* Update webots_ros2_turtlebot/webots_ros2_turtlebot/plugin_example.py

Co-authored-by: Olivier Michel <[email protected]>

* Use const

Co-authored-by: Olivier Michel <[email protected]>

* Fix Rolling warnings and `ament_python_install_package` (#266)

* Fix Rolling warnings and `ament_python_install_package`

* Add to CI

* Add runtime tests (#268)

* Add WebotsLauncher

* Add test package

* Add distance sensor tests

* Add range finder test

* Add plugin test

* Fix spelling

* Add IMU test

* Improve publishing

* Add light sensor test

* Fix colcon test

* Add CI

* Use sudo

* Update

* Update with sudo

* Add missing packages

* Add cache

* Test

* Test

* Test

* Test

* Fix

* Test

* Test

* Test

* Test

* Test

* Increase timeout

* Revert camera test

* pylint

* Fix Windows arguments

* Update webots_ros2_driver/webots_ros2_driver/webots_launcher.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update webots_ros2_driver/webots_ros2_driver/utils.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update webots_ros2_driver/webots_ros2_driver/utils.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update webots_ros2_driver/webots_ros2_driver/utils.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update utils.py

* Update driver_test.wbt

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Increase the version number (#277)

* Fix URDF importer dependencies (#279)

* Update package.xml

* Update package.xml

* Update package.xml

* Update package.xml

* Update package.xml

* Fix uninitialized mWebotsXMLElement (#278)

* fix 273

* Update webots_ros2_driver/src/WebotsNode.cpp

Co-authored-by: Darko Lukić <[email protected]>

Co-authored-by: Your Name <[email protected]>
Co-authored-by: Darko Lukić <[email protected]>

* Fix 280 (#281)

* fix 273

* Update webots_ros2_driver/src/WebotsNode.cpp

Co-authored-by: Darko Lukić <[email protected]>

* let generate webots_ros2_control.lib in windows

Co-authored-by: Your Name <[email protected]>
Co-authored-by: Darko Lukić <[email protected]>

* Print tips: robot_state_publisher started or not (#283)

Print "the `robot_description` parameter is set or not "

* Revert `robot_state_publisher` check (#285)

* Utilize `webots_ros2_driver` in `webots_ros2_mavic` and `webots_ros2_turtlebot` (#269)

* Add turtlebot tests

* Convert Mavic

* Add mavic test

* clean

* Add deps

* Fix node creation

* Increase timeout

* Better

* Fix tests

* Add killall

* Add missing deps

* Wait more in CI

* Fix

* Convert universal robot

* Add rviz

* Fix

* Revert universal robot

* Delete ur changes

* Fix

* Fix to suit to pep257 convention (#290)

* init

* fixed all errors pep257

* CI

* Creation of system test for TurtleBot SLAM tutorial (#292)

* test system turtlebot tutorial SLAM

* Navigation test and put the 2 tests in a single file

* ci_after_init install foxy turtlebot3

* fix after_init

* CI

* CI after_install_target_depend

* fix

* Update test.yml

* Update ci_after_init.bash

* Update ci_after_install_target_dependencies.bash

* CI permission after_depend

* fix

* fix CI

* check packages

* fix ci ci_after_init_bash

* fix pep257

* CI pep257

* flake8 fix

* flake8

* test only SLAM

* test only slam fix

* test only slam fix flake

* Only Slam test CI

* fix exit for CI

* quit instead exit for CI

* fix CI

* Update scripts/ci_after_init.bash

Co-authored-by: Darko Lukić <[email protected]>

* Update webots_ros2_tests/test/test_system_turtlebot_tutorials.py

Co-authored-by: Darko Lukić <[email protected]>

* improved test slam

* fix merge

* Comment after_init

* Update scripts/ci_after_init.bash

Co-authored-by: Darko Lukić <[email protected]>

Co-authored-by: Darko Lukić <[email protected]>

* fix call we_camera_recognition_disable() on NULL recognition node (#294)

* Fix Lidar range (#298)

* Utilize `webots_ros2_driver` in `webots_ros2_epuck` (#296)

* initial commit progress on epuck alone scenario

* 1st draft full conversion

* system tests in dev

* basic epuck driver converted

* system tests draft

* system tests on simple epuck ok

* Apply suggestions from code review

Co-authored-by: Darko Lukić <[email protected]>

* modif review PR

* CI

* fix CI

* fix CI package test has tf2_ros

* remove testFootPrint

* fix CI driver plugin python test

* System tests for scenarios

* System tests scenarios CI foxy

* Change test plan

* more delay plan test

* more delay plan test fix flake

* fix ci rolling

* fix CI rolling nav2bringup

* fix CI rolling nav2bringup pckg required

* removed test rats scenario

* flake8

* removed file test rats scenario

* review changes

* review changes + flake

* revert changes du to Tesla PR

* fix test tools

* adapt topics name

Co-authored-by: Darko Lukić <[email protected]>

* Utilize `webots_ros2_driver` in Universal Robot examples (#286)

* Utilize `webots_ros2_driver` in Universal Robot examples

* Fix ros control

* Delete unnecessary packages

* Convert multiarmed demo

* Add description

* Convert multirobot demo

* Delete unnecessary examples

* Unused

* Begin test

* Revert

* fix

* Test

* Avoid warnings

* Test

* Test

* Test

* Update package.xml

* Update package.xml

* Update package.xml

* Add changelog

* Delete

* Missing deps

* Increase delay

* Fix

* Record

* continue

* Update package.xml

* Update package.xml

* Update webots_launcher.py

* Update test.yml

* Update test.yml

* Fix

* Change

* Longer

* Change

* Update test.yml

* Longer

* Update test_system_universal_robot.py

* Add --input and --xacro-opts arguments to allow calling xacro2proto from a launch file

* Flake8

* Delete unnecessary packages (#301)

* Delete unnecessary packages

* Delete deps

* msgs

* Add new tiago

* wip

* Fix

* fix

* Fix

* Add

* Timeout

* Lighter

* fix

* exit

* revert

* Tesla conversion from Core to Driver (#300)

* temp commit

* temp

* temp commit

* pause to dev Autoware Interface

* temp com

* Webots .so files should be ok but tesla do not see vehicle

* system tests ok

* temp com

* change in libcontroller git

* cv2 and numpy package

* remove numpy package.xml

* correction python3-cv2/numpy

* cv2 in package.xml changed in opencv

* save file

* more time test tesla

* more time test tesla 2

* added rosbag debug ci

* flake8

* package rosbag

* qos LaneFollower

* Apply suggestions from code review

Co-authored-by: Darko Lukić <[email protected]>

* Update review

* temp com

* fix windows build

* commentary python pluggin

* Qos lane follower Windows

* lane follower remove debug msg

* Compatiblity Windows and ROS Rolling

* fix flake8

* Update webots_ros2_driver/include/webots_ros2_driver/PluginInterface.hpp

Co-authored-by: Olivier Michel <[email protected]>

* update driver test function static

* update libcontroller

* fix library

* review corrections

* fix

* update libcontroller

* python warning debug removed

Co-authored-by: Darko Lukić <[email protected]>
Co-authored-by: Olivier Michel <[email protected]>

Co-authored-by: Darko Lukić <[email protected]>
Co-authored-by: Stefan Arndt <[email protected]>
Co-authored-by: Tim Clephas <[email protected]>
Co-authored-by: Olivier Michel <[email protected]>
Co-authored-by: Stefania Pedrazzi <[email protected]>
Co-authored-by: dzyGIT <[email protected]>
Co-authored-by: Your Name <[email protected]>
Co-authored-by: Yanick Douven <[email protected]>
BenjaminHug8 added a commit that referenced this pull request Nov 3, 2021
@BenjaminHug8 @lukicdarkoo
@omichel @stefaniapedrazzi @dzywater @yanick-douven @Timple
Merge master into rolling (#324)
9919bfb 
* Fix the IMU library exportation (#262)

* Update CMakeLists.txt

* Update CMakeLists.txt

* Prepare version number for 1.1.1 (#264)

* Prepare

* Increase version number

* Use ros2 node clock for message timestamping (#263)

* Change to ros2 node clock for all devices

* Add Python plugin support to `webots_ros2_driver` (#265)

* Add Python <--> C++ test

* Prepare

* Initial prototype

* Add WebotsNode object

* Add properties

* Import the Python lib

* Improve error handling

* Cleaner

* Add node example

* Integrate the new libController

* Delete the test

* Fix copyright

* Explain

* Copyright fix

* Constructor can be private

* Print Python errors

* Fix Windows usage

* Update webots_ros2_driver/src/PythonPlugin.cpp

Co-authored-by: Olivier Michel <[email protected]>

* Update webots_ros2_driver/src/WebotsNode.cpp

Co-authored-by: Olivier Michel <[email protected]>

* Update webots_ros2_turtlebot/webots_ros2_turtlebot/plugin_example.py

Co-authored-by: Olivier Michel <[email protected]>

* Use const

Co-authored-by: Olivier Michel <[email protected]>

* Fix Rolling warnings and `ament_python_install_package` (#266)

* Fix Rolling warnings and `ament_python_install_package`

* Add to CI

* Add runtime tests (#268)

* Add WebotsLauncher

* Add test package

* Add distance sensor tests

* Add range finder test

* Add plugin test

* Fix spelling

* Add IMU test

* Improve publishing

* Add light sensor test

* Fix colcon test

* Add CI

* Use sudo

* Update

* Update with sudo

* Add missing packages

* Add cache

* Test

* Test

* Test

* Test

* Fix

* Test

* Test

* Test

* Test

* Test

* Increase timeout

* Revert camera test

* pylint

* Fix Windows arguments

* Update webots_ros2_driver/webots_ros2_driver/webots_launcher.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update webots_ros2_driver/webots_ros2_driver/utils.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update webots_ros2_driver/webots_ros2_driver/utils.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update webots_ros2_driver/webots_ros2_driver/utils.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update utils.py

* Update driver_test.wbt

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Increase the version number (#277)

* Fix URDF importer dependencies (#279)

* Update package.xml

* Update package.xml

* Update package.xml

* Update package.xml

* Update package.xml

* Fix uninitialized mWebotsXMLElement (#278)

* fix 273

* Update webots_ros2_driver/src/WebotsNode.cpp

Co-authored-by: Darko Lukić <[email protected]>

Co-authored-by: Your Name <[email protected]>
Co-authored-by: Darko Lukić <[email protected]>

* Fix 280 (#281)

* fix 273

* Update webots_ros2_driver/src/WebotsNode.cpp

Co-authored-by: Darko Lukić <[email protected]>

* let generate webots_ros2_control.lib in windows

Co-authored-by: Your Name <[email protected]>
Co-authored-by: Darko Lukić <[email protected]>

* Print tips: robot_state_publisher started or not (#283)

Print "the `robot_description` parameter is set or not "

* Revert `robot_state_publisher` check (#285)

* Utilize `webots_ros2_driver` in `webots_ros2_mavic` and `webots_ros2_turtlebot` (#269)

* Add turtlebot tests

* Convert Mavic

* Add mavic test

* clean

* Add deps

* Fix node creation

* Increase timeout

* Better

* Fix tests

* Add killall

* Add missing deps

* Wait more in CI

* Fix

* Convert universal robot

* Add rviz

* Fix

* Revert universal robot

* Delete ur changes

* Fix

* Fix to suit to pep257 convention (#290)

* init

* fixed all errors pep257

* CI

* Creation of system test for TurtleBot SLAM tutorial (#292)

* test system turtlebot tutorial SLAM

* Navigation test and put the 2 tests in a single file

* ci_after_init install foxy turtlebot3

* fix after_init

* CI

* CI after_install_target_depend

* fix

* Update test.yml

* Update ci_after_init.bash

* Update ci_after_install_target_dependencies.bash

* CI permission after_depend

* fix

* fix CI

* check packages

* fix ci ci_after_init_bash

* fix pep257

* CI pep257

* flake8 fix

* flake8

* test only SLAM

* test only slam fix

* test only slam fix flake

* Only Slam test CI

* fix exit for CI

* quit instead exit for CI

* fix CI

* Update scripts/ci_after_init.bash

Co-authored-by: Darko Lukić <[email protected]>

* Update webots_ros2_tests/test/test_system_turtlebot_tutorials.py

Co-authored-by: Darko Lukić <[email protected]>

* improved test slam

* fix merge

* Comment after_init

* Update scripts/ci_after_init.bash

Co-authored-by: Darko Lukić <[email protected]>

Co-authored-by: Darko Lukić <[email protected]>

* fix call we_camera_recognition_disable() on NULL recognition node (#294)

* Fix Lidar range (#298)

* Utilize `webots_ros2_driver` in `webots_ros2_epuck` (#296)

* initial commit progress on epuck alone scenario

* 1st draft full conversion

* system tests in dev

* basic epuck driver converted

* system tests draft

* system tests on simple epuck ok

* Apply suggestions from code review

Co-authored-by: Darko Lukić <[email protected]>

* modif review PR

* CI

* fix CI

* fix CI package test has tf2_ros

* remove testFootPrint

* fix CI driver plugin python test

* System tests for scenarios

* System tests scenarios CI foxy

* Change test plan

* more delay plan test

* more delay plan test fix flake

* fix ci rolling

* fix CI rolling nav2bringup

* fix CI rolling nav2bringup pckg required

* removed test rats scenario

* flake8

* removed file test rats scenario

* review changes

* review changes + flake

* revert changes du to Tesla PR

* fix test tools

* adapt topics name

Co-authored-by: Darko Lukić <[email protected]>

* Utilize `webots_ros2_driver` in Universal Robot examples (#286)

* Utilize `webots_ros2_driver` in Universal Robot examples

* Fix ros control

* Delete unnecessary packages

* Convert multiarmed demo

* Add description

* Convert multirobot demo

* Delete unnecessary examples

* Unused

* Begin test

* Revert

* fix

* Test

* Avoid warnings

* Test

* Test

* Test

* Update package.xml

* Update package.xml

* Update package.xml

* Add changelog

* Delete

* Missing deps

* Increase delay

* Fix

* Record

* continue

* Update package.xml

* Update package.xml

* Update webots_launcher.py

* Update test.yml

* Update test.yml

* Fix

* Change

* Longer

* Change

* Update test.yml

* Longer

* Update test_system_universal_robot.py

* Add --input and --xacro-opts arguments to allow calling xacro2proto from a launch file

* Flake8

* Delete unnecessary packages (#301)

* Delete unnecessary packages

* Delete deps

* msgs

* Add new tiago

* wip

* Fix

* fix

* Fix

* Add

* Timeout

* Lighter

* fix

* exit

* revert

* Tesla conversion from Core to Driver (#300)

* temp commit

* temp

* temp commit

* pause to dev Autoware Interface

* temp com

* Webots .so files should be ok but tesla do not see vehicle

* system tests ok

* temp com

* change in libcontroller git

* cv2 and numpy package

* remove numpy package.xml

* correction python3-cv2/numpy

* cv2 in package.xml changed in opencv

* save file

* more time test tesla

* more time test tesla 2

* added rosbag debug ci

* flake8

* package rosbag

* qos LaneFollower

* Apply suggestions from code review

Co-authored-by: Darko Lukić <[email protected]>

* Update review

* temp com

* fix windows build

* commentary python pluggin

* Qos lane follower Windows

* lane follower remove debug msg

* Compatiblity Windows and ROS Rolling

* fix flake8

* Update webots_ros2_driver/include/webots_ros2_driver/PluginInterface.hpp

Co-authored-by: Olivier Michel <[email protected]>

* update driver test function static

* update libcontroller

* fix library

* review corrections

* fix

* update libcontroller

* python warning debug removed

Co-authored-by: Darko Lukić <[email protected]>
Co-authored-by: Olivier Michel <[email protected]>

* Fix universal robot system tests random faillure (#311)

* fix longer

* test order launch

* remove ros bag

* fix clang

* test spin once between init and send goal

* fix

* test

* test follow traj client

* sleep test

* test confirmation need sleep

* Add commentary

* longer

* correction path abb and sleep moved

* add current issue

* longer

* test wait_for_server

* longer timeout

* timeout test bit longer

* remove debug

* Correction for Rolling CI testing failling due to change in ros2control (base_interface) (#315)

* compliance CI folling foxy testing main from TIMPLE ros2control change base interface

* fix compliance

* cast double in int

* new fix cast int

* review github

* update .yaml

* debug and clean conversion duration

* Update test.yml

* fix rolling and galactic testing

* fix merge of rolling testing in main

Co-authored-by: Olivier Michel <[email protected]>

* Prepare release 1.1.2 (#317)

* fix

* Fixed broken LED (#322)

* Fixed broken LED

* Fixed test

* Fixed test

* Use Int32 instead of UInt32 to be closer to the Webots API, fixed test

Co-authored-by: Darko Lukić <[email protected]>
Co-authored-by: Stefan Arndt <[email protected]>
Co-authored-by: Olivier Michel <[email protected]>
Co-authored-by: Stefania Pedrazzi <[email protected]>
Co-authored-by: dzyGIT <[email protected]>
Co-authored-by: Your Name <[email protected]>
Co-authored-by: Yanick Douven <[email protected]>
Co-authored-by: Tim Clephas <[email protected]>
BenjaminHug8 added a commit that referenced this pull request Nov 3, 2021
@BenjaminHug8 @lukicdarkoo
@Timple @omichel @stefaniapedrazzi @dzywater @yanick-douven
Merge master into galactic (#323)
0c1263e 
* Fix webots_ros2_control changelog (#251)

* Update CHANGELOG.rst

* Update CHANGELOG.rst

* Update CHANGELOG.rst

* Update CHANGELOG.rst

* Update CHANGELOG.rst

* Update CHANGELOG.rst

* Update CHANGELOG.rst

* Update CHANGELOG.rst

* Update package.xml (#252)

* Added new --no-rendering option to webots launcher (#253)

* Fix library directory

* Don't use a subdirectory

* Fix warnings (#255)

* Fix warnings

* Simpler fix

* Fix Windows build (#258)

* Fix Windows build

* ID is not a member anymore

* Export C++ libController

* Fix libController

* Update module

* Fix controller spawner

* Update robot_launch.py

* Update README.md (#259)

* Fix the IMU library exportation (#262)

* Update CMakeLists.txt

* Update CMakeLists.txt

* Prepare version number for 1.1.1 (#264)

* Prepare

* Increase version number

* Use ros2 node clock for message timestamping (#263)

* Change to ros2 node clock for all devices

* Add Python plugin support to `webots_ros2_driver` (#265)

* Add Python <--> C++ test

* Prepare

* Initial prototype

* Add WebotsNode object

* Add properties

* Import the Python lib

* Improve error handling

* Cleaner

* Add node example

* Integrate the new libController

* Delete the test

* Fix copyright

* Explain

* Copyright fix

* Constructor can be private

* Print Python errors

* Fix Windows usage

* Update webots_ros2_driver/src/PythonPlugin.cpp

Co-authored-by: Olivier Michel <[email protected]>

* Update webots_ros2_driver/src/WebotsNode.cpp

Co-authored-by: Olivier Michel <[email protected]>

* Update webots_ros2_turtlebot/webots_ros2_turtlebot/plugin_example.py

Co-authored-by: Olivier Michel <[email protected]>

* Use const

Co-authored-by: Olivier Michel <[email protected]>

* Fix Rolling warnings and `ament_python_install_package` (#266)

* Fix Rolling warnings and `ament_python_install_package`

* Add to CI

* Add runtime tests (#268)

* Add WebotsLauncher

* Add test package

* Add distance sensor tests

* Add range finder test

* Add plugin test

* Fix spelling

* Add IMU test

* Improve publishing

* Add light sensor test

* Fix colcon test

* Add CI

* Use sudo

* Update

* Update with sudo

* Add missing packages

* Add cache

* Test

* Test

* Test

* Test

* Fix

* Test

* Test

* Test

* Test

* Test

* Increase timeout

* Revert camera test

* pylint

* Fix Windows arguments

* Update webots_ros2_driver/webots_ros2_driver/webots_launcher.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update webots_ros2_driver/webots_ros2_driver/utils.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update webots_ros2_driver/webots_ros2_driver/utils.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update webots_ros2_driver/webots_ros2_driver/utils.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update utils.py

* Update driver_test.wbt

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Increase the version number (#277)

* Fix URDF importer dependencies (#279)

* Update package.xml

* Update package.xml

* Update package.xml

* Update package.xml

* Update package.xml

* Fix uninitialized mWebotsXMLElement (#278)

* fix 273

* Update webots_ros2_driver/src/WebotsNode.cpp

Co-authored-by: Darko Lukić <[email protected]>

Co-authored-by: Your Name <[email protected]>
Co-authored-by: Darko Lukić <[email protected]>

* Fix 280 (#281)

* fix 273

* Update webots_ros2_driver/src/WebotsNode.cpp

Co-authored-by: Darko Lukić <[email protected]>

* let generate webots_ros2_control.lib in windows

Co-authored-by: Your Name <[email protected]>
Co-authored-by: Darko Lukić <[email protected]>

* Print tips: robot_state_publisher started or not (#283)

Print "the `robot_description` parameter is set or not "

* Revert `robot_state_publisher` check (#285)

* Utilize `webots_ros2_driver` in `webots_ros2_mavic` and `webots_ros2_turtlebot` (#269)

* Add turtlebot tests

* Convert Mavic

* Add mavic test

* clean

* Add deps

* Fix node creation

* Increase timeout

* Better

* Fix tests

* Add killall

* Add missing deps

* Wait more in CI

* Fix

* Convert universal robot

* Add rviz

* Fix

* Revert universal robot

* Delete ur changes

* Fix

* Fix to suit to pep257 convention (#290)

* init

* fixed all errors pep257

* CI

* Creation of system test for TurtleBot SLAM tutorial (#292)

* test system turtlebot tutorial SLAM

* Navigation test and put the 2 tests in a single file

* ci_after_init install foxy turtlebot3

* fix after_init

* CI

* CI after_install_target_depend

* fix

* Update test.yml

* Update ci_after_init.bash

* Update ci_after_install_target_dependencies.bash

* CI permission after_depend

* fix

* fix CI

* check packages

* fix ci ci_after_init_bash

* fix pep257

* CI pep257

* flake8 fix

* flake8

* test only SLAM

* test only slam fix

* test only slam fix flake

* Only Slam test CI

* fix exit for CI

* quit instead exit for CI

* fix CI

* Update scripts/ci_after_init.bash

Co-authored-by: Darko Lukić <[email protected]>

* Update webots_ros2_tests/test/test_system_turtlebot_tutorials.py

Co-authored-by: Darko Lukić <[email protected]>

* improved test slam

* fix merge

* Comment after_init

* Update scripts/ci_after_init.bash

Co-authored-by: Darko Lukić <[email protected]>

Co-authored-by: Darko Lukić <[email protected]>

* fix call we_camera_recognition_disable() on NULL recognition node (#294)

* Fix Lidar range (#298)

* Utilize `webots_ros2_driver` in `webots_ros2_epuck` (#296)

* initial commit progress on epuck alone scenario

* 1st draft full conversion

* system tests in dev

* basic epuck driver converted

* system tests draft

* system tests on simple epuck ok

* Apply suggestions from code review

Co-authored-by: Darko Lukić <[email protected]>

* modif review PR

* CI

* fix CI

* fix CI package test has tf2_ros

* remove testFootPrint

* fix CI driver plugin python test

* System tests for scenarios

* System tests scenarios CI foxy

* Change test plan

* more delay plan test

* more delay plan test fix flake

* fix ci rolling

* fix CI rolling nav2bringup

* fix CI rolling nav2bringup pckg required

* removed test rats scenario

* flake8

* removed file test rats scenario

* review changes

* review changes + flake

* revert changes du to Tesla PR

* fix test tools

* adapt topics name

Co-authored-by: Darko Lukić <[email protected]>

* Utilize `webots_ros2_driver` in Universal Robot examples (#286)

* Utilize `webots_ros2_driver` in Universal Robot examples

* Fix ros control

* Delete unnecessary packages

* Convert multiarmed demo

* Add description

* Convert multirobot demo

* Delete unnecessary examples

* Unused

* Begin test

* Revert

* fix

* Test

* Avoid warnings

* Test

* Test

* Test

* Update package.xml

* Update package.xml

* Update package.xml

* Add changelog

* Delete

* Missing deps

* Increase delay

* Fix

* Record

* continue

* Update package.xml

* Update package.xml

* Update webots_launcher.py

* Update test.yml

* Update test.yml

* Fix

* Change

* Longer

* Change

* Update test.yml

* Longer

* Update test_system_universal_robot.py

* Add --input and --xacro-opts arguments to allow calling xacro2proto from a launch file

* Flake8

* Delete unnecessary packages (#301)

* Delete unnecessary packages

* Delete deps

* msgs

* Add new tiago

* wip

* Fix

* fix

* Fix

* Add

* Timeout

* Lighter

* fix

* exit

* revert

* Tesla conversion from Core to Driver (#300)

* temp commit

* temp

* temp commit

* pause to dev Autoware Interface

* temp com

* Webots .so files should be ok but tesla do not see vehicle

* system tests ok

* temp com

* change in libcontroller git

* cv2 and numpy package

* remove numpy package.xml

* correction python3-cv2/numpy

* cv2 in package.xml changed in opencv

* save file

* more time test tesla

* more time test tesla 2

* added rosbag debug ci

* flake8

* package rosbag

* qos LaneFollower

* Apply suggestions from code review

Co-authored-by: Darko Lukić <[email protected]>

* Update review

* temp com

* fix windows build

* commentary python pluggin

* Qos lane follower Windows

* lane follower remove debug msg

* Compatiblity Windows and ROS Rolling

* fix flake8

* Update webots_ros2_driver/include/webots_ros2_driver/PluginInterface.hpp

Co-authored-by: Olivier Michel <[email protected]>

* update driver test function static

* update libcontroller

* fix library

* review corrections

* fix

* update libcontroller

* python warning debug removed

Co-authored-by: Darko Lukić <[email protected]>
Co-authored-by: Olivier Michel <[email protected]>

* Fix universal robot system tests random faillure (#311)

* fix longer

* test order launch

* remove ros bag

* fix clang

* test spin once between init and send goal

* fix

* test

* test follow traj client

* sleep test

* test confirmation need sleep

* Add commentary

* longer

* correction path abb and sleep moved

* add current issue

* longer

* test wait_for_server

* longer timeout

* timeout test bit longer

* remove debug

* Correction for Rolling CI testing failling due to change in ros2control (base_interface) (#315)

* compliance CI folling foxy testing main from TIMPLE ros2control change base interface

* fix compliance

* cast double in int

* new fix cast int

* review github

* update .yaml

* debug and clean conversion duration

* Update test.yml

* fix rolling and galactic testing

* fix merge of rolling testing in main

Co-authored-by: Olivier Michel <[email protected]>

* Prepare release 1.1.2 (#317)

* fix

* Fixed broken LED (#322)

* Fixed broken LED

* Fixed test

* Fixed test

* Use Int32 instead of UInt32 to be closer to the Webots API, fixed test

Co-authored-by: Darko Lukić <[email protected]>
Co-authored-by: Stefan Arndt <[email protected]>
Co-authored-by: Tim Clephas <[email protected]>
Co-authored-by: Olivier Michel <[email protected]>
Co-authored-by: Stefania Pedrazzi <[email protected]>
Co-authored-by: dzyGIT <[email protected]>
Co-authored-by: Your Name <[email protected]>
Co-authored-by: Yanick Douven <[email protected]>
BenjaminHug8 added a commit that referenced this pull request Nov 3, 2021
@BenjaminHug8 @Timple
@lukicdarkoo @omichel @stefaniapedrazzi @dzywater @yanick-douven
Merge master into foxy (#321)
859755d 
* Added new --no-rendering option to webots launcher (#253)

* Fix library directory

* Don't use a subdirectory

* Fix warnings (#255)

* Fix warnings

* Simpler fix

* Fix Windows build (#258)

* Fix Windows build

* ID is not a member anymore

* Export C++ libController

* Fix libController

* Update module

* Fix controller spawner

* Update robot_launch.py

* Update README.md (#259)

* Fix the IMU library exportation (#262)

* Update CMakeLists.txt

* Update CMakeLists.txt

* Prepare version number for 1.1.1 (#264)

* Prepare

* Increase version number

* Use ros2 node clock for message timestamping (#263)

* Change to ros2 node clock for all devices

* Add Python plugin support to `webots_ros2_driver` (#265)

* Add Python <--> C++ test

* Prepare

* Initial prototype

* Add WebotsNode object

* Add properties

* Import the Python lib

* Improve error handling

* Cleaner

* Add node example

* Integrate the new libController

* Delete the test

* Fix copyright

* Explain

* Copyright fix

* Constructor can be private

* Print Python errors

* Fix Windows usage

* Update webots_ros2_driver/src/PythonPlugin.cpp

Co-authored-by: Olivier Michel <[email protected]>

* Update webots_ros2_driver/src/WebotsNode.cpp

Co-authored-by: Olivier Michel <[email protected]>

* Update webots_ros2_turtlebot/webots_ros2_turtlebot/plugin_example.py

Co-authored-by: Olivier Michel <[email protected]>

* Use const

Co-authored-by: Olivier Michel <[email protected]>

* Fix Rolling warnings and `ament_python_install_package` (#266)

* Fix Rolling warnings and `ament_python_install_package`

* Add to CI

* Add runtime tests (#268)

* Add WebotsLauncher

* Add test package

* Add distance sensor tests

* Add range finder test

* Add plugin test

* Fix spelling

* Add IMU test

* Improve publishing

* Add light sensor test

* Fix colcon test

* Add CI

* Use sudo

* Update

* Update with sudo

* Add missing packages

* Add cache

* Test

* Test

* Test

* Test

* Fix

* Test

* Test

* Test

* Test

* Test

* Increase timeout

* Revert camera test

* pylint

* Fix Windows arguments

* Update webots_ros2_driver/webots_ros2_driver/webots_launcher.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update webots_ros2_driver/webots_ros2_driver/utils.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update webots_ros2_driver/webots_ros2_driver/utils.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update webots_ros2_driver/webots_ros2_driver/utils.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update utils.py

* Update driver_test.wbt

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Increase the version number (#277)

* Fix URDF importer dependencies (#279)

* Update package.xml

* Update package.xml

* Update package.xml

* Update package.xml

* Update package.xml

* Fix uninitialized mWebotsXMLElement (#278)

* fix 273

* Update webots_ros2_driver/src/WebotsNode.cpp

Co-authored-by: Darko Lukić <[email protected]>

Co-authored-by: Your Name <[email protected]>
Co-authored-by: Darko Lukić <[email protected]>

* Fix 280 (#281)

* fix 273

* Update webots_ros2_driver/src/WebotsNode.cpp

Co-authored-by: Darko Lukić <[email protected]>

* let generate webots_ros2_control.lib in windows

Co-authored-by: Your Name <[email protected]>
Co-authored-by: Darko Lukić <[email protected]>

* Print tips: robot_state_publisher started or not (#283)

Print "the `robot_description` parameter is set or not "

* Revert `robot_state_publisher` check (#285)

* Utilize `webots_ros2_driver` in `webots_ros2_mavic` and `webots_ros2_turtlebot` (#269)

* Add turtlebot tests

* Convert Mavic

* Add mavic test

* clean

* Add deps

* Fix node creation

* Increase timeout

* Better

* Fix tests

* Add killall

* Add missing deps

* Wait more in CI

* Fix

* Convert universal robot

* Add rviz

* Fix

* Revert universal robot

* Delete ur changes

* Fix

* Fix to suit to pep257 convention (#290)

* init

* fixed all errors pep257

* CI

* Creation of system test for TurtleBot SLAM tutorial (#292)

* test system turtlebot tutorial SLAM

* Navigation test and put the 2 tests in a single file

* ci_after_init install foxy turtlebot3

* fix after_init

* CI

* CI after_install_target_depend

* fix

* Update test.yml

* Update ci_after_init.bash

* Update ci_after_install_target_dependencies.bash

* CI permission after_depend

* fix

* fix CI

* check packages

* fix ci ci_after_init_bash

* fix pep257

* CI pep257

* flake8 fix

* flake8

* test only SLAM

* test only slam fix

* test only slam fix flake

* Only Slam test CI

* fix exit for CI

* quit instead exit for CI

* fix CI

* Update scripts/ci_after_init.bash

Co-authored-by: Darko Lukić <[email protected]>

* Update webots_ros2_tests/test/test_system_turtlebot_tutorials.py

Co-authored-by: Darko Lukić <[email protected]>

* improved test slam

* fix merge

* Comment after_init

* Update scripts/ci_after_init.bash

Co-authored-by: Darko Lukić <[email protected]>

Co-authored-by: Darko Lukić <[email protected]>

* fix call we_camera_recognition_disable() on NULL recognition node (#294)

* Fix Lidar range (#298)

* Utilize `webots_ros2_driver` in `webots_ros2_epuck` (#296)

* initial commit progress on epuck alone scenario

* 1st draft full conversion

* system tests in dev

* basic epuck driver converted

* system tests draft

* system tests on simple epuck ok

* Apply suggestions from code review

Co-authored-by: Darko Lukić <[email protected]>

* modif review PR

* CI

* fix CI

* fix CI package test has tf2_ros

* remove testFootPrint

* fix CI driver plugin python test

* System tests for scenarios

* System tests scenarios CI foxy

* Change test plan

* more delay plan test

* more delay plan test fix flake

* fix ci rolling

* fix CI rolling nav2bringup

* fix CI rolling nav2bringup pckg required

* removed test rats scenario

* flake8

* removed file test rats scenario

* review changes

* review changes + flake

* revert changes du to Tesla PR

* fix test tools

* adapt topics name

Co-authored-by: Darko Lukić <[email protected]>

* Utilize `webots_ros2_driver` in Universal Robot examples (#286)

* Utilize `webots_ros2_driver` in Universal Robot examples

* Fix ros control

* Delete unnecessary packages

* Convert multiarmed demo

* Add description

* Convert multirobot demo

* Delete unnecessary examples

* Unused

* Begin test

* Revert

* fix

* Test

* Avoid warnings

* Test

* Test

* Test

* Update package.xml

* Update package.xml

* Update package.xml

* Add changelog

* Delete

* Missing deps

* Increase delay

* Fix

* Record

* continue

* Update package.xml

* Update package.xml

* Update webots_launcher.py

* Update test.yml

* Update test.yml

* Fix

* Change

* Longer

* Change

* Update test.yml

* Longer

* Update test_system_universal_robot.py

* Add --input and --xacro-opts arguments to allow calling xacro2proto from a launch file

* Flake8

* Delete unnecessary packages (#301)

* Delete unnecessary packages

* Delete deps

* msgs

* Add new tiago

* wip

* Fix

* fix

* Fix

* Add

* Timeout

* Lighter

* fix

* exit

* revert

* Tesla conversion from Core to Driver (#300)

* temp commit

* temp

* temp commit

* pause to dev Autoware Interface

* temp com

* Webots .so files should be ok but tesla do not see vehicle

* system tests ok

* temp com

* change in libcontroller git

* cv2 and numpy package

* remove numpy package.xml

* correction python3-cv2/numpy

* cv2 in package.xml changed in opencv

* save file

* more time test tesla

* more time test tesla 2

* added rosbag debug ci

* flake8

* package rosbag

* qos LaneFollower

* Apply suggestions from code review

Co-authored-by: Darko Lukić <[email protected]>

* Update review

* temp com

* fix windows build

* commentary python pluggin

* Qos lane follower Windows

* lane follower remove debug msg

* Compatiblity Windows and ROS Rolling

* fix flake8

* Update webots_ros2_driver/include/webots_ros2_driver/PluginInterface.hpp

Co-authored-by: Olivier Michel <[email protected]>

* update driver test function static

* update libcontroller

* fix library

* review corrections

* fix

* update libcontroller

* python warning debug removed

Co-authored-by: Darko Lukić <[email protected]>
Co-authored-by: Olivier Michel <[email protected]>

* Fix universal robot system tests random faillure (#311)

* fix longer

* test order launch

* remove ros bag

* fix clang

* test spin once between init and send goal

* fix

* test

* test follow traj client

* sleep test

* test confirmation need sleep

* Add commentary

* longer

* correction path abb and sleep moved

* add current issue

* longer

* test wait_for_server

* longer timeout

* timeout test bit longer

* remove debug

* Correction for Rolling CI testing failling due to change in ros2control (base_interface) (#315)

* compliance CI folling foxy testing main from TIMPLE ros2control change base interface

* fix compliance

* cast double in int

* new fix cast int

* review github

* update .yaml

* debug and clean conversion duration

* Update test.yml

* fix rolling and galactic testing

* fix merge of rolling testing in main

Co-authored-by: Olivier Michel <[email protected]>

* Prepare release 1.1.2 (#317)

* fix

* Fixed broken LED (#322)

* Fixed broken LED

* Fixed test

* Fixed test

* Use Int32 instead of UInt32 to be closer to the Webots API, fixed test

Co-authored-by: Stefan Arndt <[email protected]>
Co-authored-by: Tim Clephas <[email protected]>
Co-authored-by: Darko Lukić <[email protected]>
Co-authored-by: Olivier Michel <[email protected]>
Co-authored-by: Stefania Pedrazzi <[email protected]>
Co-authored-by: dzyGIT <[email protected]>
Co-authored-by: Your Name <[email protected]>
Co-authored-by: Yanick Douven <[email protected]>
BenjaminHug8 added a commit that referenced this pull request Nov 5, 2021
@BenjaminHug8 @Timple
@lukicdarkoo @omichel @stefaniapedrazzi @dzywater @yanick-douven
Merge master into Foxy (#329)
9df5abe 
* Added new --no-rendering option to webots launcher (#253)

* Fix library directory

* Don't use a subdirectory

* Fix warnings (#255)

* Fix warnings

* Simpler fix

* Fix Windows build (#258)

* Fix Windows build

* ID is not a member anymore

* Export C++ libController

* Fix libController

* Update module

* Fix controller spawner

* Update robot_launch.py

* Update README.md (#259)

* Fix the IMU library exportation (#262)

* Update CMakeLists.txt

* Update CMakeLists.txt

* Prepare version number for 1.1.1 (#264)

* Prepare

* Increase version number

* Use ros2 node clock for message timestamping (#263)

* Change to ros2 node clock for all devices

* Add Python plugin support to `webots_ros2_driver` (#265)

* Add Python <--> C++ test

* Prepare

* Initial prototype

* Add WebotsNode object

* Add properties

* Import the Python lib

* Improve error handling

* Cleaner

* Add node example

* Integrate the new libController

* Delete the test

* Fix copyright

* Explain

* Copyright fix

* Constructor can be private

* Print Python errors

* Fix Windows usage

* Update webots_ros2_driver/src/PythonPlugin.cpp

Co-authored-by: Olivier Michel <[email protected]>

* Update webots_ros2_driver/src/WebotsNode.cpp

Co-authored-by: Olivier Michel <[email protected]>

* Update webots_ros2_turtlebot/webots_ros2_turtlebot/plugin_example.py

Co-authored-by: Olivier Michel <[email protected]>

* Use const

Co-authored-by: Olivier Michel <[email protected]>

* Fix Rolling warnings and `ament_python_install_package` (#266)

* Fix Rolling warnings and `ament_python_install_package`

* Add to CI

* Add runtime tests (#268)

* Add WebotsLauncher

* Add test package

* Add distance sensor tests

* Add range finder test

* Add plugin test

* Fix spelling

* Add IMU test

* Improve publishing

* Add light sensor test

* Fix colcon test

* Add CI

* Use sudo

* Update

* Update with sudo

* Add missing packages

* Add cache

* Test

* Test

* Test

* Test

* Fix

* Test

* Test

* Test

* Test

* Test

* Increase timeout

* Revert camera test

* pylint

* Fix Windows arguments

* Update webots_ros2_driver/webots_ros2_driver/webots_launcher.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update webots_ros2_driver/webots_ros2_driver/utils.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update webots_ros2_driver/webots_ros2_driver/utils.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update webots_ros2_driver/webots_ros2_driver/utils.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update utils.py

* Update driver_test.wbt

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Increase the version number (#277)

* Fix URDF importer dependencies (#279)

* Update package.xml

* Update package.xml

* Update package.xml

* Update package.xml

* Update package.xml

* Fix uninitialized mWebotsXMLElement (#278)

* fix 273

* Update webots_ros2_driver/src/WebotsNode.cpp

Co-authored-by: Darko Lukić <[email protected]>

Co-authored-by: Your Name <[email protected]>
Co-authored-by: Darko Lukić <[email protected]>

* Fix 280 (#281)

* fix 273

* Update webots_ros2_driver/src/WebotsNode.cpp

Co-authored-by: Darko Lukić <[email protected]>

* let generate webots_ros2_control.lib in windows

Co-authored-by: Your Name <[email protected]>
Co-authored-by: Darko Lukić <[email protected]>

* Print tips: robot_state_publisher started or not (#283)

Print "the `robot_description` parameter is set or not "

* Revert `robot_state_publisher` check (#285)

* Utilize `webots_ros2_driver` in `webots_ros2_mavic` and `webots_ros2_turtlebot` (#269)

* Add turtlebot tests

* Convert Mavic

* Add mavic test

* clean

* Add deps

* Fix node creation

* Increase timeout

* Better

* Fix tests

* Add killall

* Add missing deps

* Wait more in CI

* Fix

* Convert universal robot

* Add rviz

* Fix

* Revert universal robot

* Delete ur changes

* Fix

* Fix to suit to pep257 convention (#290)

* init

* fixed all errors pep257

* CI

* Creation of system test for TurtleBot SLAM tutorial (#292)

* test system turtlebot tutorial SLAM

* Navigation test and put the 2 tests in a single file

* ci_after_init install foxy turtlebot3

* fix after_init

* CI

* CI after_install_target_depend

* fix

* Update test.yml

* Update ci_after_init.bash

* Update ci_after_install_target_dependencies.bash

* CI permission after_depend

* fix

* fix CI

* check packages

* fix ci ci_after_init_bash

* fix pep257

* CI pep257

* flake8 fix

* flake8

* test only SLAM

* test only slam fix

* test only slam fix flake

* Only Slam test CI

* fix exit for CI

* quit instead exit for CI

* fix CI

* Update scripts/ci_after_init.bash

Co-authored-by: Darko Lukić <[email protected]>

* Update webots_ros2_tests/test/test_system_turtlebot_tutorials.py

Co-authored-by: Darko Lukić <[email protected]>

* improved test slam

* fix merge

* Comment after_init

* Update scripts/ci_after_init.bash

Co-authored-by: Darko Lukić <[email protected]>

Co-authored-by: Darko Lukić <[email protected]>

* fix call we_camera_recognition_disable() on NULL recognition node (#294)

* Fix Lidar range (#298)

* Utilize `webots_ros2_driver` in `webots_ros2_epuck` (#296)

* initial commit progress on epuck alone scenario

* 1st draft full conversion

* system tests in dev

* basic epuck driver converted

* system tests draft

* system tests on simple epuck ok

* Apply suggestions from code review

Co-authored-by: Darko Lukić <[email protected]>

* modif review PR

* CI

* fix CI

* fix CI package test has tf2_ros

* remove testFootPrint

* fix CI driver plugin python test

* System tests for scenarios

* System tests scenarios CI foxy

* Change test plan

* more delay plan test

* more delay plan test fix flake

* fix ci rolling

* fix CI rolling nav2bringup

* fix CI rolling nav2bringup pckg required

* removed test rats scenario

* flake8

* removed file test rats scenario

* review changes

* review changes + flake

* revert changes du to Tesla PR

* fix test tools

* adapt topics name

Co-authored-by: Darko Lukić <[email protected]>

* Utilize `webots_ros2_driver` in Universal Robot examples (#286)

* Utilize `webots_ros2_driver` in Universal Robot examples

* Fix ros control

* Delete unnecessary packages

* Convert multiarmed demo

* Add description

* Convert multirobot demo

* Delete unnecessary examples

* Unused

* Begin test

* Revert

* fix

* Test

* Avoid warnings

* Test

* Test

* Test

* Update package.xml

* Update package.xml

* Update package.xml

* Add changelog

* Delete

* Missing deps

* Increase delay

* Fix

* Record

* continue

* Update package.xml

* Update package.xml

* Update webots_launcher.py

* Update test.yml

* Update test.yml

* Fix

* Change

* Longer

* Change

* Update test.yml

* Longer

* Update test_system_universal_robot.py

* Add --input and --xacro-opts arguments to allow calling xacro2proto from a launch file

* Flake8

* Delete unnecessary packages (#301)

* Delete unnecessary packages

* Delete deps

* msgs

* Add new tiago

* wip

* Fix

* fix

* Fix

* Add

* Timeout

* Lighter

* fix

* exit

* revert

* Tesla conversion from Core to Driver (#300)

* temp commit

* temp

* temp commit

* pause to dev Autoware Interface

* temp com

* Webots .so files should be ok but tesla do not see vehicle

* system tests ok

* temp com

* change in libcontroller git

* cv2 and numpy package

* remove numpy package.xml

* correction python3-cv2/numpy

* cv2 in package.xml changed in opencv

* save file

* more time test tesla

* more time test tesla 2

* added rosbag debug ci

* flake8

* package rosbag

* qos LaneFollower

* Apply suggestions from code review

Co-authored-by: Darko Lukić <[email protected]>

* Update review

* temp com

* fix windows build

* commentary python pluggin

* Qos lane follower Windows

* lane follower remove debug msg

* Compatiblity Windows and ROS Rolling

* fix flake8

* Update webots_ros2_driver/include/webots_ros2_driver/PluginInterface.hpp

Co-authored-by: Olivier Michel <[email protected]>

* update driver test function static

* update libcontroller

* fix library

* review corrections

* fix

* update libcontroller

* python warning debug removed

Co-authored-by: Darko Lukić <[email protected]>
Co-authored-by: Olivier Michel <[email protected]>

* Fix universal robot system tests random faillure (#311)

* fix longer

* test order launch

* remove ros bag

* fix clang

* test spin once between init and send goal

* fix

* test

* test follow traj client

* sleep test

* test confirmation need sleep

* Add commentary

* longer

* correction path abb and sleep moved

* add current issue

* longer

* test wait_for_server

* longer timeout

* timeout test bit longer

* remove debug

* Correction for Rolling CI testing failling due to change in ros2control (base_interface) (#315)

* compliance CI folling foxy testing main from TIMPLE ros2control change base interface

* fix compliance

* cast double in int

* new fix cast int

* review github

* update .yaml

* debug and clean conversion duration

* Update test.yml

* fix rolling and galactic testing

* fix merge of rolling testing in main

Co-authored-by: Olivier Michel <[email protected]>

* Prepare release 1.1.2 (#317)

* Fixed broken LED (#322)

* Fixed broken LED

* Fixed test

* Fixed test

* Use Int32 instead of UInt32 to be closer to the Webots API, fixed test

* add ros_environnement (#328)

Co-authored-by: Stefan Arndt <[email protected]>
Co-authored-by: Tim Clephas <[email protected]>
Co-authored-by: Darko Lukić <[email protected]>
Co-authored-by: Olivier Michel <[email protected]>
Co-authored-by: Stefania Pedrazzi <[email protected]>
Co-authored-by: dzyGIT <[email protected]>
Co-authored-by: Your Name <[email protected]>
Co-authored-by: Yanick Douven <[email protected]>
BenjaminHug8 added a commit that referenced this pull request Nov 5, 2021
@BenjaminHug8 @Timple
@lukicdarkoo @omichel @stefaniapedrazzi @dzywater @yanick-douven
Merge Foxy into Master (#330)
1164086 
* Added new --no-rendering option to webots launcher (#253)

* Fix library directory

* Don't use a subdirectory

* Fix warnings (#255)

* Fix warnings

* Simpler fix

* Fix Windows build (#258)

* Fix Windows build

* ID is not a member anymore

* Export C++ libController

* Fix libController

* Update module

* Fix controller spawner

* Update robot_launch.py

* Update README.md (#259)

* Fix the IMU library exportation (#262)

* Update CMakeLists.txt

* Update CMakeLists.txt

* Prepare version number for 1.1.1 (#264)

* Prepare

* Increase version number

* Use ros2 node clock for message timestamping (#263)

* Change to ros2 node clock for all devices

* Add Python plugin support to `webots_ros2_driver` (#265)

* Add Python <--> C++ test

* Prepare

* Initial prototype

* Add WebotsNode object

* Add properties

* Import the Python lib

* Improve error handling

* Cleaner

* Add node example

* Integrate the new libController

* Delete the test

* Fix copyright

* Explain

* Copyright fix

* Constructor can be private

* Print Python errors

* Fix Windows usage

* Update webots_ros2_driver/src/PythonPlugin.cpp

Co-authored-by: Olivier Michel <[email protected]>

* Update webots_ros2_driver/src/WebotsNode.cpp

Co-authored-by: Olivier Michel <[email protected]>

* Update webots_ros2_turtlebot/webots_ros2_turtlebot/plugin_example.py

Co-authored-by: Olivier Michel <[email protected]>

* Use const

Co-authored-by: Olivier Michel <[email protected]>

* Fix Rolling warnings and `ament_python_install_package` (#266)

* Fix Rolling warnings and `ament_python_install_package`

* Add to CI

* Add runtime tests (#268)

* Add WebotsLauncher

* Add test package

* Add distance sensor tests

* Add range finder test

* Add plugin test

* Fix spelling

* Add IMU test

* Improve publishing

* Add light sensor test

* Fix colcon test

* Add CI

* Use sudo

* Update

* Update with sudo

* Add missing packages

* Add cache

* Test

* Test

* Test

* Test

* Fix

* Test

* Test

* Test

* Test

* Test

* Increase timeout

* Revert camera test

* pylint

* Fix Windows arguments

* Update webots_ros2_driver/webots_ros2_driver/webots_launcher.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update webots_ros2_driver/webots_ros2_driver/utils.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update webots_ros2_driver/webots_ros2_driver/utils.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update webots_ros2_driver/webots_ros2_driver/utils.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update utils.py

* Update driver_test.wbt

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Merge master into foxy (#321)

* Added new --no-rendering option to webots launcher (#253)

* Fix library directory

* Don't use a subdirectory

* Fix warnings (#255)

* Fix warnings

* Simpler fix

* Fix Windows build (#258)

* Fix Windows build

* ID is not a member anymore

* Export C++ libController

* Fix libController

* Update module

* Fix controller spawner

* Update robot_launch.py

* Update README.md (#259)

* Fix the IMU library exportation (#262)

* Update CMakeLists.txt

* Update CMakeLists.txt

* Prepare version number for 1.1.1 (#264)

* Prepare

* Increase version number

* Use ros2 node clock for message timestamping (#263)

* Change to ros2 node clock for all devices

* Add Python plugin support to `webots_ros2_driver` (#265)

* Add Python <--> C++ test

* Prepare

* Initial prototype

* Add WebotsNode object

* Add properties

* Import the Python lib

* Improve error handling

* Cleaner

* Add node example

* Integrate the new libController

* Delete the test

* Fix copyright

* Explain

* Copyright fix

* Constructor can be private

* Print Python errors

* Fix Windows usage

* Update webots_ros2_driver/src/PythonPlugin.cpp

Co-authored-by: Olivier Michel <[email protected]>

* Update webots_ros2_driver/src/WebotsNode.cpp

Co-authored-by: Olivier Michel <[email protected]>

* Update webots_ros2_turtlebot/webots_ros2_turtlebot/plugin_example.py

Co-authored-by: Olivier Michel <[email protected]>

* Use const

Co-authored-by: Olivier Michel <[email protected]>

* Fix Rolling warnings and `ament_python_install_package` (#266)

* Fix Rolling warnings and `ament_python_install_package`

* Add to CI

* Add runtime tests (#268)

* Add WebotsLauncher

* Add test package

* Add distance sensor tests

* Add range finder test

* Add plugin test

* Fix spelling

* Add IMU test

* Improve publishing

* Add light sensor test

* Fix colcon test

* Add CI

* Use sudo

* Update

* Update with sudo

* Add missing packages

* Add cache

* Test

* Test

* Test

* Test

* Fix

* Test

* Test

* Test

* Test

* Test

* Increase timeout

* Revert camera test

* pylint

* Fix Windows arguments

* Update webots_ros2_driver/webots_ros2_driver/webots_launcher.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update webots_ros2_driver/webots_ros2_driver/utils.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update webots_ros2_driver/webots_ros2_driver/utils.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update webots_ros2_driver/webots_ros2_driver/utils.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update utils.py

* Update driver_test.wbt

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Increase the version number (#277)

* Fix URDF importer dependencies (#279)

* Update package.xml

* Update package.xml

* Update package.xml

* Update package.xml

* Update package.xml

* Fix uninitialized mWebotsXMLElement (#278)

* fix 273

* Update webots_ros2_driver/src/WebotsNode.cpp

Co-authored-by: Darko Lukić <[email protected]>

Co-authored-by: Your Name <[email protected]>
Co-authored-by: Darko Lukić <[email protected]>

* Fix 280 (#281)

* fix 273

* Update webots_ros2_driver/src/WebotsNode.cpp

Co-authored-by: Darko Lukić <[email protected]>

* let generate webots_ros2_control.lib in windows

Co-authored-by: Your Name <[email protected]>
Co-authored-by: Darko Lukić <[email protected]>

* Print tips: robot_state_publisher started or not (#283)

Print "the `robot_description` parameter is set or not "

* Revert `robot_state_publisher` check (#285)

* Utilize `webots_ros2_driver` in `webots_ros2_mavic` and `webots_ros2_turtlebot` (#269)

* Add turtlebot tests

* Convert Mavic

* Add mavic test

* clean

* Add deps

* Fix node creation

* Increase timeout

* Better

* Fix tests

* Add killall

* Add missing deps

* Wait more in CI

* Fix

* Convert universal robot

* Add rviz

* Fix

* Revert universal robot

* Delete ur changes

* Fix

* Fix to suit to pep257 convention (#290)

* init

* fixed all errors pep257

* CI

* Creation of system test for TurtleBot SLAM tutorial (#292)

* test system turtlebot tutorial SLAM

* Navigation test and put the 2 tests in a single file

* ci_after_init install foxy turtlebot3

* fix after_init

* CI

* CI after_install_target_depend

* fix

* Update test.yml

* Update ci_after_init.bash

* Update ci_after_install_target_dependencies.bash

* CI permission after_depend

* fix

* fix CI

* check packages

* fix ci ci_after_init_bash

* fix pep257

* CI pep257

* flake8 fix

* flake8

* test only SLAM

* test only slam fix

* test only slam fix flake

* Only Slam test CI

* fix exit for CI

* quit instead exit for CI

* fix CI

* Update scripts/ci_after_init.bash

Co-authored-by: Darko Lukić <[email protected]>

* Update webots_ros2_tests/test/test_system_turtlebot_tutorials.py

Co-authored-by: Darko Lukić <[email protected]>

* improved test slam

* fix merge

* Comment after_init

* Update scripts/ci_after_init.bash

Co-authored-by: Darko Lukić <[email protected]>

Co-authored-by: Darko Lukić <[email protected]>

* fix call we_camera_recognition_disable() on NULL recognition node (#294)

* Fix Lidar range (#298)

* Utilize `webots_ros2_driver` in `webots_ros2_epuck` (#296)

* initial commit progress on epuck alone scenario

* 1st draft full conversion

* system tests in dev

* basic epuck driver converted

* system tests draft

* system tests on simple epuck ok

* Apply suggestions from code review

Co-authored-by: Darko Lukić <[email protected]>

* modif review PR

* CI

* fix CI

* fix CI package test has tf2_ros

* remove testFootPrint

* fix CI driver plugin python test

* System tests for scenarios

* System tests scenarios CI foxy

* Change test plan

* more delay plan test

* more delay plan test fix flake

* fix ci rolling

* fix CI rolling nav2bringup

* fix CI rolling nav2bringup pckg required

* removed test rats scenario

* flake8

* removed file test rats scenario

* review changes

* review changes + flake

* revert changes du to Tesla PR

* fix test tools

* adapt topics name

Co-authored-by: Darko Lukić <[email protected]>

* Utilize `webots_ros2_driver` in Universal Robot examples (#286)

* Utilize `webots_ros2_driver` in Universal Robot examples

* Fix ros control

* Delete unnecessary packages

* Convert multiarmed demo

* Add description

* Convert multirobot demo

* Delete unnecessary examples

* Unused

* Begin test

* Revert

* fix

* Test

* Avoid warnings

* Test

* Test

* Test

* Update package.xml

* Update package.xml

* Update package.xml

* Add changelog

* Delete

* Missing deps

* Increase delay

* Fix

* Record

* continue

* Update package.xml

* Update package.xml

* Update webots_launcher.py

* Update test.yml

* Update test.yml

* Fix

* Change

* Longer

* Change

* Update test.yml

* Longer

* Update test_system_universal_robot.py

* Add --input and --xacro-opts arguments to allow calling xacro2proto from a launch file

* Flake8

* Delete unnecessary packages (#301)

* Delete unnecessary packages

* Delete deps

* msgs

* Add new tiago

* wip

* Fix

* fix

* Fix

* Add

* Timeout

* Lighter

* fix

* exit

* revert

* Tesla conversion from Core to Driver (#300)

* temp commit

* temp

* temp commit

* pause to dev Autoware Interface

* temp com

* Webots .so files should be ok but tesla do not see vehicle

* system tests ok

* temp com

* change in libcontroller git

* cv2 and numpy package

* remove numpy package.xml

* correction python3-cv2/numpy

* cv2 in package.xml changed in opencv

* save file

* more time test tesla

* more time test tesla 2

* added rosbag debug ci

* flake8

* package rosbag

* qos LaneFollower

* Apply suggestions from code review

Co-authored-by: Darko Lukić <[email protected]>

* Update review

* temp com

* fix windows build

* commentary python pluggin

* Qos lane follower Windows

* lane follower remove debug msg

* Compatiblity Windows and ROS Rolling

* fix flake8

* Update webots_ros2_driver/include/webots_ros2_driver/PluginInterface.hpp

Co-authored-by: Olivier Michel <[email protected]>

* update driver test function static

* update libcontroller

* fix library

* review corrections

* fix

* update libcontroller

* python warning debug removed

Co-authored-by: Darko Lukić <[email protected]>
Co-authored-by: Olivier Michel <[email protected]>

* Fix universal robot system tests random faillure (#311)

* fix longer

* test order launch

* remove ros bag

* fix clang

* test spin once between init and send goal

* fix

* test

* test follow traj client

* sleep test

* test confirmation need sleep

* Add commentary

* longer

* correction path abb and sleep moved

* add current issue

* longer

* test wait_for_server

* longer timeout

* timeout test bit longer

* remove debug

* Correction for Rolling CI testing failling due to change in ros2control (base_interface) (#315)

* compliance CI folling foxy testing main from TIMPLE ros2control change base interface

* fix compliance

* cast double in int

* new fix cast int

* review github

* update .yaml

* debug and clean conversion duration

* Update test.yml

* fix rolling and galactic testing

* fix merge of rolling testing in main

Co-authored-by: Olivier Michel <[email protected]>

* Prepare release 1.1.2 (#317)

* fix

* Fixed broken LED (#322)

* Fixed broken LED

* Fixed test

* Fixed test

* Use Int32 instead of UInt32 to be closer to the Webots API, fixed test

Co-authored-by: Stefan Arndt <[email protected]>
Co-authored-by: Tim Clephas <[email protected]>
Co-authored-by: Darko Lukić <[email protected]>
Co-authored-by: Olivier Michel <[email protected]>
Co-authored-by: Stefania Pedrazzi <[email protected]>
Co-authored-by: dzyGIT <[email protected]>
Co-authored-by: Your Name <[email protected]>
Co-authored-by: Yanick Douven <[email protected]>

* Merge master into foxy fix (#325)

* fix merge

* libcontroller

* Merge master into Foxy (#329)

* Added new --no-rendering option to webots launcher (#253)

* Fix library directory

* Don't use a subdirectory

* Fix warnings (#255)

* Fix warnings

* Simpler fix

* Fix Windows build (#258)

* Fix Windows build

* ID is not a member anymore

* Export C++ libController

* Fix libController

* Update module

* Fix controller spawner

* Update robot_launch.py

* Update README.md (#259)

* Fix the IMU library exportation (#262)

* Update CMakeLists.txt

* Update CMakeLists.txt

* Prepare version number for 1.1.1 (#264)

* Prepare

* Increase version number

* Use ros2 node clock for message timestamping (#263)

* Change to ros2 node clock for all devices

* Add Python plugin support to `webots_ros2_driver` (#265)

* Add Python <--> C++ test

* Prepare

* Initial prototype

* Add WebotsNode object

* Add properties

* Import the Python lib

* Improve error handling

* Cleaner

* Add node example

* Integrate the new libController

* Delete the test

* Fix copyright

* Explain

* Copyright fix

* Constructor can be private

* Print Python errors

* Fix Windows usage

* Update webots_ros2_driver/src/PythonPlugin.cpp

Co-authored-by: Olivier Michel <[email protected]>

* Update webots_ros2_driver/src/WebotsNode.cpp

Co-authored-by: Olivier Michel <[email protected]>

* Update webots_ros2_turtlebot/webots_ros2_turtlebot/plugin_example.py

Co-authored-by: Olivier Michel <[email protected]>

* Use const

Co-authored-by: Olivier Michel <[email protected]>

* Fix Rolling warnings and `ament_python_install_package` (#266)

* Fix Rolling warnings and `ament_python_install_package`

* Add to CI

* Add runtime tests (#268)

* Add WebotsLauncher

* Add test package

* Add distance sensor tests

* Add range finder test

* Add plugin test

* Fix spelling

* Add IMU test

* Improve publishing

* Add light sensor test

* Fix colcon test

* Add CI

* Use sudo

* Update

* Update with sudo

* Add missing packages

* Add cache

* Test

* Test

* Test

* Test

* Fix

* Test

* Test

* Test

* Test

* Test

* Increase timeout

* Revert camera test

* pylint

* Fix Windows arguments

* Update webots_ros2_driver/webots_ros2_driver/webots_launcher.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update webots_ros2_driver/webots_ros2_driver/utils.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update webots_ros2_driver/webots_ros2_driver/utils.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update webots_ros2_driver/webots_ros2_driver/utils.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update utils.py

* Update driver_test.wbt

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Increase the version number (#277)

* Fix URDF importer dependencies (#279)

* Update package.xml

* Update package.xml

* Update package.xml

* Update package.xml

* Update package.xml

* Fix uninitialized mWebotsXMLElement (#278)

* fix 273

* Update webots_ros2_driver/src/WebotsNode.cpp

Co-authored-by: Darko Lukić <[email protected]>

Co-authored-by: Your Name <[email protected]>
Co-authored-by: Darko Lukić <[email protected]>

* Fix 280 (#281)

* fix 273

* Update webots_ros2_driver/src/WebotsNode.cpp

Co-authored-by: Darko Lukić <[email protected]>

* let generate webots_ros2_control.lib in windows

Co-authored-by: Your Name <[email protected]>
Co-authored-by: Darko Lukić <[email protected]>

* Print tips: robot_state_publisher started or not (#283)

Print "the `robot_description` parameter is set or not "

* Revert `robot_state_publisher` check (#285)

* Utilize `webots_ros2_driver` in `webots_ros2_mavic` and `webots_ros2_turtlebot` (#269)

* Add turtlebot tests

* Convert Mavic

* Add mavic test

* clean

* Add deps

* Fix node creation

* Increase timeout

* Better

* Fix tests

* Add killall

* Add missing deps

* Wait more in CI

* Fix

* Convert universal robot

* Add rviz

* Fix

* Revert universal robot

* Delete ur changes

* Fix

* Fix to suit to pep257 convention (#290)

* init

* fixed all errors pep257

* CI

* Creation of system test for TurtleBot SLAM tutorial (#292)

* test system turtlebot tutorial SLAM

* Navigation test and put the 2 tests in a single file

* ci_after_init install foxy turtlebot3

* fix after_init

* CI

* CI after_install_target_depend

* fix

* Update test.yml

* Update ci_after_init.bash

* Update ci_after_install_target_dependencies.bash

* CI permission after_depend

* fix

* fix CI

* check packages

* fix ci ci_after_init_bash

* fix pep257

* CI pep257

* flake8 fix

* flake8

* test only SLAM

* test only slam fix

* test only slam fix flake

* Only Slam test CI

* fix exit for CI

* quit instead exit for CI

* fix CI

* Update scripts/ci_after_init.bash

Co-authored-by: Darko Lukić <[email protected]>

* Update webots_ros2_tests/test/test_system_turtlebot_tutorials.py

Co-authored-by: Darko Lukić <[email protected]>

* improved test slam

* fix merge

* Comment after_init

* Update scripts/ci_after_init.bash

Co-authored-by: Darko Lukić <[email protected]>

Co-authored-by: Darko Lukić <[email protected]>

* fix call we_camera_recognition_disable() on NULL recognition node (#294)

* Fix Lidar range (#298)

* Utilize `webots_ros2_driver` in `webots_ros2_epuck` (#296)

* initial commit progress on epuck alone scenario

* 1st draft full conversion

* system tests in dev

* basic epuck driver converted

* system tests draft

* system tests on simple epuck ok

* Apply suggestions from code review

Co-authored-by: Darko Lukić <[email protected]>

* modif review PR

* CI

* fix CI

* fix CI package test has tf2_ros

* remove testFootPrint

* fix CI driver plugin python test

* System tests for scenarios

* System tests scenarios CI foxy

* Change test plan

* more delay plan test

* more delay plan test fix flake

* fix ci rolling

* fix CI rolling nav2bringup

* fix CI rolling nav2bringup pckg required

* removed test rats scenario

* flake8

* removed file test rats scenario

* review changes

* review changes + flake

* revert changes du to Tesla PR

* fix test tools

* adapt topics name

Co-authored-by: Darko Lukić <[email protected]>

* Utilize `webots_ros2_driver` in Universal Robot examples (#286)

* Utilize `webots_ros2_driver` in Universal Robot examples

* Fix ros control

* Delete unnecessary packages

* Convert multiarmed demo

* Add description

* Convert multirobot demo

* Delete unnecessary examples

* Unused

* Begin test

* Revert

* fix

* Test

* Avoid warnings

* Test

* Test

* Test

* Update package.xml

* Update package.xml

* Update package.xml

* Add changelog

* Delete

* Missing deps

* Increase delay

* Fix

* Record

* continue

* Update package.xml

* Update package.xml

* Update webots_launcher.py

* Update test.yml

* Update test.yml

* Fix

* Change

* Longer

* Change

* Update test.yml

* Longer

* Update test_system_universal_robot.py

* Add --input and --xacro-opts arguments to allow calling xacro2proto from a launch file

* Flake8

* Delete unnecessary packages (#301)

* Delete unnecessary packages

* Delete deps

* msgs

* Add new tiago

* wip

* Fix

* fix

* Fix

* Add

* Timeout

* Lighter

* fix

* exit

* revert

* Tesla conversion from Core to Driver (#300)

* temp commit

* temp

* temp commit

* pause to dev Autoware Interface

* temp com

* Webots .so files should be ok but tesla do not see vehicle

* system tests ok

* temp com

* change in libcontroller git

* cv2 and numpy package

* remove numpy package.xml

* correction python3-cv2/numpy

* cv2 in package.xml changed in opencv

* save file

* more time test tesla

* more time test tesla 2

* added rosbag debug ci

* flake8

* package rosbag

* qos LaneFollower

* Apply suggestions from code review

Co-authored-by: Darko Lukić <[email protected]>

* Update review

* temp com

* fix windows build

* commentary python pluggin

* Qos lane follower Windows

* lane follower remove debug msg

* Compatiblity Windows and ROS Rolling

* fix flake8

* Update webots_ros2_driver/include/webots_ros2_driver/PluginInterface.hpp

Co-authored-by: Olivier Michel <[email protected]>

* update driver test function static

* update libcontroller

* fix library

* review corrections

* fix

* update libcontroller

* python warning debug removed

Co-authored-by: Darko Lukić <[email protected]>
Co-authored-by: Olivier Michel <[email protected]>

* Fix universal robot system tests random faillure (#311)

* fix longer

* test order launch

* remove ros bag

* fix clang

* test spin once between init and send goal

* fix

* test

* test follow traj client

* sleep test

* test confirmation need sleep

* Add commentary

* longer

* correction path abb and sleep moved

* add current issue

* longer

* test wait_for_server

* longer timeout

* timeout test bit longer

* remove debug

* Correction for Rolling CI testing failling due to change in ros2control (base_interface) (#315)

* compliance CI folling foxy testing main from TIMPLE ros2control change base interface

* fix compliance

* cast double in int

* new fix cast int

* review github

* update .yaml

* debug and clean conversion duration

* Update test.yml

* fix rolling and galactic testing

* fix merge of rolling testing in main

Co-authored-by: Olivier Michel <[email protected]>

* Prepare release 1.1.2 (#317)

* Fixed broken LED (#322)

* Fixed broken LED

* Fixed test

* Fixed test

* Use Int32 instead of UInt32 to be closer to the Webots API, fixed test

* add ros_environnement (#328)

Co-authored-by: Stefan Arndt <[email protected]>
Co-authored-by: Tim Clephas <[email protected]>
Co-authored-by: Darko Lukić <[email protected]>
Co-authored-by: Olivier Michel <[email protected]>
Co-authored-by: Stefania Pedrazzi <[email protected]>
Co-authored-by: dzyGIT <[email protected]>
Co-authored-by: Your Name <[email protected]>
Co-authored-by: Yanick Douven <[email protected]>

Co-authored-by: Stefan Arndt <[email protected]>
Co-authored-by: Tim Clephas <[email protected]>
Co-authored-by: Darko Lukić <[email protected]>
Co-authored-by: Olivier Michel <[email protected]>
Co-authored-by: Stefania Pedrazzi <[email protected]>
Co-authored-by: dzyGIT <[email protected]>
Co-authored-by: Your Name <[email protected]>
Co-authored-by: Yanick Douven <[email protected]>
BenjaminHug8 added a commit that referenced this pull request Nov 5, 2021
@BenjaminHug8 @Timple
@lukicdarkoo @omichel @stefaniapedrazzi @dzywater @yanick-douven
Merge Galactic into master (#332)
f4808a3 
* Master into Galactic (#314)

* Fix webots_ros2_control changelog (#251)

* Update CHANGELOG.rst

* Update CHANGELOG.rst

* Update CHANGELOG.rst

* Update CHANGELOG.rst

* Update CHANGELOG.rst

* Update CHANGELOG.rst

* Update CHANGELOG.rst

* Update CHANGELOG.rst

* Update package.xml (#252)

* Added new --no-rendering option to webots launcher (#253)

* Fix library directory

* Don't use a subdirectory

* Fix warnings (#255)

* Fix warnings

* Simpler fix

* Fix Windows build (#258)

* Fix Windows build

* ID is not a member anymore

* Export C++ libController

* Fix libController

* Update module

* Fix controller spawner

* Update robot_launch.py

* Update README.md (#259)

* Fix the IMU library exportation (#262)

* Update CMakeLists.txt

* Update CMakeLists.txt

* Prepare version number for 1.1.1 (#264)

* Prepare

* Increase version number

* Use ros2 node clock for message timestamping (#263)

* Change to ros2 node clock for all devices

* Add Python plugin support to `webots_ros2_driver` (#265)

* Add Python <--> C++ test

* Prepare

* Initial prototype

* Add WebotsNode object

* Add properties

* Import the Python lib

* Improve error handling

* Cleaner

* Add node example

* Integrate the new libController

* Delete the test

* Fix copyright

* Explain

* Copyright fix

* Constructor can be private

* Print Python errors

* Fix Windows usage

* Update webots_ros2_driver/src/PythonPlugin.cpp

Co-authored-by: Olivier Michel <[email protected]>

* Update webots_ros2_driver/src/WebotsNode.cpp

Co-authored-by: Olivier Michel <[email protected]>

* Update webots_ros2_turtlebot/webots_ros2_turtlebot/plugin_example.py

Co-authored-by: Olivier Michel <[email protected]>

* Use const

Co-authored-by: Olivier Michel <[email protected]>

* Fix Rolling warnings and `ament_python_install_package` (#266)

* Fix Rolling warnings and `ament_python_install_package`

* Add to CI

* Add runtime tests (#268)

* Add WebotsLauncher

* Add test package

* Add distance sensor tests

* Add range finder test

* Add plugin test

* Fix spelling

* Add IMU test

* Improve publishing

* Add light sensor test

* Fix colcon test

* Add CI

* Use sudo

* Update

* Update with sudo

* Add missing packages

* Add cache

* Test

* Test

* Test

* Test

* Fix

* Test

* Test

* Test

* Test

* Test

* Increase timeout

* Revert camera test

* pylint

* Fix Windows arguments

* Update webots_ros2_driver/webots_ros2_driver/webots_launcher.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update webots_ros2_driver/webots_ros2_driver/utils.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update webots_ros2_driver/webots_ros2_driver/utils.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update webots_ros2_driver/webots_ros2_driver/utils.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update utils.py

* Update driver_test.wbt

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Increase the version number (#277)

* Fix URDF importer dependencies (#279)

* Update package.xml

* Update package.xml

* Update package.xml

* Update package.xml

* Update package.xml

* Fix uninitialized mWebotsXMLElement (#278)

* fix 273

* Update webots_ros2_driver/src/WebotsNode.cpp

Co-authored-by: Darko Lukić <[email protected]>

Co-authored-by: Your Name <[email protected]>
Co-authored-by: Darko Lukić <[email protected]>

* Fix 280 (#281)

* fix 273

* Update webots_ros2_driver/src/WebotsNode.cpp

Co-authored-by: Darko Lukić <[email protected]>

* let generate webots_ros2_control.lib in windows

Co-authored-by: Your Name <[email protected]>
Co-authored-by: Darko Lukić <[email protected]>

* Print tips: robot_state_publisher started or not (#283)

Print "the `robot_description` parameter is set or not "

* Revert `robot_state_publisher` check (#285)

* Utilize `webots_ros2_driver` in `webots_ros2_mavic` and `webots_ros2_turtlebot` (#269)

* Add turtlebot tests

* Convert Mavic

* Add mavic test

* clean

* Add deps

* Fix node creation

* Increase timeout

* Better

* Fix tests

* Add killall

* Add missing deps

* Wait more in CI

* Fix

* Convert universal robot

* Add rviz

* Fix

* Revert universal robot

* Delete ur changes

* Fix

* Fix to suit to pep257 convention (#290)

* init

* fixed all errors pep257

* CI

* Creation of system test for TurtleBot SLAM tutorial (#292)

* test system turtlebot tutorial SLAM

* Navigation test and put the 2 tests in a single file

* ci_after_init install foxy turtlebot3

* fix after_init

* CI

* CI after_install_target_depend

* fix

* Update test.yml

* Update ci_after_init.bash

* Update ci_after_install_target_dependencies.bash

* CI permission after_depend

* fix

* fix CI

* check packages

* fix ci ci_after_init_bash

* fix pep257

* CI pep257

* flake8 fix

* flake8

* test only SLAM

* test only slam fix

* test only slam fix flake

* Only Slam test CI

* fix exit for CI

* quit instead exit for CI

* fix CI

* Update scripts/ci_after_init.bash

Co-authored-by: Darko Lukić <[email protected]>

* Update webots_ros2_tests/test/test_system_turtlebot_tutorials.py

Co-authored-by: Darko Lukić <[email protected]>

* improved test slam

* fix merge

* Comment after_init

* Update scripts/ci_after_init.bash

Co-authored-by: Darko Lukić <[email protected]>

Co-authored-by: Darko Lukić <[email protected]>

* fix call we_camera_recognition_disable() on NULL recognition node (#294)

* Fix Lidar range (#298)

* Utilize `webots_ros2_driver` in `webots_ros2_epuck` (#296)

* initial commit progress on epuck alone scenario

* 1st draft full conversion

* system tests in dev

* basic epuck driver converted

* system tests draft

* system tests on simple epuck ok

* Apply suggestions from code review

Co-authored-by: Darko Lukić <[email protected]>

* modif review PR

* CI

* fix CI

* fix CI package test has tf2_ros

* remove testFootPrint

* fix CI driver plugin python test

* System tests for scenarios

* System tests scenarios CI foxy

* Change test plan

* more delay plan test

* more delay plan test fix flake

* fix ci rolling

* fix CI rolling nav2bringup

* fix CI rolling nav2bringup pckg required

* removed test rats scenario

* flake8

* removed file test rats scenario

* review changes

* review changes + flake

* revert changes du to Tesla PR

* fix test tools

* adapt topics name

Co-authored-by: Darko Lukić <[email protected]>

* Utilize `webots_ros2_driver` in Universal Robot examples (#286)

* Utilize `webots_ros2_driver` in Universal Robot examples

* Fix ros control

* Delete unnecessary packages

* Convert multiarmed demo

* Add description

* Convert multirobot demo

* Delete unnecessary examples

* Unused

* Begin test

* Revert

* fix

* Test

* Avoid warnings

* Test

* Test

* Test

* Update package.xml

* Update package.xml

* Update package.xml

* Add changelog

* Delete

* Missing deps

* Increase delay

* Fix

* Record

* continue

* Update package.xml

* Update package.xml

* Update webots_launcher.py

* Update test.yml

* Update test.yml

* Fix

* Change

* Longer

* Change

* Update test.yml

* Longer

* Update test_system_universal_robot.py

* Add --input and --xacro-opts arguments to allow calling xacro2proto from a launch file

* Flake8

* Delete unnecessary packages (#301)

* Delete unnecessary packages

* Delete deps

* msgs

* Add new tiago

* wip

* Fix

* fix

* Fix

* Add

* Timeout

* Lighter

* fix

* exit

* revert

* Tesla conversion from Core to Driver (#300)

* temp commit

* temp

* temp commit

* pause to dev Autoware Interface

* temp com

* Webots .so files should be ok but tesla do not see vehicle

* system tests ok

* temp com

* change in libcontroller git

* cv2 and numpy package

* remove numpy package.xml

* correction python3-cv2/numpy

* cv2 in package.xml changed in opencv

* save file

* more time test tesla

* more time test tesla 2

* added rosbag debug ci

* flake8

* package rosbag

* qos LaneFollower

* Apply suggestions from code review

Co-authored-by: Darko Lukić <[email protected]>

* Update review

* temp com

* fix windows build

* commentary python pluggin

* Qos lane follower Windows

* lane follower remove debug msg

* Compatiblity Windows and ROS Rolling

* fix flake8

* Update webots_ros2_driver/include/webots_ros2_driver/PluginInterface.hpp

Co-authored-by: Olivier Michel <[email protected]>

* update driver test function static

* update libcontroller

* fix library

* review corrections

* fix

* update libcontroller

* python warning debug removed

Co-authored-by: Darko Lukić <[email protected]>
Co-authored-by: Olivier Michel <[email protected]>

Co-authored-by: Darko Lukić <[email protected]>
Co-authored-by: Stefan Arndt <[email protected]>
Co-authored-by: Olivier Michel <[email protected]>
Co-authored-by: Stefania Pedrazzi <[email protected]>
Co-authored-by: dzyGIT <[email protected]>
Co-authored-by: Your Name <[email protected]>
Co-authored-by: BenjaminHug8 <[email protected]>
Co-authored-by: Yanick Douven <[email protected]>

* Merge master into galactic (#323)

* Fix webots_ros2_control changelog (#251)

* Update CHANGELOG.rst

* Update CHANGELOG.rst

* Update CHANGELOG.rst

* Update CHANGELOG.rst

* Update CHANGELOG.rst

* Update CHANGELOG.rst

* Update CHANGELOG.rst

* Update CHANGELOG.rst

* Update package.xml (#252)

* Added new --no-rendering option to webots launcher (#253)

* Fix library directory

* Don't use a subdirectory

* Fix warnings (#255)

* Fix warnings

* Simpler fix

* Fix Windows build (#258)

* Fix Windows build

* ID is not a member anymore

* Export C++ libController

* Fix libController

* Update module

* Fix controller spawner

* Update robot_launch.py

* Update README.md (#259)

* Fix the IMU library exportation (#262)

* Update CMakeLists.txt

* Update CMakeLists.txt

* Prepare version number for 1.1.1 (#264)

* Prepare

* Increase version number

* Use ros2 node clock for message timestamping (#263)

* Change to ros2 node clock for all devices

* Add Python plugin support to `webots_ros2_driver` (#265)

* Add Python <--> C++ test

* Prepare

* Initial prototype

* Add WebotsNode object

* Add properties

* Import the Python lib

* Improve error handling

* Cleaner

* Add node example

* Integrate the new libController

* Delete the test

* Fix copyright

* Explain

* Copyright fix

* Constructor can be private

* Print Python errors

* Fix Windows usage

* Update webots_ros2_driver/src/PythonPlugin.cpp

Co-authored-by: Olivier Michel <[email protected]>

* Update webots_ros2_driver/src/WebotsNode.cpp

Co-authored-by: Olivier Michel <[email protected]>

* Update webots_ros2_turtlebot/webots_ros2_turtlebot/plugin_example.py

Co-authored-by: Olivier Michel <[email protected]>

* Use const

Co-authored-by: Olivier Michel <[email protected]>

* Fix Rolling warnings and `ament_python_install_package` (#266)

* Fix Rolling warnings and `ament_python_install_package`

* Add to CI

* Add runtime tests (#268)

* Add WebotsLauncher

* Add test package

* Add distance sensor tests

* Add range finder test

* Add plugin test

* Fix spelling

* Add IMU test

* Improve publishing

* Add light sensor test

* Fix colcon test

* Add CI

* Use sudo

* Update

* Update with sudo

* Add missing packages

* Add cache

* Test

* Test

* Test

* Test

* Fix

* Test

* Test

* Test

* Test

* Test

* Increase timeout

* Revert camera test

* pylint

* Fix Windows arguments

* Update webots_ros2_driver/webots_ros2_driver/webots_launcher.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update webots_ros2_driver/webots_ros2_driver/utils.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update webots_ros2_driver/webots_ros2_driver/utils.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update webots_ros2_driver/webots_ros2_driver/utils.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update utils.py

* Update driver_test.wbt

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Increase the version number (#277)

* Fix URDF importer dependencies (#279)

* Update package.xml

* Update package.xml

* Update package.xml

* Update package.xml

* Update package.xml

* Fix uninitialized mWebotsXMLElement (#278)

* fix 273

* Update webots_ros2_driver/src/WebotsNode.cpp

Co-authored-by: Darko Lukić <[email protected]>

Co-authored-by: Your Name <[email protected]>
Co-authored-by: Darko Lukić <[email protected]>

* Fix 280 (#281)

* fix 273

* Update webots_ros2_driver/src/WebotsNode.cpp

Co-authored-by: Darko Lukić <[email protected]>

* let generate webots_ros2_control.lib in windows

Co-authored-by: Your Name <[email protected]>
Co-authored-by: Darko Lukić <[email protected]>

* Print tips: robot_state_publisher started or not (#283)

Print "the `robot_description` parameter is set or not "

* Revert `robot_state_publisher` check (#285)

* Utilize `webots_ros2_driver` in `webots_ros2_mavic` and `webots_ros2_turtlebot` (#269)

* Add turtlebot tests

* Convert Mavic

* Add mavic test

* clean

* Add deps

* Fix node creation

* Increase timeout

* Better

* Fix tests

* Add killall

* Add missing deps

* Wait more in CI

* Fix

* Convert universal robot

* Add rviz

* Fix

* Revert universal robot

* Delete ur changes

* Fix

* Fix to suit to pep257 convention (#290)

* init

* fixed all errors pep257

* CI

* Creation of system test for TurtleBot SLAM tutorial (#292)

* test system turtlebot tutorial SLAM

* Navigation test and put the 2 tests in a single file

* ci_after_init install foxy turtlebot3

* fix after_init

* CI

* CI after_install_target_depend

* fix

* Update test.yml

* Update ci_after_init.bash

* Update ci_after_install_target_dependencies.bash

* CI permission after_depend

* fix

* fix CI

* check packages

* fix ci ci_after_init_bash

* fix pep257

* CI pep257

* flake8 fix

* flake8

* test only SLAM

* test only slam fix

* test only slam fix flake

* Only Slam test CI

* fix exit for CI

* quit instead exit for CI

* fix CI

* Update scripts/ci_after_init.bash

Co-authored-by: Darko Lukić <[email protected]>

* Update webots_ros2_tests/test/test_system_turtlebot_tutorials.py

Co-authored-by: Darko Lukić <[email protected]>

* improved test slam

* fix merge

* Comment after_init

* Update scripts/ci_after_init.bash

Co-authored-by: Darko Lukić <[email protected]>

Co-authored-by: Darko Lukić <[email protected]>

* fix call we_camera_recognition_disable() on NULL recognition node (#294)

* Fix Lidar range (#298)

* Utilize `webots_ros2_driver` in `webots_ros2_epuck` (#296)

* initial commit progress on epuck alone scenario

* 1st draft full conversion

* system tests in dev

* basic epuck driver converted

* system tests draft

* system tests on simple epuck ok

* Apply suggestions from code review

Co-authored-by: Darko Lukić <[email protected]>

* modif review PR

* CI

* fix CI

* fix CI package test has tf2_ros

* remove testFootPrint

* fix CI driver plugin python test

* System tests for scenarios

* System tests scenarios CI foxy

* Change test plan

* more delay plan test

* more delay plan test fix flake

* fix ci rolling

* fix CI rolling nav2bringup

* fix CI rolling nav2bringup pckg required

* removed test rats scenario

* flake8

* removed file test rats scenario

* review changes

* review changes + flake

* revert changes du to Tesla PR

* fix test tools

* adapt topics name

Co-authored-by: Darko Lukić <[email protected]>

* Utilize `webots_ros2_driver` in Universal Robot examples (#286)

* Utilize `webots_ros2_driver` in Universal Robot examples

* Fix ros control

* Delete unnecessary packages

* Convert multiarmed demo

* Add description

* Convert multirobot demo

* Delete unnecessary examples

* Unused

* Begin test

* Revert

* fix

* Test

* Avoid warnings

* Test

* Test

* Test

* Update package.xml

* Update package.xml

* Update package.xml

* Add changelog

* Delete

* Missing deps

* Increase delay

* Fix

* Record

* continue

* Update package.xml

* Update package.xml

* Update webots_launcher.py

* Update test.yml

* Update test.yml

* Fix

* Change

* Longer

* Change

* Update test.yml

* Longer

* Update test_system_universal_robot.py

* Add --input and --xacro-opts arguments to allow calling xacro2proto from a launch file

* Flake8

* Delete unnecessary packages (#301)

* Delete unnecessary packages

* Delete deps

* msgs

* Add new tiago

* wip

* Fix

* fix

* Fix

* Add

* Timeout

* Lighter

* fix

* exit

* revert

* Tesla conversion from Core to Driver (#300)

* temp commit

* temp

* temp commit

* pause to dev Autoware Interface

* temp com

* Webots .so files should be ok but tesla do not see vehicle

* system tests ok

* temp com

* change in libcontroller git

* cv2 and numpy package

* remove numpy package.xml

* correction python3-cv2/numpy

* cv2 in package.xml changed in opencv

* save file

* more time test tesla

* more time test tesla 2

* added rosbag debug ci

* flake8

* package rosbag

* qos LaneFollower

* Apply suggestions from code review

Co-authored-by: Darko Lukić <[email protected]>

* Update review

* temp com

* fix windows build

* commentary python pluggin

* Qos lane follower Windows

* lane follower remove debug msg

* Compatiblity Windows and ROS Rolling

* fix flake8

* Update webots_ros2_driver/include/webots_ros2_driver/PluginInterface.hpp

Co-authored-by: Olivier Michel <[email protected]>

* update driver test function static

* update libcontroller

* fix library

* review corrections

* fix

* update libcontroller

* python warning debug removed

Co-authored-by: Darko Lukić <[email protected]>
Co-authored-by: Olivier Michel <[email protected]>

* Fix universal robot system tests random faillure (#311)

* fix longer

* test order launch

* remove ros bag

* fix clang

* test spin once between init and send goal

* fix

* test

* test follow traj client

* sleep test

* test confirmation need sleep

* Add commentary

* longer

* correction path abb and sleep moved

* add current issue

* longer

* test wait_for_server

* longer timeout

* timeout test bit longer

* remove debug

* Correction for Rolling CI testing failling due to change in ros2control (base_interface) (#315)

* compliance CI folling foxy testing main from TIMPLE ros2control change base interface

* fix compliance

* cast double in int

* new fix cast int

* review github

* update .yaml

* debug and clean conversion duration

* Update test.yml

* fix rolling and galactic testing

* fix merge of rolling testing in main

Co-authored-by: Olivier Michel <[email protected]>

* Prepare release 1.1.2 (#317)

* fix

* Fixed broken LED (#322)

* Fixed broken LED

* Fixed test

* Fixed test

* Use Int32 instead of UInt32 to be closer to the Webots API, fixed test

Co-authored-by: Darko Lukić <[email protected]>
Co-authored-by: Stefan Arndt <[email protected]>
Co-authored-by: Tim Clephas <[email protected]>
Co-authored-by: Olivier Michel <[email protected]>
Co-authored-by: Stefania Pedrazzi <[email protected]>
Co-authored-by: dzyGIT <[email protected]>
Co-authored-by: Your Name <[email protected]>
Co-authored-by: Yanick Douven <[email protected]>

* libcontroller (#326)

Co-authored-by: Tim Clephas <[email protected]>
Co-authored-by: Darko Lukić <[email protected]>
Co-authored-by: Stefan Arndt <[email protected]>
Co-authored-by: Olivier Michel <[email protected]>
Co-authored-by: Stefania Pedrazzi <[email protected]>
Co-authored-by: dzyGIT <[email protected]>
Co-authored-by: Your Name <[email protected]>
Co-authored-by: Yanick Douven <[email protected]>
BenjaminHug8 added a commit that referenced this pull request Nov 5, 2021
@BenjaminHug8 @lukicdarkoo
@omichel @stefaniapedrazzi @dzywater @yanick-douven @Timple
Merge Rolling into master (#331)
8563d2b 
* Fix the IMU library exportation (#262)

* Update CMakeLists.txt

* Update CMakeLists.txt

* Prepare version number for 1.1.1 (#264)

* Prepare

* Increase version number

* Use ros2 node clock for message timestamping (#263)

* Change to ros2 node clock for all devices

* Add Python plugin support to `webots_ros2_driver` (#265)

* Add Python <--> C++ test

* Prepare

* Initial prototype

* Add WebotsNode object

* Add properties

* Import the Python lib

* Improve error handling

* Cleaner

* Add node example

* Integrate the new libController

* Delete the test

* Fix copyright

* Explain

* Copyright fix

* Constructor can be private

* Print Python errors

* Fix Windows usage

* Update webots_ros2_driver/src/PythonPlugin.cpp

Co-authored-by: Olivier Michel <[email protected]>

* Update webots_ros2_driver/src/WebotsNode.cpp

Co-authored-by: Olivier Michel <[email protected]>

* Update webots_ros2_turtlebot/webots_ros2_turtlebot/plugin_example.py

Co-authored-by: Olivier Michel <[email protected]>

* Use const

Co-authored-by: Olivier Michel <[email protected]>

* Fix Rolling warnings and `ament_python_install_package` (#266)

* Fix Rolling warnings and `ament_python_install_package`

* Add to CI

* Add runtime tests (#268)

* Add WebotsLauncher

* Add test package

* Add distance sensor tests

* Add range finder test

* Add plugin test

* Fix spelling

* Add IMU test

* Improve publishing

* Add light sensor test

* Fix colcon test

* Add CI

* Use sudo

* Update

* Update with sudo

* Add missing packages

* Add cache

* Test

* Test

* Test

* Test

* Fix

* Test

* Test

* Test

* Test

* Test

* Increase timeout

* Revert camera test

* pylint

* Fix Windows arguments

* Update webots_ros2_driver/webots_ros2_driver/webots_launcher.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update webots_ros2_driver/webots_ros2_driver/utils.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update webots_ros2_driver/webots_ros2_driver/utils.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update webots_ros2_driver/webots_ros2_driver/utils.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update utils.py

* Update driver_test.wbt

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Merge master into rolling (#324)

* Fix the IMU library exportation (#262)

* Update CMakeLists.txt

* Update CMakeLists.txt

* Prepare version number for 1.1.1 (#264)

* Prepare

* Increase version number

* Use ros2 node clock for message timestamping (#263)

* Change to ros2 node clock for all devices

* Add Python plugin support to `webots_ros2_driver` (#265)

* Add Python <--> C++ test

* Prepare

* Initial prototype

* Add WebotsNode object

* Add properties

* Import the Python lib

* Improve error handling

* Cleaner

* Add node example

* Integrate the new libController

* Delete the test

* Fix copyright

* Explain

* Copyright fix

* Constructor can be private

* Print Python errors

* Fix Windows usage

* Update webots_ros2_driver/src/PythonPlugin.cpp

Co-authored-by: Olivier Michel <[email protected]>

* Update webots_ros2_driver/src/WebotsNode.cpp

Co-authored-by: Olivier Michel <[email protected]>

* Update webots_ros2_turtlebot/webots_ros2_turtlebot/plugin_example.py

Co-authored-by: Olivier Michel <[email protected]>

* Use const

Co-authored-by: Olivier Michel <[email protected]>

* Fix Rolling warnings and `ament_python_install_package` (#266)

* Fix Rolling warnings and `ament_python_install_package`

* Add to CI

* Add runtime tests (#268)

* Add WebotsLauncher

* Add test package

* Add distance sensor tests

* Add range finder test

* Add plugin test

* Fix spelling

* Add IMU test

* Improve publishing

* Add light sensor test

* Fix colcon test

* Add CI

* Use sudo

* Update

* Update with sudo

* Add missing packages

* Add cache

* Test

* Test

* Test

* Test

* Fix

* Test

* Test

* Test

* Test

* Test

* Increase timeout

* Revert camera test

* pylint

* Fix Windows arguments

* Update webots_ros2_driver/webots_ros2_driver/webots_launcher.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update webots_ros2_driver/webots_ros2_driver/utils.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update webots_ros2_driver/webots_ros2_driver/utils.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update webots_ros2_driver/webots_ros2_driver/utils.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update utils.py

* Update driver_test.wbt

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Increase the version number (#277)

* Fix URDF importer dependencies (#279)

* Update package.xml

* Update package.xml

* Update package.xml

* Update package.xml

* Update package.xml

* Fix uninitialized mWebotsXMLElement (#278)

* fix 273

* Update webots_ros2_driver/src/WebotsNode.cpp

Co-authored-by: Darko Lukić <[email protected]>

Co-authored-by: Your Name <[email protected]>
Co-authored-by: Darko Lukić <[email protected]>

* Fix 280 (#281)

* fix 273

* Update webots_ros2_driver/src/WebotsNode.cpp

Co-authored-by: Darko Lukić <[email protected]>

* let generate webots_ros2_control.lib in windows

Co-authored-by: Your Name <[email protected]>
Co-authored-by: Darko Lukić <[email protected]>

* Print tips: robot_state_publisher started or not (#283)

Print "the `robot_description` parameter is set or not "

* Revert `robot_state_publisher` check (#285)

* Utilize `webots_ros2_driver` in `webots_ros2_mavic` and `webots_ros2_turtlebot` (#269)

* Add turtlebot tests

* Convert Mavic

* Add mavic test

* clean

* Add deps

* Fix node creation

* Increase timeout

* Better

* Fix tests

* Add killall

* Add missing deps

* Wait more in CI

* Fix

* Convert universal robot

* Add rviz

* Fix

* Revert universal robot

* Delete ur changes

* Fix

* Fix to suit to pep257 convention (#290)

* init

* fixed all errors pep257

* CI

* Creation of system test for TurtleBot SLAM tutorial (#292)

* test system turtlebot tutorial SLAM

* Navigation test and put the 2 tests in a single file

* ci_after_init install foxy turtlebot3

* fix after_init

* CI

* CI after_install_target_depend

* fix

* Update test.yml

* Update ci_after_init.bash

* Update ci_after_install_target_dependencies.bash

* CI permission after_depend

* fix

* fix CI

* check packages

* fix ci ci_after_init_bash

* fix pep257

* CI pep257

* flake8 fix

* flake8

* test only SLAM

* test only slam fix

* test only slam fix flake

* Only Slam test CI

* fix exit for CI

* quit instead exit for CI

* fix CI

* Update scripts/ci_after_init.bash

Co-authored-by: Darko Lukić <[email protected]>

* Update webots_ros2_tests/test/test_system_turtlebot_tutorials.py

Co-authored-by: Darko Lukić <[email protected]>

* improved test slam

* fix merge

* Comment after_init

* Update scripts/ci_after_init.bash

Co-authored-by: Darko Lukić <[email protected]>

Co-authored-by: Darko Lukić <[email protected]>

* fix call we_camera_recognition_disable() on NULL recognition node (#294)

* Fix Lidar range (#298)

* Utilize `webots_ros2_driver` in `webots_ros2_epuck` (#296)

* initial commit progress on epuck alone scenario

* 1st draft full conversion

* system tests in dev

* basic epuck driver converted

* system tests draft

* system tests on simple epuck ok

* Apply suggestions from code review

Co-authored-by: Darko Lukić <[email protected]>

* modif review PR

* CI

* fix CI

* fix CI package test has tf2_ros

* remove testFootPrint

* fix CI driver plugin python test

* System tests for scenarios

* System tests scenarios CI foxy

* Change test plan

* more delay plan test

* more delay plan test fix flake

* fix ci rolling

* fix CI rolling nav2bringup

* fix CI rolling nav2bringup pckg required

* removed test rats scenario

* flake8

* removed file test rats scenario

* review changes

* review changes + flake

* revert changes du to Tesla PR

* fix test tools

* adapt topics name

Co-authored-by: Darko Lukić <[email protected]>

* Utilize `webots_ros2_driver` in Universal Robot examples (#286)

* Utilize `webots_ros2_driver` in Universal Robot examples

* Fix ros control

* Delete unnecessary packages

* Convert multiarmed demo

* Add description

* Convert multirobot demo

* Delete unnecessary examples

* Unused

* Begin test

* Revert

* fix

* Test

* Avoid warnings

* Test

* Test

* Test

* Update package.xml

* Update package.xml

* Update package.xml

* Add changelog

* Delete

* Missing deps

* Increase delay

* Fix

* Record

* continue

* Update package.xml

* Update package.xml

* Update webots_launcher.py

* Update test.yml

* Update test.yml

* Fix

* Change

* Longer

* Change

* Update test.yml

* Longer

* Update test_system_universal_robot.py

* Add --input and --xacro-opts arguments to allow calling xacro2proto from a launch file

* Flake8

* Delete unnecessary packages (#301)

* Delete unnecessary packages

* Delete deps

* msgs

* Add new tiago

* wip

* Fix

* fix

* Fix

* Add

* Timeout

* Lighter

* fix

* exit

* revert

* Tesla conversion from Core to Driver (#300)

* temp commit

* temp

* temp commit

* pause to dev Autoware Interface

* temp com

* Webots .so files should be ok but tesla do not see vehicle

* system tests ok

* temp com

* change in libcontroller git

* cv2 and numpy package

* remove numpy package.xml

* correction python3-cv2/numpy

* cv2 in package.xml changed in opencv

* save file

* more time test tesla

* more time test tesla 2

* added rosbag debug ci

* flake8

* package rosbag

* qos LaneFollower

* Apply suggestions from code review

Co-authored-by: Darko Lukić <[email protected]>

* Update review

* temp com

* fix windows build

* commentary python pluggin

* Qos lane follower Windows

* lane follower remove debug msg

* Compatiblity Windows and ROS Rolling

* fix flake8

* Update webots_ros2_driver/include/webots_ros2_driver/PluginInterface.hpp

Co-authored-by: Olivier Michel <[email protected]>

* update driver test function static

* update libcontroller

* fix library

* review corrections

* fix

* update libcontroller

* python warning debug removed

Co-authored-by: Darko Lukić <[email protected]>
Co-authored-by: Olivier Michel <[email protected]>

* Fix universal robot system tests random faillure (#311)

* fix longer

* test order launch

* remove ros bag

* fix clang

* test spin once between init and send goal

* fix

* test

* test follow traj client

* sleep test

* test confirmation need sleep

* Add commentary

* longer

* correction path abb and sleep moved

* add current issue

* longer

* test wait_for_server

* longer timeout

* timeout test bit longer

* remove debug

* Correction for Rolling CI testing failling due to change in ros2control (base_interface) (#315)

* compliance CI folling foxy testing main from TIMPLE ros2control change base interface

* fix compliance

* cast double in int

* new fix cast int

* review github

* update .yaml

* debug and clean conversion duration

* Update test.yml

* fix rolling and galactic testing

* fix merge of rolling testing in main

Co-authored-by: Olivier Michel <[email protected]>

* Prepare release 1.1.2 (#317)

* fix

* Fixed broken LED (#322)

* Fixed broken LED

* Fixed test

* Fixed test

* Use Int32 instead of UInt32 to be closer to the Webots API, fixed test

Co-authored-by: Darko Lukić <[email protected]>
Co-authored-by: Stefan Arndt <[email protected]>
Co-authored-by: Olivier Michel <[email protected]>
Co-authored-by: Stefania Pedrazzi <[email protected]>
Co-authored-by: dzyGIT <[email protected]>
Co-authored-by: Your Name <[email protected]>
Co-authored-by: Yanick Douven <[email protected]>
Co-authored-by: Tim Clephas <[email protected]>

* merge fix (#327)

Co-authored-by: Darko Lukić <[email protected]>
Co-authored-by: Stefan Arndt <[email protected]>
Co-authored-by: Olivier Michel <[email protected]>
Co-authored-by: Stefania Pedrazzi <[email protected]>
Co-authored-by: dzyGIT <[email protected]>
Co-authored-by: Your Name <[email protected]>
Co-authored-by: Yanick Douven <[email protected]>
Co-authored-by: Tim Clephas <[email protected]>
BenjaminHug8 added a commit that referenced this pull request Nov 9, 2021
@BenjaminHug8 @Timple
@lukicdarkoo @omichel @stefaniapedrazzi @dzywater @yanick-douven
Merge master into foxy (#336)
25df2b9 
* Added new --no-rendering option to webots launcher (#253)

* Fix library directory

* Don't use a subdirectory

* Fix warnings (#255)

* Fix warnings

* Simpler fix

* Fix Windows build (#258)

* Fix Windows build

* ID is not a member anymore

* Export C++ libController

* Fix libController

* Update module

* Fix controller spawner

* Update robot_launch.py

* Update README.md (#259)

* Fix the IMU library exportation (#262)

* Update CMakeLists.txt

* Update CMakeLists.txt

* Prepare version number for 1.1.1 (#264)

* Prepare

* Increase version number

* Use ros2 node clock for message timestamping (#263)

* Change to ros2 node clock for all devices

* Add Python plugin support to `webots_ros2_driver` (#265)

* Add Python <--> C++ test

* Prepare

* Initial prototype

* Add WebotsNode object

* Add properties

* Import the Python lib

* Improve error handling

* Cleaner

* Add node example

* Integrate the new libController

* Delete the test

* Fix copyright

* Explain

* Copyright fix

* Constructor can be private

* Print Python errors

* Fix Windows usage

* Update webots_ros2_driver/src/PythonPlugin.cpp

Co-authored-by: Olivier Michel <[email protected]>

* Update webots_ros2_driver/src/WebotsNode.cpp

Co-authored-by: Olivier Michel <[email protected]>

* Update webots_ros2_turtlebot/webots_ros2_turtlebot/plugin_example.py

Co-authored-by: Olivier Michel <[email protected]>

* Use const

Co-authored-by: Olivier Michel <[email protected]>

* Fix Rolling warnings and `ament_python_install_package` (#266)

* Fix Rolling warnings and `ament_python_install_package`

* Add to CI

* Add runtime tests (#268)

* Add WebotsLauncher

* Add test package

* Add distance sensor tests

* Add range finder test

* Add plugin test

* Fix spelling

* Add IMU test

* Improve publishing

* Add light sensor test

* Fix colcon test

* Add CI

* Use sudo

* Update

* Update with sudo

* Add missing packages

* Add cache

* Test

* Test

* Test

* Test

* Fix

* Test

* Test

* Test

* Test

* Test

* Increase timeout

* Revert camera test

* pylint

* Fix Windows arguments

* Update webots_ros2_driver/webots_ros2_driver/webots_launcher.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update webots_ros2_driver/webots_ros2_driver/utils.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update webots_ros2_driver/webots_ros2_driver/utils.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update webots_ros2_driver/webots_ros2_driver/utils.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update utils.py

* Update driver_test.wbt

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Increase the version number (#277)

* Fix URDF importer dependencies (#279)

* Update package.xml

* Update package.xml

* Update package.xml

* Update package.xml

* Update package.xml

* Fix uninitialized mWebotsXMLElement (#278)

* fix 273

* Update webots_ros2_driver/src/WebotsNode.cpp

Co-authored-by: Darko Lukić <[email protected]>

Co-authored-by: Your Name <[email protected]>
Co-authored-by: Darko Lukić <[email protected]>

* Fix 280 (#281)

* fix 273

* Update webots_ros2_driver/src/WebotsNode.cpp

Co-authored-by: Darko Lukić <[email protected]>

* let generate webots_ros2_control.lib in windows

Co-authored-by: Your Name <[email protected]>
Co-authored-by: Darko Lukić <[email protected]>

* Print tips: robot_state_publisher started or not (#283)

Print "the `robot_description` parameter is set or not "

* Revert `robot_state_publisher` check (#285)

* Utilize `webots_ros2_driver` in `webots_ros2_mavic` and `webots_ros2_turtlebot` (#269)

* Add turtlebot tests

* Convert Mavic

* Add mavic test

* clean

* Add deps

* Fix node creation

* Increase timeout

* Better

* Fix tests

* Add killall

* Add missing deps

* Wait more in CI

* Fix

* Convert universal robot

* Add rviz

* Fix

* Revert universal robot

* Delete ur changes

* Fix

* Fix to suit to pep257 convention (#290)

* init

* fixed all errors pep257

* CI

* Creation of system test for TurtleBot SLAM tutorial (#292)

* test system turtlebot tutorial SLAM

* Navigation test and put the 2 tests in a single file

* ci_after_init install foxy turtlebot3

* fix after_init

* CI

* CI after_install_target_depend

* fix

* Update test.yml

* Update ci_after_init.bash

* Update ci_after_install_target_dependencies.bash

* CI permission after_depend

* fix

* fix CI

* check packages

* fix ci ci_after_init_bash

* fix pep257

* CI pep257

* flake8 fix

* flake8

* test only SLAM

* test only slam fix

* test only slam fix flake

* Only Slam test CI

* fix exit for CI

* quit instead exit for CI

* fix CI

* Update scripts/ci_after_init.bash

Co-authored-by: Darko Lukić <[email protected]>

* Update webots_ros2_tests/test/test_system_turtlebot_tutorials.py

Co-authored-by: Darko Lukić <[email protected]>

* improved test slam

* fix merge

* Comment after_init

* Update scripts/ci_after_init.bash

Co-authored-by: Darko Lukić <[email protected]>

Co-authored-by: Darko Lukić <[email protected]>

* fix call we_camera_recognition_disable() on NULL recognition node (#294)

* Fix Lidar range (#298)

* Utilize `webots_ros2_driver` in `webots_ros2_epuck` (#296)

* initial commit progress on epuck alone scenario

* 1st draft full conversion

* system tests in dev

* basic epuck driver converted

* system tests draft

* system tests on simple epuck ok

* Apply suggestions from code review

Co-authored-by: Darko Lukić <[email protected]>

* modif review PR

* CI

* fix CI

* fix CI package test has tf2_ros

* remove testFootPrint

* fix CI driver plugin python test

* System tests for scenarios

* System tests scenarios CI foxy

* Change test plan

* more delay plan test

* more delay plan test fix flake

* fix ci rolling

* fix CI rolling nav2bringup

* fix CI rolling nav2bringup pckg required

* removed test rats scenario

* flake8

* removed file test rats scenario

* review changes

* review changes + flake

* revert changes du to Tesla PR

* fix test tools

* adapt topics name

Co-authored-by: Darko Lukić <[email protected]>

* Utilize `webots_ros2_driver` in Universal Robot examples (#286)

* Utilize `webots_ros2_driver` in Universal Robot examples

* Fix ros control

* Delete unnecessary packages

* Convert multiarmed demo

* Add description

* Convert multirobot demo

* Delete unnecessary examples

* Unused

* Begin test

* Revert

* fix

* Test

* Avoid warnings

* Test

* Test

* Test

* Update package.xml

* Update package.xml

* Update package.xml

* Add changelog

* Delete

* Missing deps

* Increase delay

* Fix

* Record

* continue

* Update package.xml

* Update package.xml

* Update webots_launcher.py

* Update test.yml

* Update test.yml

* Fix

* Change

* Longer

* Change

* Update test.yml

* Longer

* Update test_system_universal_robot.py

* Add --input and --xacro-opts arguments to allow calling xacro2proto from a launch file

* Flake8

* Delete unnecessary packages (#301)

* Delete unnecessary packages

* Delete deps

* msgs

* Add new tiago

* wip

* Fix

* fix

* Fix

* Add

* Timeout

* Lighter

* fix

* exit

* revert

* Tesla conversion from Core to Driver (#300)

* temp commit

* temp

* temp commit

* pause to dev Autoware Interface

* temp com

* Webots .so files should be ok but tesla do not see vehicle

* system tests ok

* temp com

* change in libcontroller git

* cv2 and numpy package

* remove numpy package.xml

* correction python3-cv2/numpy

* cv2 in package.xml changed in opencv

* save file

* more time test tesla

* more time test tesla 2

* added rosbag debug ci

* flake8

* package rosbag

* qos LaneFollower

* Apply suggestions from code review

Co-authored-by: Darko Lukić <[email protected]>

* Update review

* temp com

* fix windows build

* commentary python pluggin

* Qos lane follower Windows

* lane follower remove debug msg

* Compatiblity Windows and ROS Rolling

* fix flake8

* Update webots_ros2_driver/include/webots_ros2_driver/PluginInterface.hpp

Co-authored-by: Olivier Michel <[email protected]>

* update driver test function static

* update libcontroller

* fix library

* review corrections

* fix

* update libcontroller

* python warning debug removed

Co-authored-by: Darko Lukić <[email protected]>
Co-authored-by: Olivier Michel <[email protected]>

* Fix universal robot system tests random faillure (#311)

* fix longer

* test order launch

* remove ros bag

* fix clang

* test spin once between init and send goal

* fix

* test

* test follow traj client

* sleep test

* test confirmation need sleep

* Add commentary

* longer

* correction path abb and sleep moved

* add current issue

* longer

* test wait_for_server

* longer timeout

* timeout test bit longer

* remove debug

* Correction for Rolling CI testing failling due to change in ros2control (base_interface) (#315)

* compliance CI folling foxy testing main from TIMPLE ros2control change base interface

* fix compliance

* cast double in int

* new fix cast int

* review github

* update .yaml

* debug and clean conversion duration

* Update test.yml

* fix rolling and galactic testing

* fix merge of rolling testing in main

Co-authored-by: Olivier Michel <[email protected]>

* Prepare release 1.1.2 (#317)

* Fixed broken LED (#322)

* Fixed broken LED

* Fixed test

* Fixed test

* Use Int32 instead of UInt32 to be closer to the Webots API, fixed test

* add ros_environnement (#328)

* Merge Foxy into Master (#330)

* Added new --no-rendering option to webots launcher (#253)

* Fix library directory

* Don't use a subdirectory

* Fix warnings (#255)

* Fix warnings

* Simpler fix

* Fix Windows build (#258)

* Fix Windows build

* ID is not a member anymore

* Export C++ libController

* Fix libController

* Update module

* Fix controller spawner

* Update robot_launch.py

* Update README.md (#259)

* Fix the IMU library exportation (#262)

* Update CMakeLists.txt

* Update CMakeLists.txt

* Prepare version number for 1.1.1 (#264)

* Prepare

* Increase version number

* Use ros2 node clock for message timestamping (#263)

* Change to ros2 node clock for all devices

* Add Python plugin support to `webots_ros2_driver` (#265)

* Add Python <--> C++ test

* Prepare

* Initial prototype

* Add WebotsNode object

* Add properties

* Import the Python lib

* Improve error handling

* Cleaner

* Add node example

* Integrate the new libController

* Delete the test

* Fix copyright

* Explain

* Copyright fix

* Constructor can be private

* Print Python errors

* Fix Windows usage

* Update webots_ros2_driver/src/PythonPlugin.cpp

Co-authored-by: Olivier Michel <[email protected]>

* Update webots_ros2_driver/src/WebotsNode.cpp

Co-authored-by: Olivier Michel <[email protected]>

* Update webots_ros2_turtlebot/webots_ros2_turtlebot/plugin_example.py

Co-authored-by: Olivier Michel <[email protected]>

* Use const

Co-authored-by: Olivier Michel <[email protected]>

* Fix Rolling warnings and `ament_python_install_package` (#266)

* Fix Rolling warnings and `ament_python_install_package`

* Add to CI

* Add runtime tests (#268)

* Add WebotsLauncher

* Add test package

* Add distance sensor tests

* Add range finder test

* Add plugin test

* Fix spelling

* Add IMU test

* Improve publishing

* Add light sensor test

* Fix colcon test

* Add CI

* Use sudo

* Update

* Update with sudo

* Add missing packages

* Add cache

* Test

* Test

* Test

* Test

* Fix

* Test

* Test

* Test

* Test

* Test

* Increase timeout

* Revert camera test

* pylint

* Fix Windows arguments

* Update webots_ros2_driver/webots_ros2_driver/webots_launcher.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update webots_ros2_driver/webots_ros2_driver/utils.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update webots_ros2_driver/webots_ros2_driver/utils.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update webots_ros2_driver/webots_ros2_driver/utils.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update utils.py

* Update driver_test.wbt

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Merge master into foxy (#321)

* Added new --no-rendering option to webots launcher (#253)

* Fix library directory

* Don't use a subdirectory

* Fix warnings (#255)

* Fix warnings

* Simpler fix

* Fix Windows build (#258)

* Fix Windows build

* ID is not a member anymore

* Export C++ libController

* Fix libController

* Update module

* Fix controller spawner

* Update robot_launch.py

* Update README.md (#259)

* Fix the IMU library exportation (#262)

* Update CMakeLists.txt

* Update CMakeLists.txt

* Prepare version number for 1.1.1 (#264)

* Prepare

* Increase version number

* Use ros2 node clock for message timestamping (#263)

* Change to ros2 node clock for all devices

* Add Python plugin support to `webots_ros2_driver` (#265)

* Add Python <--> C++ test

* Prepare

* Initial prototype

* Add WebotsNode object

* Add properties

* Import the Python lib

* Improve error handling

* Cleaner

* Add node example

* Integrate the new libController

* Delete the test

* Fix copyright

* Explain

* Copyright fix

* Constructor can be private

* Print Python errors

* Fix Windows usage

* Update webots_ros2_driver/src/PythonPlugin.cpp

Co-authored-by: Olivier Michel <[email protected]>

* Update webots_ros2_driver/src/WebotsNode.cpp

Co-authored-by: Olivier Michel <[email protected]>

* Update webots_ros2_turtlebot/webots_ros2_turtlebot/plugin_example.py

Co-authored-by: Olivier Michel <[email protected]>

* Use const

Co-authored-by: Olivier Michel <[email protected]>

* Fix Rolling warnings and `ament_python_install_package` (#266)

* Fix Rolling warnings and `ament_python_install_package`

* Add to CI

* Add runtime tests (#268)

* Add WebotsLauncher

* Add test package

* Add distance sensor tests

* Add range finder test

* Add plugin test

* Fix spelling

* Add IMU test

* Improve publishing

* Add light sensor test

* Fix colcon test

* Add CI

* Use sudo

* Update

* Update with sudo

* Add missing packages

* Add cache

* Test

* Test

* Test

* Test

* Fix

* Test

* Test

* Test

* Test

* Test

* Increase timeout

* Revert camera test

* pylint

* Fix Windows arguments

* Update webots_ros2_driver/webots_ros2_driver/webots_launcher.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update webots_ros2_driver/webots_ros2_driver/utils.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update webots_ros2_driver/webots_ros2_driver/utils.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update webots_ros2_driver/webots_ros2_driver/utils.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update utils.py

* Update driver_test.wbt

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Increase the version number (#277)

* Fix URDF importer dependencies (#279)

* Update package.xml

* Update package.xml

* Update package.xml

* Update package.xml

* Update package.xml

* Fix uninitialized mWebotsXMLElement (#278)

* fix 273

* Update webots_ros2_driver/src/WebotsNode.cpp

Co-authored-by: Darko Lukić <[email protected]>

Co-authored-by: Your Name <[email protected]>
Co-authored-by: Darko Lukić <[email protected]>

* Fix 280 (#281)

* fix 273

* Update webots_ros2_driver/src/WebotsNode.cpp

Co-authored-by: Darko Lukić <[email protected]>

* let generate webots_ros2_control.lib in windows

Co-authored-by: Your Name <[email protected]>
Co-authored-by: Darko Lukić <[email protected]>

* Print tips: robot_state_publisher started or not (#283)

Print "the `robot_description` parameter is set or not "

* Revert `robot_state_publisher` check (#285)

* Utilize `webots_ros2_driver` in `webots_ros2_mavic` and `webots_ros2_turtlebot` (#269)

* Add turtlebot tests

* Convert Mavic

* Add mavic test

* clean

* Add deps

* Fix node creation

* Increase timeout

* Better

* Fix tests

* Add killall

* Add missing deps

* Wait more in CI

* Fix

* Convert universal robot

* Add rviz

* Fix

* Revert universal robot

* Delete ur changes

* Fix

* Fix to suit to pep257 convention (#290)

* init

* fixed all errors pep257

* CI

* Creation of system test for TurtleBot SLAM tutorial (#292)

* test system turtlebot tutorial SLAM

* Navigation test and put the 2 tests in a single file

* ci_after_init install foxy turtlebot3

* fix after_init

* CI

* CI after_install_target_depend

* fix

* Update test.yml

* Update ci_after_init.bash

* Update ci_after_install_target_dependencies.bash

* CI permission after_depend

* fix

* fix CI

* check packages

* fix ci ci_after_init_bash

* fix pep257

* CI pep257

* flake8 fix

* flake8

* test only SLAM

* test only slam fix

* test only slam fix flake

* Only Slam test CI

* fix exit for CI

* quit instead exit for CI

* fix CI

* Update scripts/ci_after_init.bash

Co-authored-by: Darko Lukić <[email protected]>

* Update webots_ros2_tests/test/test_system_turtlebot_tutorials.py

Co-authored-by: Darko Lukić <[email protected]>

* improved test slam

* fix merge

* Comment after_init

* Update scripts/ci_after_init.bash

Co-authored-by: Darko Lukić <[email protected]>

Co-authored-by: Darko Lukić <[email protected]>

* fix call we_camera_recognition_disable() on NULL recognition node (#294)

* Fix Lidar range (#298)

* Utilize `webots_ros2_driver` in `webots_ros2_epuck` (#296)

* initial commit progress on epuck alone scenario

* 1st draft full conversion

* system tests in dev

* basic epuck driver converted

* system tests draft

* system tests on simple epuck ok

* Apply suggestions from code review

Co-authored-by: Darko Lukić <[email protected]>

* modif review PR

* CI

* fix CI

* fix CI package test has tf2_ros

* remove testFootPrint

* fix CI driver plugin python test

* System tests for scenarios

* System tests scenarios CI foxy

* Change test plan

* more delay plan test

* more delay plan test fix flake

* fix ci rolling

* fix CI rolling nav2bringup

* fix CI rolling nav2bringup pckg required

* removed test rats scenario

* flake8

* removed file test rats scenario

* review changes

* review changes + flake

* revert changes du to Tesla PR

* fix test tools

* adapt topics name

Co-authored-by: Darko Lukić <[email protected]>

* Utilize `webots_ros2_driver` in Universal Robot examples (#286)

* Utilize `webots_ros2_driver` in Universal Robot examples

* Fix ros control

* Delete unnecessary packages

* Convert multiarmed demo

* Add description

* Convert multirobot demo

* Delete unnecessary examples

* Unused

* Begin test

* Revert

* fix

* Test

* Avoid warnings

* Test

* Test

* Test

* Update package.xml

* Update package.xml

* Update package.xml

* Add changelog

* Delete

* Missing deps

* Increase delay

* Fix

* Record

* continue

* Update package.xml

* Update package.xml

* Update webots_launcher.py

* Update test.yml

* Update test.yml

* Fix

* Change

* Longer

* Change

* Update test.yml

* Longer

* Update test_system_universal_robot.py

* Add --input and --xacro-opts arguments to allow calling xacro2proto from a launch file

* Flake8

* Delete unnecessary packages (#301)

* Delete unnecessary packages

* Delete deps

* msgs

* Add new tiago

* wip

* Fix

* fix

* Fix

* Add

* Timeout

* Lighter

* fix

* exit

* revert

* Tesla conversion from Core to Driver (#300)

* temp commit

* temp

* temp commit

* pause to dev Autoware Interface

* temp com

* Webots .so files should be ok but tesla do not see vehicle

* system tests ok

* temp com

* change in libcontroller git

* cv2 and numpy package

* remove numpy package.xml

* correction python3-cv2/numpy

* cv2 in package.xml changed in opencv

* save file

* more time test tesla

* more time test tesla 2

* added rosbag debug ci

* flake8

* package rosbag

* qos LaneFollower

* Apply suggestions from code review

Co-authored-by: Darko Lukić <[email protected]>

* Update review

* temp com

* fix windows build

* commentary python pluggin

* Qos lane follower Windows

* lane follower remove debug msg

* Compatiblity Windows and ROS Rolling

* fix flake8

* Update webots_ros2_driver/include/webots_ros2_driver/PluginInterface.hpp

Co-authored-by: Olivier Michel <[email protected]>

* update driver test function static

* update libcontroller

* fix library

* review corrections

* fix

* update libcontroller

* python warning debug removed

Co-authored-by: Darko Lukić <[email protected]>
Co-authored-by: Olivier Michel <[email protected]>

* Fix universal robot system tests random faillure (#311)

* fix longer

* test order launch

* remove ros bag

* fix clang

* test spin once between init and send goal

* fix

* test

* test follow traj client

* sleep test

* test confirmation need sleep

* Add commentary

* longer

* correction path abb and sleep moved

* add current issue

* longer

* test wait_for_server

* longer timeout

* timeout test bit longer

* remove debug

* Correction for Rolling CI testing failling due to change in ros2control (base_interface) (#315)

* compliance CI folling foxy testing main from TIMPLE ros2control change base interface

* fix compliance

* cast double in int

* new fix cast int

* review github

* update .yaml

* debug and clean conversion duration

* Update test.yml

* fix rolling and galactic testing

* fix merge of rolling testing in main

Co-authored-by: Olivier Michel <[email protected]>

* Prepare release 1.1.2 (#317)

* fix

* Fixed broken LED (#322)

* Fixed broken LED

* Fixed test

* Fixed test

* Use Int32 instead of UInt32 to be closer to the Webots API, fixed test

Co-authored-by: Stefan Arndt <[email protected]>
Co-authored-by: Tim Clephas <[email protected]>
Co-authored-by: Darko Lukić <[email protected]>
Co-authored-by: Olivier Michel <[email protected]>
Co-authored-by: Stefania Pedrazzi <[email protected]>
Co-authored-by: dzyGIT <[email protected]>
Co-authored-by: Your Name <[email protected]>
Co-authored-by: Yanick Douven <[email protected]>

* Merge master into foxy fix (#325)

* fix merge

* libcontroller

* Merge master into Foxy (#329)

* Added new --no-rendering option to webots launcher (#253)

* Fix library directory

* Don't use a subdirectory

* Fix warnings (#255)

* Fix warnings

* Simpler fix

* Fix Windows build (#258)

* Fix Windows build

* ID is not a member anymore

* Export C++ libController

* Fix libController

* Update module

* Fix controller spawner

* Update robot_launch.py

* Update README.md (#259)

* Fix the IMU library exportation (#262)

* Update CMakeLists.txt

* Update CMakeLists.txt

* Prepare version number for 1.1.1 (#264)

* Prepare

* Increase version number

* Use ros2 node clock for message timestamping (#263)

* Change to ros2 node clock for all devices

* Add Python plugin support to `webots_ros2_driver` (#265)

* Add Python <--> C++ test

* Prepare

* Initial prototype

* Add WebotsNode object

* Add properties

* Import the Python lib

* Improve error handling

* Cleaner

* Add node example

* Integrate the new libController

* Delete the test

* Fix copyright

* Explain

* Copyright fix

* Constructor can be private

* Print Python errors

* Fix Windows usage

* Update webots_ros2_driver/src/PythonPlugin.cpp

Co-authored-by: Olivier Michel <[email protected]>

* Update webots_ros2_driver/src/WebotsNode.cpp

Co-authored-by: Olivier Michel <[email protected]>

* Update webots_ros2_turtlebot/webots_ros2_turtlebot/plugin_example.py

Co-authored-by: Olivier Michel <[email protected]>

* Use const

Co-authored-by: Olivier Michel <[email protected]>

* Fix Rolling warnings and `ament_python_install_package` (#266)

* Fix Rolling warnings and `ament_python_install_package`

* Add to CI

* Add runtime tests (#268)

* Add WebotsLauncher

* Add test package

* Add distance sensor tests

* Add range finder test

* Add plugin test

* Fix spelling

* Add IMU test

* Improve publishing

* Add light sensor test

* Fix colcon test

* Add CI

* Use sudo

* Update

* Update with sudo

* Add missing packages

* Add cache

* Test

* Test

* Test

* Test

* Fix

* Test

* Test

* Test

* Test

* Test

* Increase timeout

* Revert camera test

* pylint

* Fix Windows arguments

* Update webots_ros2_driver/webots_ros2_driver/webots_launcher.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update webots_ros2_driver/webots_ros2_driver/utils.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update webots_ros2_driver/webots_ros2_driver/utils.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update webots_ros2_driver/webots_ros2_driver/utils.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update utils.py

* Update driver_test.wbt

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Increase the version number (#277)

* Fix URDF importer dependencies (#279)

* Update package.xml

* Update package.xml

* Update package.xml

* Update package.xml

* Update package.xml

* Fix uninitialized mWebotsXMLElement (#278)

* fix 273

* Update webots_ros2_driver/src/WebotsNode.cpp

Co-authored-by: Darko Lukić <[email protected]>

Co-authored-by: Your Name <[email protected]>
Co-authored-by: Darko Lukić <[email protected]>

* Fix 280 (#281)

* fix 273

* Update webots_ros2_driver/src/WebotsNode.cpp

Co-authored-by: Darko Lukić <[email protected]>

* let generate webots_ros2_control.lib in windows

Co-authored-by: Your Name <[email protected]>
Co-authored-by: Darko Lukić <[email protected]>

* Print tips: robot_state_publisher started or not (#283)

Print "the `robot_description` parameter is set or not "

* Revert `robot_state_publisher` check (#285)

* Utilize `webots_ros2_driver` in `webots_ros2_mavic` and `webots_ros2_turtlebot` (#269)

* Add turtlebot tests

* Convert Mavic

* Add mavic test

* clean

* Add deps

* Fix node creation

* Increase timeout

* Better

* Fix tests

* Add killall

* Add missing deps

* Wait more in CI

* Fix

* Convert universal robot

* Add rviz

* Fix

* Revert universal robot

* Delete ur changes

* Fix

* Fix to suit to pep257 convention (#290)

* init

* fixed all errors pep257

* CI

* Creation of system test for TurtleBot SLAM tutorial (#292)

* test system turtlebot tutorial SLAM

* Navigation test and put the 2 tests in a single file

* ci_after_init install foxy turtlebot3

* fix after_init

* CI

* CI after_install_target_depend

* fix

* Update test.yml

* Update ci_after_init.bash

* Update ci_after_install_target_dependencies.bash

* CI permission after_depend

* fix

* fix CI

* check packages

* fix ci ci_after_init_bash

* fix pep257

* CI pep257

* flake8 fix

* flake8

* test only SLAM

* test only slam fix

* test only slam fix flake

* Only Slam test CI

* fix exit for CI

* quit instead exit for CI

* fix CI

* Update scripts/ci_after_init.bash

Co-authored-by: Darko Lukić <[email protected]>

* Update webots_ros2_tests/test/test_system_turtlebot_tutorials.py

Co-authored-by: Darko Lukić <[email protected]>

* improved test slam

* fix merge

* Comment after_init

* Update scripts/ci_after_init.bash

Co-authored-by: Darko Lukić <[email protected]>

Co-authored-by: Darko Lukić <[email protected]>

* fix call we_camera_recognition_disable() on NULL recognition node (#294)

* Fix Lidar range (#298)

* Utilize `webots_ros2_driver` in `webots_ros2_epuck` (#296)

* initial commit progress on epuck alone scenario

* 1st draft full conversion

* system tests in dev

* basic epuck driver converted

* system tests draft

* system tests on simple epuck ok

* Apply suggestions from code review

Co-authored-by: Darko Lukić <[email protected]>

* modif review PR

* CI

* fix CI

* fix CI package test has tf2_ros

* remove testFootPrint

* fix CI driver plugin python test

* System tests for scenarios

* System tests scenarios CI foxy

* Change test plan

* more delay plan test

* more delay plan test fix flake

* fix ci rolling

* fix CI rolling nav2bringup

* fix CI rolling nav2bringup pckg required

* removed test rats scenario

* flake8

* removed file test rats scenario

* review changes

* review changes + flake

* revert changes du to Tesla PR

* fix test tools

* adapt topics name

Co-authored-by: Darko Lukić <[email protected]>

* Utilize `webots_ros2_driver` in Universal Robot examples (#286)

* Utilize `webots_ros2_driver` in Universal Robot examples

* Fix ros control

* Delete unnecessary packages

* Convert multiarmed demo

* Add description

* Convert multirobot demo

* Delete unnecessary examples

* Unused

* Begin test

* Revert

* fix

* Test

* Avoid warnings

* Test

* Test

* Test

* Update package.xml

* Update package.xml

* Update package.xml

* Add changelog

* Delete

* Missing deps

* Increase delay

* Fix

* Record

* continue

* Update package.xml

* Update package.xml

* Update webots_launcher.py

* Update test.yml

* Update test.yml

* Fix

* Change

* Longer

* Change

* Update test.yml

* Longer

* Update test_system_universal_robot.py

* Add --input and --xacro-opts arguments to allow calling xacro2proto from a launch file

* Flake8

* Delete unnecessary packages (#301)

* Delete unnecessary packages

* Delete deps

* msgs

* Add new tiago

* wip

* Fix

* fix

* Fix

* Add

* Timeout

* Lighter

* fix

* exit

* revert

* Tesla conversion from Core to Driver (#300)

* temp commit

* temp

* temp commit

* pause to dev Autoware Interface

* temp com

* Webots .so files should be ok but tesla do not see vehicle

* system tests ok

* temp com

* change in libcontroller git

* cv2 and numpy package

* remove numpy package.xml

* correction python3-cv2/numpy

* cv2 in package.xml changed in opencv

* save file

* more time test tesla

* more time test tesla 2

* added rosbag debug ci

* flake8

* package rosbag

* qos LaneFollower

* Apply suggestions from code review

Co-authored-by: Darko Lukić <[email protected]>

* Update review

* temp com

* fix windows build

* commentary python pluggin

* Qos lane follower Windows

* lane follower remove debug msg

* Compatiblity Windows and ROS Rolling

* fix flake8

* Update webots_ros2_driver/include/webots_ros2_driver/PluginInterface.hpp

Co-authored-by: Olivier Michel <[email protected]>

* update driver test function static

* update libcontroller

* fix library

* review corrections

* fix

* update libcontroller

* python warning debug removed

Co-authored-by: Darko Lukić <[email protected]>
Co-authored-by: Olivier Michel <[email protected]>

* Fix universal robot system tests random faillure (#311)

* fix longer

* test order launch

* remove ros bag

* fix clang

* test spin once between init and send goal

* fix

* test

* test follow traj client

* sleep test

* test confirmation need sleep

* Add commentary

* longer

* correction path abb and sleep moved

* add current issue

* longer

* test wait_for_server

* longer timeout

* timeout test bit longer

* remove debug

* Correction for Rolling CI testing failling due to change in ros2control (base_interface) (#315)

* compliance CI folling foxy testing main from TIMPLE ros2control change base interface

* fix compliance

* cast double in int

* new fix cast int

* review github

* update .yaml

* debug and clean conversion duration

* Update test.yml

* fix rolling and galactic testing

* fix merge of rolling testing in main

Co-authored-by: Olivier Michel <[email protected]>

* Prepare release 1.1.2 (#317)

* Fixed broken LED (#322)

* Fixed broken LED

* Fixed test

* Fixed test

* Use Int32 instead of UInt32 to be closer to the Webots API, fixed test

* add ros_environnement (#328)

Co-authored-by: Stefan Arndt <[email protected]>
Co-authored-by: Tim Clephas <[email protected]>
Co-authored-by: Darko Lukić <[email protected]>
Co-authored-by: Olivier Michel <[email protected]>
Co-authored-by: Stefania Pedrazzi <[email protected]>
Co-authored-by: dzyGIT <[email protected]>
Co-authored-by: Your Name <[email protected]>
Co-authored-by: Yanick Douven <[email protected]>

Co-authored-by: Stefan Arndt <[email protected]>
Co-authored-by: Tim Clephas <[email protected]>
Co-authored-by: Darko Lukić <[email protected]>
Co-authored-by: Olivier Michel <[email protected]>
Co-authored-by: Stefania Pedrazzi <[email protected]>
Co-authored-by: dzyGIT <[email protected]>
Co-authored-by: Your Name <[email protected]>
Co-authored-by: Yanick Douven <[email protected]>

* Merge Galactic into master (#332)

* Master into Galactic (#314)

* Fix webots_ros2_control changelog (#251)

* Update CHANGELOG.rst

* Update CHANGELOG.rst

* Update CHANGELOG.rst

* Update CHANGELOG.rst

* Update CHANGELOG.rst

* Update CHANGELOG.rst

* Update CHANGELOG.rst

* Update CHANGELOG.rst

* Update package.xml (#252)

* Added new --no-rendering option to webots launcher (#253)

* Fix library directory

* Don't use a subdirectory

* Fix warnings (#255)

* Fix warnings

* Simpler fix

* Fix Windows build (#258)

* Fix Windows build

* ID is not a member anymore

* Export C++ libController

* Fix libController

* Update module

* Fix controller spawner

* Update robot_launch.py

* Update README.md (#259)

* Fix the IMU library exportation (#262)

* Update CMakeLists.txt

* Update CMakeLists.txt

* Prepare version number for 1.1.1 (#264)

* Prepare

* Increase version number

* Use ros2 node clock for message timestamping (#263)

* Change to ros2 node clock for all devices

* Add Python plugin support to `webots_ros2_driver` (#265)

* Add Python <--> C++ test

* Prepare

* Initial prototype

* Add WebotsNode object

* Add properties

* Import the Python lib

* Improve error handling

* Cleaner

* Add node example

* Integrate the new libController

* Delete the test

* Fix copyright

* Explain

* Copyright fix

* Constructor can be private

* Print Python errors

* Fix Windows usage

* Update webots_ros2_driver/src/PythonPlugin.cpp

Co-authored-by: Olivier Michel <[email protected]>

* Update webots_ros2_driver/src/WebotsNode.cpp

Co-authored-by: Olivier Michel <[email protected]>

* Update webots_ros2_turtlebot/webots_ros2_turtlebot/plugin_example.py

Co-authored-by: Olivier Michel <[email protected]>

* Use const

Co-authored-by: Olivier Michel <[email protected]>

* Fix Rolling warnings and `ament_python_install_package` (#266)

* Fix Rolling warnings and `ament_python_install_package`

* Add to CI

* Add runtime tests (#268)

* Add WebotsLauncher

* Add test package

* Add distance sensor tests

* Add range finder test

* Add plugin test

* Fix spelling

* Add IMU test

* Improve publishing

* Add light sensor test

* Fix colcon test

* Add CI

* Use sudo

* Update

* Update with sudo

* Add missing packages

* Add cache

* Test

* Test

* Test

* Test

* Fix

* Test

* Test

* Test

* Test

* Test

* Increase timeout

* Revert camera test

* pylint

* Fix Windows arguments

* Update webots_ros2_driver/webots_ros2_driver/webots_launcher.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update webots_ros2_driver/webots_ros2_driver/utils.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update webots_ros2_driver/webots_ros2_driver/utils.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update webots_ros2_driver/webots_ros2_driver/utils.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update utils.py

* Update driver_test.wbt

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Increase the version number (#277)

* Fix URDF importer dependencies (#279)

* Update package.xml

* Update package.xml

* Update package.xml

* Update package.xml

* Update package.xml

* Fix uninitialized mWebotsXMLElement (#278)

* fix 273

* Update webots_ros2_driver/src/WebotsNode.cpp

Co-authored-by: Darko Lukić <[email protected]>

Co-authored-by: Your Name <[email protected]>
Co-authored-by: Darko Lukić <[email protected]>

* Fix 280 (#281)

* fix 273

* Update webots_ros2_driver/src/WebotsNode.cpp

Co-authored-by: Darko Lukić <[email protected]>

* let generate webots_ros2_control.lib in windows

Co-authored-by: Your Name <[email protected]>
Co-authored-by: Darko Lukić <[email protected]>

* Print tips: robot_state_publisher started or not (#283)

Print "the `robot_description` parameter is set or not "

* Revert `robot_state_publisher` check (#285)

* Utilize `webots_ros2_driver` in `webots_ros2_mavic` and `webots_ros2_turtlebot` (#269)

* Add turtlebot tests

* Convert Mavic

* Add mavic test

* clean

* Add deps

* Fix node creation

* Increase timeout

* Better

* Fix tests

* Add killall

* Add missing deps

* Wait more in CI

* Fix

* Convert universal robot

* Add rviz

* Fix

* Revert universal robot

* Delete ur changes

* Fix

* Fix to suit to pep257 convention (#290)

* init

* fixed all errors pep257

* CI

* Creation of system test for TurtleBot SLAM tutorial (#292)

* test system turtlebot tutorial SLAM

* Navigation test and put the 2 tests in a single file

* ci_after_init install foxy turtlebot3

* fix after_init

* CI

* CI after_install_target_depend

* fix

* Update test.yml

* Update ci_after_init.bash

* Update ci_after_install_target_dependencies.bash

* CI permission after_depend

* fix

* fix CI

* check packages

* fix ci ci_after_init_bash

* fix pep257

* CI pep257

* flake8 fix

* flake8

* test only SLAM

* test only slam fix

* test only slam fix flake

* Only Slam test CI

* fix exit for CI

* quit instead exit for CI

* fix CI

* Update scripts/ci_after_init.bash

Co-authored-by: Darko Lukić <[email protected]>

* Update webots_ros2_tests/test/test_system_turtlebot_tutorials.py

Co-authored-by: Darko Lukić <[email protected]>

* improved test slam

* fix merge

* Comment after_init

* Update scripts/ci_after_init.bash

Co-authored-by: Darko Lukić <[email protected]>

Co-authored-by: Darko Lukić <[email protected]>

* fix call we_camera_recognition_disable() on NULL recognition node (#294)

* Fix Lidar range (#298)

* Utilize `webots_ros2_driver` in `webots_ros2_epuck` (#296)

* initial commit progress on epuck alone scenario

* 1st draft full conversion

* system tests in dev

* basic epuck driver converted

* system tests draft

* system tests on simple epuck ok

* Apply suggestions from code review

Co-authored-by: Darko Lukić <[email protected]>

* modif review PR

* CI

* fix CI

* fix CI package test has tf2_ros

* remove testFootPrint

* fix CI driver plugin python test

* System tests for scenarios

* System tests scenarios CI foxy

* Change test plan

* more delay plan test

* more delay plan test fix flake

* fix ci rolling

* fix CI rolling nav2bringup

* fix CI rolling nav2bringup pckg required

* removed test rats scenario

* flake8

* removed file test rats scenario

* review changes

* review changes + flake

* revert changes du to Tesla PR

* fix test tools

* adapt topics name

Co-authored-by: Darko Lukić <[email protected]>

* Utilize `webots_ros2_driver` in Universal Robot examples (#286)

* Utilize `webots_ros2_driver` in Universal Robot examples

* Fix ros control

* Delete unnecessary packages

* Convert multiarmed demo

* Add description

* Convert multirobot demo

* Delete unnecessary examples

* Unused

* Begin test

* Revert

* fix

* Test

* Avoid warnings

* Test

* Test

* Test

* Update package.xml

* Update package.xml

* Update package.xml

* Add changelog

* Delete

* Missing deps

* Increase delay

* Fix

* Record

* continue

* Update package.xml

* Update package.xml

* Update webots_launcher.py

* Update test.yml

* Update test.yml

* Fix

* Change

* Longer

* Change

* Update test.yml

* Longer

* Update test_system_universal_robot.py

* Add --input and --xacro-opts arguments to allow calling xacro2proto from a launch file

* Flake8

* Delete unnecessary packages (#301)

* Delete unnecessary packages

* Delete deps

* msgs

* Add new tiago

* wip

* Fix

* fix

* Fix

* Add

* Timeout

* Lighter

* fix

* exit

* revert

* Tesla conversion from Core to Driver (#300)

* temp commit

* temp

* temp commit

* pause to dev Autoware Interface

* temp com

* Webots .so files should be ok but tesla do not see vehicle

* system tests ok

* temp com

* change in libcontroller git

* cv2 and numpy package

* remove numpy package.xml

* correction python3-cv2/numpy

* cv2 in package.xml changed in opencv

* save file

* more time test tesla

* more time test tesla 2

* added rosbag debug ci

* flake8

* package rosbag

* qos LaneFollower

* Apply suggestions from code review

Co-authored-by: Darko Lukić <[email protected]>

* Update review

* temp com

* fix windows build

* commentary python pluggin

* Qos lane follower Windows

* lane follower remove debug msg

* Compatiblity Windows and ROS Rolling

* fix flake8

* Update webots_ros2_driver/include/webots_ros2_driver/PluginInterface.hpp

Co-authored-by: Olivier Michel <[email protected]>

* update driver test function static

* update libcontroller

* fix library

* review corrections

* fix

* update libcontroller

* python warning debug removed

Co-authored-by: Darko Lukić <[email protected]>
Co-authored-by: Olivier Michel <[email protected]>

Co-authored-by: Darko Lukić <[email protected]>
Co-authored-by: Stefan Arndt <[email protected]>
Co-authored-by: Olivier Michel <[email protected]>
Co-authored-by: Stefania Pedrazzi <[email protected]>
Co-authored-by: dzyGIT <[email protected]>
Co-authored-by: Your Name <[email protected]>
Co-authored-by: BenjaminHug8 <[email protected]>
Co-authored-by: Yanick Douven <[email protected]>

* Merge master into galactic (#323)

* Fix webots_ros2_control changelog (#251)

* Update CHANGELOG.rst

* Update CHANGELOG.rst

* Update CHANGELOG.rst

* Update CHANGELOG.rst

* Update CHANGELOG.rst

* Update CHANGELOG.rst

* Update CHANGELOG.rst

* Update CHANGELOG.rst

* Update package.xml (#252)

* Added new --no-rendering option to webots launcher (#253)

* Fix library directory

* Don't use a subdirectory

* Fix warnings (#255)

* Fix warnings

* Simpler fix

* Fix Windows build (#258)

* Fix Windows build

* ID is not a member anymore

* Export C++ libController

* Fix libController

* Update module

* Fix controller spawner

* Update robot_launch.py

* Update README.md (#259)

* Fix the IMU library exportation (#262)

* Update CMakeLists.txt

* Update CMakeLists.txt

* Prepare version number for 1.1.1 (#264)

* Prepare

* Increase version number

* Use ros2 node clock for message timestamping (#263)

* Change to ros2 node clock for all devices

* Add Python plugin support to `webots_ros2_driver` (#265)

* Add Python <--> C++ test

* Prepare

* Initial prototype

* Add WebotsNode object

* Add properties

* Import the Python lib

* Improve error handling

* Cleaner

* Add node example

* Integrate the new libController

* Delete the test

* Fix copyright

* Explain

* Copyright fix

* Constructor can be private

* Print Python errors

* Fix Windows usage

* Update webots_ros2_driver/src/PythonPlugin.cpp

Co-authored-by: Olivier Michel <[email protected]>

* Update webots_ros2_driver/src/WebotsNode.cpp

Co-authored-by: Olivier Michel <[email protected]>

* Update webots_ros2_turtlebot/webots_ros2_turtlebot/plugin_example.py

Co-authored-by: Olivier Michel <[email protected]>

* Use const

Co-authored-by: Olivier Michel <[email protected]>

* Fix Rolling warnings and `ament_python_install_package` (#266)

* Fix Rolling warnings and `ament_python_install_package`

* Add to CI

* Add runtime tests (#268)

* Add WebotsLauncher

* Add test package

* Add distance sensor tests

* Add range finder test

* Add plugin test

* Fix spelling

* Add IMU test

* Improve publishing

* Add light sensor test

* Fix colcon test

* Add CI

* Use sudo

* Update

* Update with sudo

* Add missing packages

* Add cache

* Test

* Test

* Test

* Test

* Fix

* Test

* Test

* Test

* Test

* Test

* Increase timeout

* Revert camera test

* pylint

* Fix Windows arguments

* Update webots_ros2_driver/webots_ros2_driver/webots_launcher.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update webots_ros2_driver/webots_ros2_driver/utils.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update webots_ros2_driver/webots_ros2_driver/utils.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update webots_ros2_driver/webots_ros2_driver/utils.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update utils.py

* Update driver_test.wbt

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Increase the version number (#277)

* Fix URDF importer dependencies (#279)

* Update package.xml

* Update package.xml

* Update package.xml

* Update package.xml

* Update package.xml

* Fix uninitialized mWebotsXMLElement (#278)

* fix 273

* Update webots_ros2_driver/src/WebotsNode.cpp

Co-authored-by: Darko Lukić <[email protected]>

Co-authored-by: Your Name <[email protected]>
Co-authored-by: Darko Lukić <[email protected]>

* Fix 280 (#281)

* fix 273

* Update webots_ros2_driver/src/WebotsNode.cpp

Co-authored-by: Darko Lukić <[email protected]>

* let generate webots_ros2_control.lib in windows

Co-authored-by: Your Name <[email protected]>
Co-authored-by: Darko Lukić <[email protected]>

* Print tips: robot_state_publisher started or not (#283)

Print "the `robot_description` parameter is set or not "

* Revert `robot_state_publisher` check (#285)

* Utilize `webots_ros2_driver` in `webots_ros2_mavic` and `webots_ros2_turtlebot` (#269)

* Add turtlebot tests

* Convert Mavic

* Add mavic test

* clean

* Add deps

* Fix node creation

* Increase timeout

* Better

* Fix tests

* Add killall

* Add missing deps

* Wait more in CI

* Fix

* Convert universal robot

* Add rviz

* Fix

* Revert universal robot

* Delete ur changes

* Fix

* Fix to suit to pep257 convention (#290)

* init

* fixed all errors pep257

* CI

* Creation of system test for TurtleBot SLAM tutorial (#292)

* test system turtlebot tutorial SLAM

* Navigation test and put the 2 tests in a single file

* ci_after_init install foxy turtlebot3

* fix after_init

* CI

* CI after_install_target_depend

* fix

* Update test.yml

* Update ci_after_init.bash

* Update ci_after_install_target_dependencies.bash

* CI permission after_depend

* fix

* fix CI

* check packages

* fix ci ci_after_init_bash

* fix pep257

* CI pep257

* flake8 fix

* flake8

* test only SLAM

* test only slam fix

* test only slam fix flake

* Only Slam test CI

* fix exit for CI

* quit instead exit for CI

* fix CI

* Update scripts/ci_after_init.bash

Co-authored-by: Darko Lukić <[email protected]>

* Update webots_ros2_tests/test/test_system_turtlebot_tutorials.py

Co-authored-by: Darko Lukić <[email protected]>

* improved test slam

* fix merge

* Comment after_init

* Update scripts/ci_after_init.bash

Co-authored-by: Darko Lukić <[email protected]>

Co-authored-by: Darko Lukić <[email protected]>

* fix call we_camera_recognition_disable() on NULL recognition node (#294)

* Fix Lidar range (#298)

* Utilize `webots_ros2_driver` in `webots_ros2_epuck` (#296)

* initial commit progress on epuck alone scenario

* 1st draft full conversion

* system tests in dev

* basic epuck driver converted

* system tests draft

* system tests on simple epuck ok

* Apply suggestions from code review

Co-authored-by: Darko Lukić <[email protected]>

* modif review PR

* CI

* fix CI

* fix CI package test has tf2_ros

* remove testFootPrint

* fix CI driver plugin python test

* System tests for scenarios

* System tests scenarios CI foxy

* Change test plan

* more delay plan test

* more delay plan test fix flake

* fix ci rolling

* fix CI rolling nav2bringup

* fix CI rolling nav2bringup pckg required

* removed test rats scenario

* flake8

* removed file test rats scenario

* review changes

* review changes + flake

* revert changes du to Tesla PR

* fix test tools

* adapt topics name

Co-authored-by: Darko Lukić <[email protected]>

* Utilize `webots_ros2_driver` in Universal Robot examples (#286)

* Utilize `webots_ros2_driver` in Universal Robot examples

* Fix ros control

* Delete unnecessary packages

* Convert multiarmed demo

* Add description

* Convert multirobot demo

* Delete unnecessary examples

* Unused

* Begin test

* Revert

* fix

* Test

* Avoid warnings

* Test

* Test

* Test

* Update package.xml

* Update package.xml

* Update package.xml

* Add changelog

* Delete

* Missing deps

* Increase delay

* Fix

* Record

* continue

* Update package.xml

* Update package.xml

* Update webots_launcher.py

* Update test.yml

* Update test.yml

* Fix

* Change

* Longer

* Change

* Update test.yml

* Longer

* Update test_system_universal_robot.py

* Add --input and --xacro-opts arguments to allow calling xacro2proto from a launch file

* Flake8

* Delete unnecessary packages (#301)

* Delete unnecessary packages

* Delete deps

* msgs

* Add new tiago

* wip

* Fix

* fix

* Fix

* Add

* Timeout

* Lighter

* fix

* exit

* revert

* Tesla conversion from Core to Driver (#300)

* temp commit

* temp

* temp commit

* pause to dev Autoware Interface

* temp com

* Webots .so files should be ok but tesla do not see vehicle

* system tests ok

* temp com

* change in libcontroller git

* cv2 and numpy package

* remove numpy package.xml

* correction python3-cv2/numpy

* cv2 in package.xml changed in opencv

* save file

* more time test tesla

* more time test tesla 2

* added rosbag debug ci

* flake8

* package rosbag

* qos LaneFollower

* Apply suggestions from code review

Co-authored-by: Darko Lukić <[email protected]>

* Update review

* temp com

* fix windows build

* commentary python pluggin

* Qos lane follower Windows

* lane follower remove debug msg

* Compatiblity Windows and ROS Rolling

* fix flake8

* Update webots_ros2_driver/include/webots_ros2_driver/PluginInterface.hpp

Co-authored-by: Olivier Michel <[email protected]>

* update driver test function static

* update libcontroller

* fix library

* review corrections

* fix

* update libcontroller

* python warning debug removed

Co-authored-by: Darko Lukić <[email protected]>
Co-authored-by: Olivier Michel <[email protected]>

* Fix universal robot system tests random faillure (#311)

* fix longer

* test order launch

* remove ros bag

* fix clang

* test spin once between init and send goal

* fix

* test

* test follow traj client

* sleep test

* test confirmation need sleep

* Add commentary

* longer

* correction path abb and sleep moved

* add current issue

* longer

* test wait_for_server

* longer timeout

* timeout test bit longer

* remove debug

* Correction for Rolling CI testing failling due to change in ros2control (base_interface) (#315)

* compliance CI folling foxy testing main from TIMPLE ros2control change base interface

* fix compliance

* cast double in int

* new fix cast int

* review github

* update .yaml

* debug and clean conversion duration

* Update test.yml

* fix rolling and galactic testing

* fix merge of rolling testing in main

Co-authored-by: Olivier Michel <[email protected]>

* Prepare release 1.1.2 (#317)

* fix

* Fixed broken LED (#322)

* Fixed broken LED

* Fixed test

* Fixed test

* Use Int32 instead of UInt32 to be closer to the Webots API, fixed test

Co-authored-by: Darko Lukić <[email protected]>
Co-authored-by: Stefan Arndt <[email protected]>
Co-authored-by: Tim Clephas <[email protected]>
Co-authored-by: Olivier Michel <[email protected]>
Co-authored-by: Stefania Pedrazzi <[email protected]>
Co-authored-by: dzyGIT <[email protected]>
Co-authored-by: Your Name <[email protected]>
Co-authored-by: Yanick Douven <[email protected]>

* libcontroller (#326)

Co-authored-by: Tim Clephas <[email protected]>
Co-authored-by: Darko Lukić <[email protected]>
Co-authored-by: Stefan Arndt <[email protected]>
Co-authored-by: Olivier Michel <[email protected]>
Co-authored-by: Stefania Pedrazzi <[email protected]>
Co-authored-by: dzyGIT <[email protected]>
Co-authored-by: Your Name <[email protected]>
Co-authored-by: Yanick Douven <[email protected]>

* Merge Rolling into master (#331)

* Fix the IMU library exportation (#262)

* Update CMakeLists.txt

* Update CMakeLists.txt

* Prepare version number for 1.1.1 (#264)

* Prepare

* Increase version number

* Use ros2 node clock for message timestamping (#263)

* Change to ros2 node clock for all devices

* Add Python plugin support to `webots_ros2_driver` (#265)

* Add Python <--> C++ test

* Prepare

* Initial prototype

* Add WebotsNode object

* Add properties

* Import the Python lib

* Improve error handling

* Cleaner

* Add node example

* Integrate the new libController

* Delete the test

* Fix copyright

* Explain

* Copyright fix

* Constructor can be private

* Print Python errors

* Fix Windows usage

* Update webots_ros2_driver/src/PythonPlugin.cpp

Co-authored-by: Olivier Michel <[email protected]>

* Update webots_ros2_driver/src/WebotsNode.cpp

Co-authored-by: Olivier Michel <[email protected]>

* Update webots_ros2_turtlebot/webots_ros2_turtlebot/plugin_example.py

Co-authored-by: Olivier Michel <[email protected]>

* Use const

Co-authored-by: Olivier Michel <[email protected]>

* Fix Rolling warnings and `ament_python_install_package` (#266)

* Fix Rolling warnings and `ament_python_install_package`

* Add to CI

* Add runtime tests (#268)

* Add WebotsLauncher

* Add test package

* Add distance sensor tests

* Add range finder test

* Add plugin test

* Fix spelling

* Add IMU test

* Improve publishing

* Add light sensor test

* Fix colcon test

* Add CI

* Use sudo

* Update

* Update with sudo

* Add missing packages

* Add cache

* Test

* Test

* Test

* Test

* Fix

* Test

* Test

* Test

* Test

* Test

* Increase timeout

* Revert camera test

* pylint

* Fix Windows arguments

* Update webots_ros2_driver/webots_ros2_driver/webots_launcher.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update webots_ros2_driver/webots_ros2_driver/utils.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update webots_ros2_driver/webots_ros2_driver/utils.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update webots_ros2_driver/webots_ros2_driver/utils.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update utils.py

* Update driver_test.wbt

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Merge master into rolling (#324)

* Fix the IMU library exportation (#262)

* Update CMakeLists.txt

* Update CMakeLists.txt

* Prepare version number for 1.1.1 (#264)

* Prepare

* Increase version number

* Use ros2 node clock for message timestamping (#263)

* Change to ros2 node clock for all devices

* Add Python plugin support to `webots_ros2_driver` (#265)

* Add Python <--> C++ test

* Prepare

* Initial prototype

* Add WebotsNode object

* Add properties

* Import the Python lib

* Improve error handling

* Cleaner

* Add node example

* Integrate the new libController

* Delete the test

* Fix copyright

* Explain

* Copyright fix

* Constructor can be private

* Print Python errors

* Fix Windows usage

* Update webots_ros2_driver/src/PythonPlugin.cpp

Co-authored-by: Olivier Michel <[email protected]>

* Update webots_ros2_driver/src/WebotsNode.cpp

Co-authored-by: Olivier Michel <[email protected]>

* Update webots_ros2_turtlebot/webots_ros2_turtlebot/plugin_example.py

Co-authored-by: Olivier Michel <[email protected]>

* Use const

Co-authored-by: Olivier Michel <[email protected]>

* Fix Rolling warnings and `ament_python_install_package` (#266)

* Fix Rolling warnings and `ament_python_install_package`

* Add to CI

* Add runtime tests (#268)

* Add WebotsLauncher

* Add test package

* Add distance sensor tests

* Add range finder test

* Add plugin test

* Fix spelling

* Add IMU test

* Improve publishing

* Add light sensor test

* Fix colcon test

* Add CI

* Use sudo

* Update

* Update with sudo

* Add missing packages

* Add cache

* Test

* Test

* Test

* Test

* Fix

* Test

* Test

* Test

* Test

* Test

* Increase timeout

* Revert camera test

* pylint

* Fix Windows arguments

* Update webots_ros2_driver/webots_ros2_driver/webots_launcher.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update webots_ros2_driver/webots_ros2_driver/utils.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update webots_ros2_driver/webots_ros2_driver/utils.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update webots_ros2_driver/webots_ros2_driver/utils.py

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Update utils.py

* Update driver_test.wbt

Co-authored-by: Stefania Pedrazzi <[email protected]>

* Increase the version number (#277)

* Fix URDF importer dependencies (#279)

* Update package.xml

* Update package.xml

* Update package.xml

* Update package.xml

* Update package.xml

* Fix uninitialized mWebotsXMLElement (#278)

* fix 273

* Update webots_ros2_driver/src/WebotsNode.cpp

Co-authored-by: Darko Lukić <[email protected]>

Co-authored-by: Your Name <[email protected]>
Co-authored-by: Darko Lukić <[email protected]>

* Fix 280 (#281)

* fix 273

* Update webots_ros2_driver/src/WebotsNode.cpp

Co-authored-by: Darko Lukić <[email protected]>

* let generate webots_ros2_control.lib in windows

Co-authored-by: Your Name <[email protected]>
Co-authored-by: Darko Lukić <[email protected]>

* Print tips: robot_state_publisher started or not (#283)

Print "the `robot_description` parameter is set or not "

* Revert `robot_state_publisher` check (#285)

* Utilize `webots_ros2_driver` in `webots_ros2_mavic` and `webots_ros2_turtlebot` (#269)

* Add turtlebot tests

* Convert Mavic

* Add mavic test

* clean

* Add deps

* Fix node creation

* Increase timeout

* Better

* Fix tests

* Add killall

* Add missing deps

* Wait more in CI

* Fix

* Convert universal robot

* Add rviz

* Fix

* Revert universal robot

* Delete ur changes

* Fix

* Fix to suit to pep257 convention (#290)

* init

* fixed all errors pep257

* CI

* Creation of system test for TurtleBot SLAM tutorial (#292)

* test system turtlebot tutorial SLAM

* Navigation test and put the 2 tests in a single file

* ci_after_init install foxy turtlebot3

* fix after_init

* CI

* CI after_install_target_depend

* fix

* Update test.yml

* Update ci_after_init.bash

* Update ci_after_install_target_dependencies.bash

* CI permission after_depend

* fix

* fix CI

* check packages

* fix ci ci_after_init_bash

* fix pep257

* CI pep257

* flake8 fix

* flake8

* test only SLAM

* test only slam fix

* test only slam fix flake

* Only Slam test CI

* fix exit for CI

* quit instead exit for CI

* fix CI

* Update scripts/ci_after_init.bash

Co-authored-by: Darko Lukić <[email protected]>

* Update webots_ros2_tests/test/test_system_turtlebot_tutorials.py

Co-authored-by: Darko Lukić <[email protected]>

* improved test slam

* fix merge

* Comment after_init

* Update scripts/ci_after_init.bash

Co-authored-by: Darko Lukić <[email protected]>

Co-authored-by: Darko Lukić <[email protected]>

* fix call we_camera_recognition_disable() on NULL recognition node (#294)

* Fix Lidar range (#298)

* Utilize `webots_ros2_driver` in `webots_ros2_epuck` (#296)

* initial commit progress on…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenjaminHug8 BenjaminHug8 BenjaminHug8 approved these changes

Assignees

@lukicdarkoo lukicdarkoo

Labels
cleanup enhancement New feature or request
Milestone
1.1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@lukicdarkoo @BenjaminHug8