-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Indirect Field Accesses in Proto Templates #6614
Allow Indirect Field Accesses in Proto Templates #6614
Conversation
The CI failure does appear to be reproducible on this branch and not |
It looks like the Side note: In general, proto robots having their controllers restarted when they're regenerated seems a little unintuitive, however, any proposed behavior I can think of has some annoying edge cases. I think the best option is just to make a note of it in the proto docs. If others feel that we should update this behavior in some way, one of us can open a new issue with the proposed behavior. |
Note: It's hard to tell from the diff, but |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me.
Co-authored-by: Olivier Michel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
Description
Allows use of the raw
fields
variable in proto templates.Related Issues
This pull-request fixes issue #6566.
Tasks
Add the list of tasks of this PR.
fields
variable in proto templates.Update the documentation(By my reading of the current documentation [lua] [javascript], the new behavior is already described.)Document the new tagDocumentation
Procedural PROTO Nodes (Lua)
Procedural PROTO Nodes (Javascript)
("Programming Facts" and "PROTO Regeneration" sections)