FIX:Matlab path search on macOS #6390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixes creation of the path were matlab is installed on macOS - fixes search for latest matlab version
omichel
requested changes
Sep 25, 2023
omichel
reviewed
Sep 25, 2023
omichel
reviewed
Sep 25, 2023
- Fix clang-formatting - Simpler "ifndef"-case for error msg
|
Whoops I came on and made your review "outdated". Sorry about that... I can confirm it works on Windows! Only thing to address is the debug info about the found path (#6390 (comment)) |
matl-hsk
commented
Sep 25, 2023
matl-hsk
commented
Sep 25, 2023
nilsjor
previously approved these changes
Sep 25, 2023
omichel
requested changes
Sep 25, 2023
Co-authored-by: Olivier Michel <[email protected]>
omichel
approved these changes
Sep 26, 2023
|
Do you have someone to test it on linux or shall I go ahead and merge? |
|
I believe nothing changed in the way the Linux case is handled, so we can probably merge it as is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
This pull-request fixes issue #6387
Tasks
Add the list of tasks of this PR.
Documentation
No change in documentation.
Additional context
See issue #6387