Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fog billboard js #6301

Merged
merged 2 commits into from
Jul 6, 2023
Merged

Fix fog billboard js #6301

merged 2 commits into from
Jul 6, 2023

Conversation

BenjaminDeleze
Copy link

The parsing of these nodes was not adapted when we added a root node in the webotsjs scenetree

BenjaminDeleze added 2 commits July 6, 2023 09:20
@BenjaminDeleze BenjaminDeleze added the bug Something isn't working label Jul 6, 2023
@BenjaminDeleze BenjaminDeleze added this to the R2023b-rev1 milestone Jul 6, 2023
@BenjaminDeleze BenjaminDeleze self-assigned this Jul 6, 2023
@BenjaminDeleze BenjaminDeleze added the test sources Start the sources test on all platforms label Jul 6, 2023
@BenjaminDeleze BenjaminDeleze marked this pull request as ready for review July 6, 2023 08:14
@BenjaminDeleze BenjaminDeleze requested a review from a team as a code owner July 6, 2023 08:14
@BenjaminDeleze BenjaminDeleze requested a review from omichel July 6, 2023 08:18
omichel
omichel approved these changes Jul 6, 2023
View reviewed changes
Copy link
Member

@omichel omichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@BenjaminDeleze BenjaminDeleze merged commit ddb4f2b into master Jul 6, 2023
@BenjaminDeleze BenjaminDeleze deleted the fix-fog-billboard-js branch July 6, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omichel omichel omichel approved these changes

Assignees

@BenjaminDeleze BenjaminDeleze

Labels
bug Something isn't working test sources Start the sources test on all platforms
Milestone
R2023b-rev1
Development

Successfully merging this pull request may close these issues.
2 participants
@BenjaminDeleze @omichel