Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cppcheck to 2.10 on Ubuntu #6043

Merged
merged 22 commits into from
Apr 4, 2023
Merged

Update cppcheck to 2.10 on Ubuntu #6043

merged 22 commits into from
Apr 4, 2023

Conversation

ygoumaz
Copy link
Contributor

@ygoumaz ygoumaz commented Mar 31, 2023

Update cppcheck to 2.10 on ubuntu to match versions between platforms. Also, restrict cppcheck to given platforms (instead of all configurations on all platforms, which is redundant).

With this update, we can revert useless empty strings initializations (see #6002 (comment))

@ygoumaz ygoumaz added the test sources Start the sources test on all platforms label Mar 31, 2023
@ygoumaz ygoumaz self-assigned this Mar 31, 2023
@ygoumaz ygoumaz added this to the R2023a-rev1 milestone Apr 4, 2023
@ygoumaz ygoumaz added the test webots build Start the build tests label Apr 4, 2023
@ygoumaz ygoumaz marked this pull request as ready for review April 4, 2023 07:15
@ygoumaz ygoumaz requested a review from a team as a code owner April 4, 2023 07:15
@ygoumaz ygoumaz requested a review from stefaniapedrazzi April 4, 2023 07:15
Copy link
Member

@stefaniapedrazzi stefaniapedrazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
Everything seems fine to me.
I'm now checking if the same is also working locally.

I also found some other files where there is default initialization in the initialization list that could be removed.
Can I add them to this PR?

@ygoumaz
Copy link
Contributor Author

ygoumaz commented Apr 4, 2023

Yes, you can directly push your changes to this PR.

@stefaniapedrazzi
Copy link
Member

I tested locally but I'm receiving many errors (like the following one):

src/webots/build/debug/WbRobotWindow.moc.cpp:14:0: error: #error "The header file 'WbRobotWindow.hpp' doesn't include <QObject>." [preprocessorErrorDirective]
#error "The header file 'WbRobotWindow.hpp' doesn't include <QObject>."

It seems we should also skip the build folder.
I assume these errors don't occur on the CI because Webots is not compiled and the build folder is empty.

@ygoumaz
Copy link
Contributor Author

ygoumaz commented Apr 4, 2023

Yes, you are right, the build folder doesn't exist in the CI. I will add the exception on the build folder, as it doesn't make a lot of sense to test those files.

@stefaniapedrazzi
Copy link
Member

Thank you!

I tested the latest version and I'm still getting some of these errors due to the MOC files for a couple of other folders.
I just commit the changes so that you can review them.

Copy link
Contributor Author

@ygoumaz ygoumaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, I let you approve the PR if everything works correctly locally now.

@ygoumaz ygoumaz requested a review from stefaniapedrazzi April 4, 2023 09:54
Copy link
Member

@stefaniapedrazzi stefaniapedrazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ygoumaz ygoumaz merged commit 718dfe0 into master Apr 4, 2023
@ygoumaz ygoumaz deleted the update-cppcheck-ubuntu branch April 4, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test sources Start the sources test on all platforms test webots build Start the build tests
Development

Successfully merging this pull request may close these issues.

None yet

2 participants