-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cppcheck to 2.10 on Ubuntu #6043
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Everything seems fine to me.
I'm now checking if the same is also working locally.
I also found some other files where there is default initialization in the initialization list that could be removed.
Can I add them to this PR?
Yes, you can directly push your changes to this PR. |
I tested locally but I'm receiving many errors (like the following one):
It seems we should also skip the |
Yes, you are right, the build folder doesn't exist in the CI. I will add the exception on the build folder, as it doesn't make a lot of sense to test those files. |
Thank you! I tested the latest version and I'm still getting some of these errors due to the MOC files for a couple of other folders. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me, I let you approve the PR if everything works correctly locally now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Update cppcheck to 2.10 on ubuntu to match versions between platforms. Also, restrict cppcheck to given platforms (instead of all configurations on all platforms, which is redundant).
With this update, we can revert useless empty strings initializations (see #6002 (comment))