Enhancement led support #5850
Merged
Enhancement led support #5850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
September 27, 2022 17:33
* Progress * Progress * Progress * Minimal functionality * Fix encoder * Fix simple updates * Fix SFNode insertion * Fix sfnode reset * Restore regeneration * Functional derived PROTO * Restore restrictions * Potential basetype structure * Fix IS poses * Revert "Potential basetype structure" This reverts commit 7f05090. * Fix grass * Derived tests * Rework parameter links * Progress * Reintroduce baseType instance * Fix regeneration * Rework how derived nodes are stored and fix issues with change propagation * Implement DEF-USE * Fix SFRotation * Fix some issues with MFNode * Fix issues with SFNode * Fix more issues * Progress in delinking instances * Progress in delinking instances * Fix id flagging * Rework webotsjs notification of node changes * Rework regeneration * Rework MFNode insertion/removal * Fix MF insertion & finalization issues * Rework Parameter class * Cleanup * Fix MF removing too many nodes * Fix unfinalization of sfnodes * Cleanup * Progress on default initializer * functional proof of concept for default complex fields * Debug asyncronicity * Fix node generation in PROTO with special fields * Fix sfnode reset * replace default value with tokenizer in all proto models * Status * Fix grass * Debug templating issue * Fix templating * Fix tokenizer consumption * Debug * Fix derived node parameters not propagating * Cleanup Node * Cleanup vrml * Cleanup Parameters * Cleanup ProtoManager * Remove isUse * Fix mfnode reset * Cleanup * Fix MFNode restrictions * Rename parameter linksg * improve rewind * Merge methods * Cleanup * Cleanup * Fix slot issues * Finalize * Fix MFFields * Fix basenode * Improve * Minor * Fix moose * Fix slots * Debug * Fix Tesla * Progress proto rework * improve wheel proto * Cleanup * Fix texture url update * Fix texture update * Fix Tesla PROTO * Fix * Fix tesla lights * Cleanup * Finalize * Fix * Fix * Fix disappering joints * Fix joints tab on tesla * actually commit BO fix * Fix exporter * Fix Nao hand slot
* remove label * title * reduce space --------- Co-authored-by: Olivier Michel <[email protected]>
|
As discussed I changed the color to white when there is an empty list. You can see it in the Nao example |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add led support for web protos.
It is possible that the color keyword is present in the x3d but is not associated with any value. It is the case when the LED is a rgb gradual LED. In this case, we set the LED to the default color: red.
Concerning the Tesla (and other vehicles) protos, we can have the impression that the representation of some LEDs does not work. However this is because the vehicles have LEDs without children (all the LEDs are present in the generic car but the Tesla does not fill all the fields)
Test it here:
https://webots.cloud/run?version=R2023b&url=https://github.com/ad-daniel/prefab/blob/master/protoExamples/protos/tesla/TeslaModel3.proto&type=undefined
https://webots.cloud/run?version=R2023b&url=https://github.com/cyberbotics/webots/blob/develop/projects/robots/softbank/nao/protos/Nao.proto&type=undefined