Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup libcontroller sync in test suite #5689

Merged
merged 2 commits into from
Dec 23, 2022

Conversation

ygoumaz
Copy link
Contributor

@ygoumaz ygoumaz commented Dec 22, 2022

The libcontroller pre-compiled binaries are not used anymore, as they are compiled on the webots_ros2 side. The synchronization of the libcontroller source files is now performed on the webots_ros2 side too.

This PR cleans the old sync process to the libcontroller repository.

@ygoumaz ygoumaz self-assigned this Dec 22, 2022
@ygoumaz ygoumaz added the cleanup Any design, code, file or folder cleanup label Dec 22, 2022
@ygoumaz ygoumaz added this to the R2023a-rev1 milestone Dec 22, 2022
@ygoumaz ygoumaz marked this pull request as ready for review December 22, 2022 10:10
@ygoumaz ygoumaz requested a review from a team as a code owner December 22, 2022 10:10
Copy link
Member

@omichel omichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@ygoumaz ygoumaz merged commit 3f872d9 into master Dec 23, 2022
@ygoumaz ygoumaz deleted the cleanup-remove-lib-controller-sync branch December 23, 2022 08:44
ygoumaz added a commit that referenced this pull request Dec 26, 2022
* Fix infinite loop updating ODE geometries (#5686)

* Skip updates if geometry is going to be deleted

* Fix dangling ODE geometries

* Update changelog

* remove libcontroller sync in test suite (#5689)

Co-authored-by: Olivier Michel <[email protected]>

* Merge released into master (#5696)

* Add a troubleshooting section for macOS installation with respect to Rosetta (#5691)

* Update installation-procedure.md

* Update installation-procedure.md

* Add files via upload

* Add necessary first line in proto file examples (#5692)

* Add necessary first line in proto file examples

* Update docs/guide/tutorial-7-your-first-proto.md

Co-authored-by: Olivier Michel <[email protected]>

* Update docs/guide/tutorial-7-your-first-proto.md

Co-authored-by: Olivier Michel <[email protected]>

* Update docs/guide/tutorial-7-your-first-proto.md

Co-authored-by: Olivier Michel <[email protected]>

Co-authored-by: Olivier Michel <[email protected]>

Co-authored-by: Olivier Michel <[email protected]>
Co-authored-by: Stephan Kunz <[email protected]>

Co-authored-by: Stefania Pedrazzi <[email protected]>
Co-authored-by: Yannick Goumaz <[email protected]>
Co-authored-by: Olivier Michel <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Stephan Kunz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Any design, code, file or folder cleanup
Development

Successfully merging this pull request may close these issues.

2 participants