Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crazyflie web component #4780

Merged
merged 20 commits into from
Jun 29, 2022
Merged

Conversation

ThomasOliverKimble
Copy link
Contributor

Description

  • Fix the new Crazyflie's web component view. (see here)
  • Update Crazyflie world by modifying viewpoint and adding a follow to the Viewpoint

crazyflie_demo

@ThomasOliverKimble ThomasOliverKimble added the bug Something isn't working label Jun 28, 2022
@ThomasOliverKimble ThomasOliverKimble added this to the R2022b milestone Jun 28, 2022
@ThomasOliverKimble ThomasOliverKimble self-assigned this Jun 28, 2022
@ThomasOliverKimble ThomasOliverKimble requested a review from a team as a code owner June 28, 2022 12:32
Copy link
Contributor

@knmcguire knmcguire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a tiny change necessary here :) but it looks good at https://www.cyberbotics.com/doc/guide/crazyflie?version=fix-crazyflie-web-component. It was only hanging in the air.

scripts/web_component_studio/components.json Outdated Show resolved Hide resolved
@knmcguire
Copy link
Contributor

I guess after we change the json file, it needs to be run again right?

Copy link
Contributor

@ad-daniel ad-daniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment. Concerning the meshes in the x3d, it should be possible to re-use the existing ones by setting the url to: webots://path/to/meshes (it's what we do for the panda for instance, but I'm not sure we do it for all). I think you can delete them and fix the urls manually in this PR, I'll open an issue about it so that we can improve the web component script.

@ThomasOliverKimble ThomasOliverKimble removed the request for review from omichel June 28, 2022 13:01
@ThomasOliverKimble
Copy link
Contributor Author

Just a comment. Concerning the meshes in the x3d, it should be possible to re-use the existing ones by setting the url to: webots://path/to/meshes (it's what we do for the panda for instance, but I'm not sure we do it for all). I think you can delete them and fix the urls manually in this PR, I'll open an issue about it so that we can improve the web component script.

I have just done the modifications, but yes we should look into this.

ad-daniel
ad-daniel previously approved these changes Jun 28, 2022
Copy link
Contributor

@ad-daniel ad-daniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@knmcguire
Copy link
Contributor

@ThomasOliverKimble
Copy link
Contributor Author

Seems to not float anymore. https://www.cyberbotics.com/doc/guide/crazyflie?version=fix-crazyflie-web-component

Yes, if you want it to float, the translation has to be: '0 0 0.05' in the json/x3d files.

@knmcguire
Copy link
Contributor

That is fine :) the props are not turning so it actually looks a bit weird if it is floating. I prefer it being on the ground for now.

Copy link
Contributor

@ad-daniel ad-daniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@ThomasOliverKimble ThomasOliverKimble merged commit d2d8f9f into develop Jun 29, 2022
@ThomasOliverKimble ThomasOliverKimble deleted the fix-crazyflie-web-component branch June 29, 2022 13:27
@knmcguire
Copy link
Contributor

thanks for handling this @ThomasOliverKimble !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

3 participants