-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crazyflie web component #4780
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a tiny change necessary here :) but it looks good at https://www.cyberbotics.com/doc/guide/crazyflie?version=fix-crazyflie-web-component. It was only hanging in the air.
I guess after we change the json file, it needs to be run again right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a comment. Concerning the meshes in the x3d, it should be possible to re-use the existing ones by setting the url to: webots://path/to/meshes
(it's what we do for the panda for instance, but I'm not sure we do it for all). I think you can delete them and fix the urls manually in this PR, I'll open an issue about it so that we can improve the web component script.
Co-authored-by: Kimberly McGuire <[email protected]>
I have just done the modifications, but yes we should look into this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
Seems to not float anymore. https://www.cyberbotics.com/doc/guide/crazyflie?version=fix-crazyflie-web-component |
Yes, if you want it to float, the translation has to be: '0 0 0.05' in the json/x3d files. |
That is fine :) the props are not turning so it actually looks a bit weird if it is floating. I prefer it being on the ground for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
thanks for handling this @ThomasOliverKimble ! |
Description
follow
to theViewpoint