Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade conjur-api-go to 0.12.4 #137

Closed
wants to merge 1 commit into from
Closed

Conversation

karand1979
Copy link
Contributor

@karand1979 karand1979 commented Oct 22, 2024

Desired Outcome

The desired outcome of this pull request is to upgrade to the latest version of the conjur-api-go package and any supporting dependencies. This will allow our organization to utilize the new environment variables supported by the higher version.

Implemented Changes

We ran following commands to upgrade the version and ran the ./bin/build to ensure everything built. Also ran ./bin/test oss
go get github.com/cyberark/conjur-api-go@latest
go mod tidy

Connected Issue/Story

Resolves #[135]

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be
merged.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: [insert issue ID]
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@karand1979
Copy link
Contributor Author

@szh here is the new pull request for the updgrade of the go client.

@szh szh self-assigned this Oct 22, 2024
@szh szh added kind/community contributor dependencies Pull requests that update a dependency file labels Oct 22, 2024
@szh
Copy link
Contributor

szh commented Oct 23, 2024

This is fixed in release v0.6.9 via commit b5faaf4. The main branch in this repo hasn't been updated yet but will be soon.
Thanks again for your contribution!

@szh szh closed this Oct 23, 2024
@karand1979
Copy link
Contributor Author

@szh thanks! Can you let me know when it will be available in the terraform registry?

@karand1979
Copy link
Contributor Author

@szh any updates on when main will be updated and the version updated in the Terraform registry? I noticed the .sig file is not part of the release artifacts.

@szh
Copy link
Contributor

szh commented Oct 28, 2024

@karand1979 I'm so sorry for the delay. We're working through an internal infrastructure issue but I'm pushing for it to be done ASAP. I'll update when I know more.

@szh
Copy link
Contributor

szh commented Oct 29, 2024

I'm glad to report that the TF registry is updated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor dependencies Pull requests that update a dependency file kind/community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants