-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support content-type annotation for K8s secrets #506
Conversation
0efcba0
to
b0ad7f9
Compare
}, | ||
requiredSecrets: []string{"k8s-secret1", "k8s-secret2"}, | ||
asserts: []assertFunc{ | ||
// TODO - uncomment when decoding is implemented |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the actual decoding going to be in a separate PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I planned on tackling it in a followup task, yes. The decoding implementation should be a minor code change but that PR will also include error handling, additional tests, dev environment/manifest updates, etc. so I thought it would be more manageable as a separate task.
This assertion was copied over from the POC since it'll be helpful for that PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a rebase, otherwise looks good
b0ad7f9
to
062433f
Compare
Code Climate has analyzed commit 062433f and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 92.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 89.1% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Desired Outcome
Add support to K8s secrets mode for setting secret content-types via annotations in the secrets manifest. It should support the following:
The conjur-map annotation for secrets will now support the format:
Where
id
is required to have a non-empty value, andcontent-type
is an optional key which defaults totext
unless explicitly set tobase64
Implemented Changes
updateDestination
struct in K8sProviderDefinition of Done
At least 1 todo must be completed in the sections below for the PR to be
merged.
Changelog
CHANGELOG update
Test coverage
changes, or
Documentation
README
s) were updated in this PRBehavior
Security