-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update golang.org/x/net #484
Conversation
Signed-off-by: Andy Tinkham <[email protected]>
Signed-off-by: Andy Tinkham <[email protected]>
@@ -31,7 +31,7 @@ Section 2: BSD 3-Clause | |||
Section 3: MIT | |||
>>> github.com/cenkalti/backoff - v2.2.1 | |||
>>> github.com/json-iterator/go - v1.1.12 | |||
>>> github.com/stretchr/testify - v1.8.2 | |||
>>> github.com/stretchr/testify - v1.8.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we downgrading testify?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No - that's just the NOTICES.txt file and it corrects a typo previously made when we bumped to 1.8.0 (only the NOTICES.txt file ever had 1.8.2, which doesn't exist yet).
Signed-off-by: Andy Tinkham <[email protected]>
908202e
to
75f9f0f
Compare
Signed-off-by: Andy Tinkham <[email protected]>
75f9f0f
to
a5aa7e7
Compare
Code Climate has analyzed commit a5aa7e7 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 89.1% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Desired Outcome
Remove versions of golang.org/x/net that are vulnerable to CVE-2022-27664
Implemented Changes
Connected Issue/Story
CyberArk internal issue link: CONJSE-1529
Definition of Done
At least 1 todo must be completed in the sections below for the PR to be
merged.
Changelog
CHANGELOG update
Test coverage
changes, or
Documentation
README
s) were updated in this PRBehavior
Security