Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ubi image #469

Merged
merged 1 commit into from
Jun 15, 2022
Merged

Update ubi image #469

merged 1 commit into from
Jun 15, 2022

Conversation

rpothier
Copy link
Contributor

@rpothier rpothier commented Jun 14, 2022

Desired Outcome

Built images should not have security vulnerabilities.

Implemented Changes

Updated the Red HAt UBI base image.

Connected Issue/Story

Resolves #[relevant GitHub issue(s), e.g. 76]

CyberArk internal issue link: insert issue ID

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be
merged.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: insert issue ID
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@rpothier rpothier requested a review from a team as a code owner June 14, 2022 15:03
@rpothier rpothier marked this pull request as draft June 14, 2022 15:03
@rpothier rpothier marked this pull request as ready for review June 14, 2022 15:09
@rpothier rpothier self-assigned this Jun 14, 2022
Copy link
Contributor

@szh szh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@rpothier rpothier force-pushed the update-ubi-image branch 4 times, most recently from cbb39d2 to bcc5236 Compare June 14, 2022 21:05
@codeclimate
Copy link

codeclimate bot commented Jun 15, 2022

Code Climate has analyzed commit b186554 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 89.2% (0.0% change).

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants