Add release automation #234

sigalsax · 2020-09-24T11:43:35Z

This PR is part of a bigger effort in automating our release process

Package helm chart on every build
Add ability to push an edge tag on every master build
Update tag and release process in docs

See generated helm package here: https://jenkins.conjur.net/blue/organizations/jenkins/cyberark--secrets-provider-for-k8s/detail/automate-release/31/artifacts

What ticket does this PR close?

Connected to #233

Checklists

Change log

The CHANGELOG has been updated, or
This PR does not include user-facing changes and doesn't require a CHANGELOG update

Test coverage

This PR includes new unit and integration tests to go with the code changes, or
The changes in this PR do not require tests

Documentation

Docs (e.g. READMEs) were updated in this PR, and/or there is a follow-on issue to update docs, or
This PR does not require updating any documentation

hughsaunders

~~Would be good to see a test of the package/release stages, maybe comment out then when clause for a test?~~

I missed this build which does test the package stage: jenkins.conjur.net/blue/organizations/jenkins/cyberark--secrets-provider-for-k8s/detail/automate-release/31/pipeline/39

hughsaunders · 2020-09-29T12:45:54Z

Jenkinsfile

+        stage('Push Images') {
+          steps {
+            script {
+              BRANCH_NAME=env.BRANCH_NAME


I'm not sure what this for, may as well use ${env.BRANCH_NAME} on L102?

I need the BRANCH_NAME inside publish to determine when to push our edge tag. We want to only push when on master so I need the BRANCH_NAME=env.BRANCH_NAME from the script and output the result. I tried via scripts but I would also get HEAD instead of the actual branch

bootstrap.env

eladkug · 2020-09-30T10:26:59Z

CONTRIBUTING.md

@@ -210,6 +203,14 @@ follow the instructions in this section.
 1. Push the tag: `git push vx.y.z` (or `git push origin vx.y.z` if you are working
   from your local machine).

+### Push Helm package
+1. The tagged build will package the Secrets Provider Helm chart for us. The package will appear under the 'Artifacts' tab of the Jenkins build and will resemble `secrets-provider-<version>.tgz`. 
+Save this file you will need it for the next step.


comma is missing i think.
Save this file , you will need it for the next step.

great catch! I added a "because"

eladkug · 2020-09-30T10:46:28Z

bin/publish

@@ -43,4 +43,8 @@ if [ "$GIT_DESCRIPTION" = "v${VERSION}" ]; then
    echo 'Failed to log in to scan.connect.redhat.com'
    exit 1
  fi
+elif [ "$BRANCH_NAME" = "master" ]; then


Its not relevant for redhat registry?

Good point but I don't think so. I don't know if we would want to be pushing edge tags to RH because the publishing of tags is not an automated process. Our current policy for RH registry is that someone needs to push "publish" for tags to be public facing

eladkug · 2020-10-18T10:58:50Z

ci/jenkins_build

+  -v $PWD/helm/secrets-provider:/root/helm/secrets-provider \
+  -v $PWD/helm-artifacts/:/root/helm-artifacts \
+  --workdir /root/helm-artifacts \
+   alpine/helm:${helm_version} package ../helm/secrets-provider


need to align

should be fixed now

eranha

LGTM, well done.

eladkug

LGTM

Make CONJUR_APPLIANCE_IMAGE tag configurable Add release automation - Package helm chart on every build - Add ability to push an edge tag on every master build - Update tag and release process in docs

codeclimate · 2020-10-18T13:09:31Z

Code Climate has analyzed commit e8ab473 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 87.5% (0.0% change).

View more on Code Climate.

abrahamko · 2020-10-18T13:14:28Z

ci/jenkins_build

+  -v $PWD/helm/secrets-provider:/root/helm/secrets-provider \
+  -v $PWD/helm-artifacts/:/root/helm-artifacts \
+  --workdir /root/helm-artifacts \
+  alpine/helm:${helm_version} package ../helm/secrets-provider


that's the stuff!
😉

sigalsax requested a review from eladkug September 24, 2020 11:43

sigalsax self-assigned this Sep 24, 2020

sigalsax force-pushed the automate-release branch 28 times, most recently from b6bfbf2 to 9094bc9 Compare September 29, 2020 12:06

sigalsax requested review from orenbm, abrahamko and hughsaunders September 29, 2020 12:43

sigalsax force-pushed the automate-release branch 2 times, most recently from 5c2ee4b to cd7b53e Compare September 29, 2020 12:53

hughsaunders reviewed Sep 29, 2020

View reviewed changes

sigalsax marked this pull request as ready for review September 29, 2020 13:00

sigalsax force-pushed the automate-release branch 3 times, most recently from 795a6d8 to 6d36e08 Compare September 30, 2020 08:10

sigalsax requested a review from hughsaunders September 30, 2020 10:22

sigalsax force-pushed the automate-release branch from 6d36e08 to 720d6f0 Compare September 30, 2020 10:26

eladkug reviewed Sep 30, 2020

View reviewed changes

sigalsax force-pushed the automate-release branch 2 times, most recently from 142188c to 527e185 Compare September 30, 2020 12:22

sigalsax requested a review from eladkug October 18, 2020 08:26

sigalsax force-pushed the automate-release branch 2 times, most recently from 3bd1b15 to c3c659a Compare October 18, 2020 10:44

eladkug reviewed Oct 18, 2020

View reviewed changes

sigalsax force-pushed the automate-release branch from c3c659a to 351e459 Compare October 18, 2020 11:08

sigalsax requested a review from eladkug October 18, 2020 11:08

sigalsax force-pushed the automate-release branch 2 times, most recently from e99eb6f to 5a4800a Compare October 18, 2020 11:16

eranha approved these changes Oct 18, 2020

View reviewed changes

eladkug approved these changes Oct 18, 2020

View reviewed changes

Merge pull request #151 from cyberark/configure-dap-image

e8ab473

Make CONJUR_APPLIANCE_IMAGE tag configurable Add release automation - Package helm chart on every build - Add ability to push an edge tag on every master build - Update tag and release process in docs

sigalsax force-pushed the automate-release branch from 5a4800a to e8ab473 Compare October 18, 2020 13:05

abrahamko reviewed Oct 18, 2020

View reviewed changes

sigalsax merged commit a6366d5 into master Oct 19, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add release automation #234

Add release automation #234

sigalsax commented Sep 24, 2020 •

edited

Loading

hughsaunders left a comment •

edited

Loading

hughsaunders Sep 29, 2020

sigalsax Sep 30, 2020

eladkug Sep 30, 2020

sigalsax Sep 30, 2020

eladkug Sep 30, 2020

sigalsax Sep 30, 2020

eladkug Oct 18, 2020

sigalsax Oct 18, 2020

eranha left a comment

eladkug left a comment

codeclimate bot commented Oct 18, 2020

abrahamko Oct 18, 2020

Add release automation #234

Add release automation #234

Conversation

sigalsax commented Sep 24, 2020 • edited Loading

What ticket does this PR close?

Checklists

Change log

Test coverage

Documentation

hughsaunders left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eranha left a comment

Choose a reason for hiding this comment

eladkug left a comment

Choose a reason for hiding this comment

codeclimate bot commented Oct 18, 2020

Choose a reason for hiding this comment

sigalsax commented Sep 24, 2020 •

edited

Loading

hughsaunders left a comment •

edited

Loading