Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update script to print logs on error #1499

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Update script to print logs on error #1499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,11 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Nothing should go in this section, please add to the latest unreleased version
(and update the corresponding date), or add a new version.

## [1.7.18] - 2023-06-08
## [1.7.18] - 2023-06-12

### Changed
- Update CRD test script.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lists should be surrounded by blank lines

[cyberark/secretless-broker#1499](https://github.com/cyberark/secretless-broker/pull/1499)

## [1.7.17] - 2023-04-17

Expand Down
12 changes: 6 additions & 6 deletions k8s-ci/k8s_crds/test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ function wait_for_CRD() {
if [[ "$attempt_count" -ge "$max_attempts" ]]; then
echo ""
echo "CRD is not ready after $attempt_count readiness checks at 2 second intervals." >&2
exit 1
return 1
fi
echo -n "."
sleep 2
Expand All @@ -84,7 +84,7 @@ function wait_for_pod() {
if [[ "$attempt_count" -ge "$max_attempts" ]]; then
echo ""
echo "pod is not ready after $attempt_count readiness checks at 2 second intervals." >&2
exit 1
return 1
fi
echo -n "."
sleep 2
Expand All @@ -97,7 +97,7 @@ function wait_for_pod() {
if [[ "$attempt_count" -ge "$max_attempts" ]]; then
echo ""
echo "pod endpoint is not ready after $attempt_count readiness checks at 2 second intervals." >&2
exit 1
return 1
fi
echo -n "."
sleep 2
Expand Down Expand Up @@ -160,12 +160,12 @@ function main() {

# deploy secretless and echo-server
deploy_secretless
wait_for_CRD
wait_for_pod
wait_for_CRD || exit_err "K8s-CRD test: Failed in wait_for_CRD()"
wait_for_pod || exit_err "K8s-CRD test: Failed in wait_for_pod()"

# run test cases
run_test_case "create configuration object" user1 password1
run_test_case "update configuration object" ohnoeswechangedit supersecretpassword
}

main || exit_err "K8s-CRD test: Failed inside main()"
main