Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update golang.org/x/net and /text, and go mod tidy #1478

Merged
merged 1 commit into from
Oct 27, 2022
Merged

Conversation

andytinkham
Copy link
Contributor

Signed-off-by: Andy Tinkham [email protected]

Desired Outcome

Update 3rd party dependencies with known vulnerabilities

Implemented Changes

In both go.mod and bin/juxtaposer/go.mod:

  • Forced golang.org/x/net to v0.0.0-20220906165146-f3363e06e74c
  • Forced golang.org/x/text to v0.3.8
  • Ran go mod tidy to update everything else

Connected Issue/Story

CyberArk internal issue link: CONJSE-1528

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be
merged.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: insert issue ID
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@andytinkham andytinkham requested a review from a team as a code owner October 26, 2022 22:26
@codeclimate
Copy link

codeclimate bot commented Oct 26, 2022

Code Climate has analyzed commit 5a129c1 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Style 1

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 70.7% (0.0% change).

View more on Code Climate.

@@ -12,8 +12,11 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
## [1.7.15] - 2022-09-22

### Security
- Upgrade golang.org/x/text and golange.org/x/net to reolve CVE-2022-32149
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lists should be surrounded by blank lines

Copy link
Contributor

@gl-johnson gl-johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andytinkham andytinkham merged commit 608d6a7 into main Oct 27, 2022
@andytinkham andytinkham deleted the update-deps branch October 27, 2022 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants