-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Go 1.16 #1434
Update to Go 1.16 #1434
Conversation
cbf34bf
to
4b5b2f3
Compare
d0f88ca
to
82604ba
Compare
I'm changing this PR to a draft until cyberark/go-mssqldb#30 is merged in, because I'll have to update the submodule ref. |
Builds failing. Appears to be a Red Hat issue.
and Github Actions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for taking care of this!
One comment about including an entry in the CHANGELOG.md.
12434e8
to
bea1f4e
Compare
Fixes build failing due to goconvey dependency change
Builds seem to have been broken by |
f6950a2
to
86a828b
Compare
8b75c62
to
dc8ca29
Compare
pkg/k8sclient/clientset/versioned/typed/secretless.io/v1/fake/fake_configuration.go
Show resolved
Hide resolved
pkg/k8sclient/clientset/versioned/typed/secretless.io/v1/fake/fake_configuration.go
Show resolved
Hide resolved
pkg/k8sclient/clientset/versioned/typed/secretless.io/v1/configuration.go
Show resolved
Hide resolved
495a847
to
2cb9dcc
Compare
k8s.io/api v0.22.3 k8s.io/apiextensions-apiserver v0.22.3 k8s.io/apimachinery v0.22.3 k8s.io/client-go v0.22.3
Satisfy new function signatures after K8S package updates.
2cb9dcc
to
c6ac63a
Compare
* Fixes `bin/codegen` script * Updates `Dockerfile.codegen` to use correct upsteam `kubernetes/code-generator` repo tag matching K8S packages * Fix permission denied deleting temp dirs by deleting within Docker context
c6ac63a
to
a1e4384
Compare
…ODO()` false positives
a1e4384
to
32c7cd7
Compare
32c7cd7
to
2e520e3
Compare
Code Climate has analyzed commit 2e520e3 and detected 53 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 54.8% (0.0% change). View more on Code Climate. |
Note to merger: Don't squash commits when merging - "Rebase and merge" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!! Thank you so much for taking care of this!
Fixes build failing due to goconvey dependency change. Depends on cyberark/go-mssqldb#30
Desired Outcome
Jenkins builds of Docker images do NOT fail with errors such as the following:
Implemented Changes
go.mod
is upgraded from Go v1.15 to Go v1.16.go env -w GOFLAGS=-mod=mod
is run in containers to fix this module issue in go1.16go mod tidy
to fix build breaking due to this issuebin/codegen
scriptDockerfile.codegen
to use correct upsteamkubernetes/code-generator
repo tag matching K8S packagescontext.TODO()
false positivesConnected Issue/Story
Incidentally resolves #1387
Definition of Done
Changelog
CHANGELOG update
Test coverage
changes, or
Documentation
README
s) were updated in this PRBehavior
Security