Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change GetValue to GetValues for Providers to allow batch retrieval #1356

Merged
merged 7 commits into from
Oct 19, 2020

Conversation

doodlesbykumbi
Copy link
Contributor

Succeeds #1344 (Cobertura got in the way)

GetValues works exactly the same as GetValue, however GetValues gives providers the ability to implement arbitrary batch retrieval mechanisms.

What does this PR do?

  • What's changed? Why were these changes made?
  • How should the reviewer approach this PR, especially if manual tests are required?
  • Are there relevant screenshots you can add to the PR description?

What ticket does this PR close?

Connected to #[relevant GitHub issues, eg 76]

Checklists

Change log

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code changes, or
  • The changes in this PR do not require tests

Documentation

  • This PR does not require updating any documentation, or
  • Docs (e.g. READMEs) were updated in this PR, and/or there is a follow-on issue to update docs

(For releases only) Manual tests

GetValues works exactly the same as GetValue, however GetValues gives providers the ability to implement arbitrary batch retrieval mechanisms.
This return type provides Value and Error for each variable, and simplifies mapping from input ids to response without relying on order
@doodlesbykumbi doodlesbykumbi requested a review from a team as a code owner October 19, 2020 15:08
@codeclimate
Copy link

codeclimate bot commented Oct 19, 2020

Code Climate has analyzed commit 185bf53 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 90.9% (50% is the threshold).

This pull request will bring the total coverage in the repository to 53.0% (2.7% change).

View more on Code Climate.

Copy link
Contributor

@sgnn7 sgnn7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sgnn7 sgnn7 merged commit 85c481b into master Oct 19, 2020
@sgnn7 sgnn7 deleted the batch-provider-new branch October 19, 2020 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants