Contrib: Support Vault backend KVv2. Connected to #1331. #1345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgnn7
force-pushed
the
michael2m-1331-support-kv-v2
branch
from
8d56e63 to
1bc6d40
Compare
6 tasks
Signed-off-by: Michael Meijer <[email protected]>
sgnn7
force-pushed
the
michael2m-1331-support-kv-v2
branch
from
1bc6d40 to
9c9197f
Compare
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -6,6 +6,12 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. | |||
|
|
|||
| ## [Unreleased] | |||
|
|
|||
| ### Added | |||
| - The `vault` provider now supports loading secrets from the KV Version 2 secret | |||
There was a problem hiding this comment.
Lists should be surrounded by blank lines
|
Code Climate has analyzed commit 9c9197f and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 50.2% (0.0% change). View more on Code Climate. |
izgeri
reviewed
Sep 28, 2020
izgeri
approved these changes
Sep 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch transfer from #1334
Signed-off-by: Meijer [email protected]
What does this PR do?
What ticket does this PR close?
Connected to #1331
Checklists
Change log
Test coverage
Documentation
READMEs) were updated in this PR, and/or there is a follow-on issue to update docs