Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a generic HTTP connector config for the Sentry API #1317

Merged
merged 1 commit into from
Jul 30, 2020
Merged

Added a generic HTTP connector config for the Sentry API #1317

merged 1 commit into from
Jul 30, 2020

Conversation

mdodell
Copy link
Contributor

@mdodell mdodell commented Jul 27, 2020

What does this PR do?

  • Added a generic HTTP connector config for the Sentry API

What ticket does this PR close?

Connected to #1273

Checklists

Change log

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code changes, or
  • The changes in this PR do not require tests

Documentation

  • This PR does not require updating any documentation, or
  • Docs (e.g. READMEs) were updated in this PR, and/or there is a follow-on issue to update docs

(For releases only) Manual tests

@mdodell mdodell requested a review from a team as a code owner July 27, 2020 17:32
@mdodell mdodell force-pushed the 1273-add-sentry-connector-config branch 2 times, most recently from 470477c to 99f479d Compare July 27, 2020 17:43
@mdodell mdodell self-assigned this Jul 28, 2020
JakeQuilty
JakeQuilty suggested changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@JakeQuilty JakeQuilty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one change

examples/generic_connector_configs/sentry_secretless.yml Outdated Show resolved Hide resolved
@mdodell mdodell force-pushed the 1273-add-sentry-connector-config branch from 99f479d to 26bd297 Compare July 30, 2020 16:12
@mdodell mdodell requested a review from JakeQuilty July 30, 2020 16:13
@mdodell mdodell force-pushed the 1273-add-sentry-connector-config branch from 26bd297 to a2716df Compare July 30, 2020 16:14
JakeQuilty
JakeQuilty approved these changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@JakeQuilty JakeQuilty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codeclimate
Copy link

codeclimate bot commented Jul 30, 2020

Code Climate has analyzed commit a2716df and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 49.8%.

View more on Code Climate.

@JakeQuilty JakeQuilty merged commit 6b7205a into master Jul 30, 2020
@JakeQuilty JakeQuilty deleted the 1273-add-sentry-connector-config branch July 30, 2020 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeQuilty JakeQuilty JakeQuilty approved these changes

Assignees

@mdodell mdodell

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdodell @JakeQuilty