Add support for sslmode=verify-full for mysql and pg #1249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doodlesbykumbi
force-pushed
the
verify-full-pg-mysql
branch
2 times, most recently
from
aa9d057 to
e3bb413
Compare
1 task
doodlesbykumbi
force-pushed
the
verify-full-pg-mysql
branch
2 times, most recently
from
7748772 to
b3bb901
Compare
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
izgeri
reviewed
Jun 16, 2020
1 task
BradleyBoutcher
previously approved these changes
Jun 17, 2020
doodlesbykumbi
force-pushed
the
verify-full-pg-mysql
branch
2 times, most recently
from
4c3c00a to
efa1569
Compare
doodlesbykumbi
force-pushed
the
verify-full-pg-mysql
branch
2 times, most recently
from
a7f88e5 to
c0da649
Compare
doodlesbykumbi
force-pushed
the
verify-full-pg-mysql
branch
from
904bb0e to
939603a
Compare
doodlesbykumbi
force-pushed
the
verify-full-pg-mysql
branch
2 times, most recently
from
86642d9 to
0e9a511
Compare
This means full verification of rootCA and hostname. The value for the hostname to check against is either 'sslhost' or 'host', 'sslhost' takes precedence when it is not empty.
doodlesbykumbi
force-pushed
the
verify-full-pg-mysql
branch
from
0e9a511 to
1180aff
Compare
BradleyBoutcher
approved these changes
Jun 22, 2020
|
Code Climate has analyzed commit 1180aff and detected 5 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 86.9% (50% is the threshold). This pull request will bring the total coverage in the repository to 49.6% (1.2% change). View more on Code Climate. |
|
@doodlesbykumbi this is good to go! sorry for the delay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means full verification of rootCA and hostname. The value for the hostname to check against is either 'sslhost' or 'host', 'sslhost' takes precedence when it is not empty.
What does this PR do?
What's changed? Why were these changes made?
sslhostoption that can override thehostfor certificate hostname verificationHow should the reviewer approach this PR, especially if manual tests are required?
The entrypoint to the feature is
internal/plugin/connectors/tcp/ssl/ssl.go. This file contains the TLS implementation for both mysql and pg.Are there relevant screenshots you can add to the PR description?
N/A
What ticket does this PR close?
Connected to #548
Checklists
Change log
Test coverage
Documentation
READMEs) were updated in this PR, and/or there is a follow-on issue to update docs. https://github.com/cyberark/secretless-docs/issues/255