Add openshift registry support for secretless-broker #1141
Conversation
bin/publish
Outdated
| @@ -42,5 +42,17 @@ for image_name in "${IMAGES[@]}"; do | |||
| docker tag "$image_name:$FULL_VERSION_TAG" "$REGISTRY/$image_name:$tag" | |||
| docker push "$REGISTRY/$image_name:$tag" | |||
| done | |||
|
|
|||
| for tag in "${TAGS[@]}"; do | |||
| # Publish only latest to Redhat Registries | |||
There was a problem hiding this comment.
there is an image with a literal latest tag, so this comment could be clearer (I don't think you mean that we publish only the latest tag to redhat, since you're looping over the TAGS array)
There was a problem hiding this comment.
fwiw, I think it's fine if redhat only has the VERSION tag (and not the latest) - I think that's what we do for the authn-k8s client now, and it might be all we can do bc I'm pretty sure RH doesn't let us overwrite tags
There was a problem hiding this comment.
Ok that definitely simplifies things! I'll just push the latest version, but not do the whole separate thing for the latest tag. I think openshift actually handles that on its own.
BradleyBoutcher
force-pushed
the
openshift-image-support
branch
8 times, most recently
from
9df26d8 to
2c0816f
Compare
bin/build
Outdated
| # (we want the flags to be word split here) | ||
| # shellcheck disable=SC2086 | ||
| docker build --tag "secretless-broker-redhat:${FULL_VERSION_TAG}" \ | ||
| --tag "secretless-broker-redhat:latest" \ |
There was a problem hiding this comment.
Can this tag and the comment above be removed?
BradleyBoutcher
force-pushed
the
openshift-image-support
branch
from
2c0816f to
cdd9caf
Compare
bin/publish
Outdated
| # Publish only latest to Redhat Registries | ||
| echo "Tagging and pushing ${REDHAT_IMAGE}" | ||
|
|
||
| docker tag "secretless-broker-redhat:${FULL_VERSION_TAG}" "${REDHAT_IMAGE}:${VERSION}" | ||
| # you can't push the same tag twice to redhat registry, so ignore errors | ||
| if ! docker push "${REDHAT_IMAGE}:${VERSION}"; then | ||
| echo 'RedHat push FAILED! (Maybe the image was pushed already?)' | ||
| exit 0 | ||
| fi |
There was a problem hiding this comment.
this section is going to get hit twice, once for image_name secretless-broker and once for image_name secretless-broker-quickstart
looking at it now I think this part needs to be broken out of the image loop and put in its own if [ "$git_description" = "v${VERSION}" ]; then loop
maybe there is a better way to organize it, but it doesn't seem right for it to get hit twice for no reason
There was a problem hiding this comment.
good catch - fixed!
BradleyBoutcher
force-pushed
the
openshift-image-support
branch
from
cdd9caf to
838717a
Compare
- Added an additional stage for building an openshift container compliant image for secretless while making use of the build stage - Added a stage to publishing for tagging and submitting the latest version of the redhat compliant image - Updated our build script to use stage targets, and since both stages require different parameters, there would be a failure if these target parameters would be left out, rather than overriding an image with a different name
BradleyBoutcher
force-pushed
the
openshift-image-support
branch
from
838717a to
b7e837a
Compare
compliant image for secretless while making use of the build stage
version of the redhat compliant image
stages require different parameters, there would be a failure if
these target parameters would be left out, rather than overriding
an image with a different name