Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pipeline step to validate changelog #1138

Merged
merged 3 commits into from
Feb 10, 2020
Merged

Add pipeline step to validate changelog #1138

merged 3 commits into from
Feb 10, 2020

Conversation

doodlesbykumbi
Copy link
Contributor

@doodlesbykumbi doodlesbykumbi commented Feb 10, 2020 •
edited
Loading

  1. Update CHANGELOG to pass validation
  2. Update bin/prefill_changelog to generate valid CHANGELOG
  3. Add pipeline step to validate changelog

izgeri
izgeri suggested changes Feb 10, 2020
View reviewed changes
Copy link
Contributor

@izgeri izgeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you update bin/prefill_changelog

  • to automatically add the missing dashes
  • to format the bottom correctly (not sure what's different there)

can the new script be in bash-lib / can the repo use bash-lib? seems a shame to keep adding bash funcs that everything could benefit from

CHANGELOG.md Show resolved Hide resolved
@doodlesbykumbi doodlesbykumbi force-pushed the changelog branch 4 times, most recently from bf093fd to 7df2db8 Compare February 10, 2020 18:21
@doodlesbykumbi
Copy link
Contributor Author

@izgeri I agree with using bash-lib. I think that can be a follow up PR

@doodlesbykumbi doodlesbykumbi merged commit 93637b9 into master Feb 10, 2020
@doodlesbykumbi doodlesbykumbi deleted the changelog branch February 10, 2020 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@izgeri izgeri izgeri approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@doodlesbykumbi @izgeri