Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JDBC Integration tests for Postgres #1130

Merged
merged 1 commit into from
Feb 6, 2020
Merged

Add JDBC Integration tests for Postgres #1130

merged 1 commit into from
Feb 6, 2020

Conversation

BradleyBoutcher
Copy link
Contributor

Utilizes the new JDBC Jar to test queries with postgres

  • Runs several connection tests over TCP
  • Created a new TestRunner that conforms to JDBC requirements

sgnn7
sgnn7 suggested changes Feb 5, 2020
View reviewed changes
Copy link
Contributor

@sgnn7 sgnn7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BradleyBoutcher Just a few comments but looks good!

test/connector/tcp/pg/Dockerfile.dev Outdated Show resolved Hide resolved
test/connector/tcp/pg/Dockerfile.dev Outdated Show resolved Hide resolved
test/connector/tcp/pg/pkg/run_test_case.go Outdated Show resolved Hide resolved
test/connector/tcp/pg/pkg/run_test_case.go Outdated Show resolved Hide resolved
test/connector/tcp/pg/tests/essentials_test.go Outdated Show resolved Hide resolved
@BradleyBoutcher BradleyBoutcher requested a review from sgnn7 February 5, 2020 19:43
@BradleyBoutcher BradleyBoutcher force-pushed the petstore-int branch 4 times, most recently from d272d8b to 8c8d59e Compare February 5, 2020 21:37
@BradleyBoutcher BradleyBoutcher changed the base branch from petstore-int to master February 6, 2020 15:04
@BradleyBoutcher BradleyBoutcher self-assigned this Feb 6, 2020
sgnn7
sgnn7 approved these changes Feb 6, 2020
View reviewed changes
Copy link
Contributor

@sgnn7 sgnn7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BradleyBoutcher LGTM!

@sgnn7 sgnn7 merged commit d33932a into master Feb 6, 2020
@sgnn7 sgnn7 deleted the postgres-jdbc branch February 6, 2020 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgnn7 sgnn7 sgnn7 approved these changes

Assignees

@BradleyBoutcher BradleyBoutcher

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BradleyBoutcher @sgnn7