Skip to content
This repository has been archived by the owner on Sep 9, 2024. It is now read-only.

Use new AuthenticationStrategyInterface #410

Merged
merged 1 commit into from
Jun 22, 2022
Merged

Conversation

szh
Copy link
Contributor

@szh szh commented May 23, 2022

Depends on cyberark/conjur-api-python#22

Desired Outcome

Use new AuthenticationStrategy interface created in cyberark/conjur-api-python#20. This lays the groundwork for adding LDAP authentication support.

Implemented Changes

  • Pass instance of AuthenticationStrategyInterface to Client constructor
  • Add optional authn_type field to .conjurrc (defaults to authn)

Connected Issue/Story

CyberArk internal issue link: ONYX-20429

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: insert issue ID
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@szh szh self-assigned this May 23, 2022
@szh szh force-pushed the authn-strategy-refactor branch 2 times, most recently from b0b340d to 818c56c Compare May 23, 2022 20:35
@szh szh force-pushed the authn-strategy-refactor branch 2 times, most recently from b61552f to b0ada0c Compare May 24, 2022 15:45
@szh szh force-pushed the authn-strategy-refactor branch from b0ada0c to 3c7beb8 Compare May 24, 2022 19:49
@szh szh changed the title WIP: Use new AuthenticationStrategyInterface Use new AuthenticationStrategyInterface May 25, 2022
@szh szh force-pushed the authn-strategy-refactor branch 3 times, most recently from 11a2712 to 316d7c3 Compare May 25, 2022 15:39
@szh szh marked this pull request as ready for review May 25, 2022 18:04
@szh szh requested a review from a team as a code owner May 25, 2022 18:04
@szh szh force-pushed the authn-strategy-refactor branch 9 times, most recently from c480616 to af9af8e Compare June 1, 2022 13:21
@szh szh marked this pull request as draft June 1, 2022 13:37
@szh szh marked this pull request as ready for review June 1, 2022 18:35
@szh szh force-pushed the authn-strategy-refactor branch 2 times, most recently from e709b5c to 82d35f4 Compare June 1, 2022 20:25
@szh szh force-pushed the authn-strategy-refactor branch 2 times, most recently from ea06324 to f52e048 Compare June 1, 2022 20:39
@szh szh force-pushed the authn-strategy-refactor branch from f52e048 to ed78887 Compare June 8, 2022 14:13
@szh
Copy link
Contributor Author

szh commented Jun 16, 2022

@cyberark/community-and-integrations-team Can we please get a review on this so we can move forward on #411?

Copy link
Contributor

@rpothier rpothier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@szh szh merged commit f46afec into main Jun 22, 2022
@szh szh deleted the authn-strategy-refactor branch June 22, 2022 16:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants