Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Support Ruby 3 #344

Merged
merged 1 commit into from
Jan 31, 2022
Merged

Support Ruby 3 #344

merged 1 commit into from
Jan 31, 2022

Conversation

semyon-estrin
Copy link
Contributor

@semyon-estrin semyon-estrin commented Dec 6, 2021 •
edited by szh
Loading

Desired Outcome

Conjur cli support ruby 3.

Implemented Changes

Changed activesupport dependency condition - an enabler for other repos for ruby-3.0.2.
Bump conjur-api-ruby gem to v5.3.7.
Bump rake gem.
Added Ruby 3 tests in Jenkinsfile.
Set ruby 3 as default in all related scripts

Connected Issue/Story

CyberArk internal issue link: ONYX-10396

Definition of Done

All tests are green.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: insert issue ID
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@semyon-estrin semyon-estrin requested a review from jtuttle December 6, 2021 13:15
@semyon-estrin semyon-estrin requested a review from a team as a code owner December 6, 2021 13:15
@semyon-estrin semyon-estrin self-assigned this Dec 6, 2021
sashaCher
sashaCher previously approved these changes Dec 6, 2021
View reviewed changes
Copy link

@sashaCher sashaCher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sashaCher
sashaCher previously approved these changes Dec 7, 2021
View reviewed changes
Copy link

@sashaCher sashaCher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@semyon-estrin semyon-estrin changed the title Bump version to 6.2.6 Support Ruby 3 Dec 12, 2021
sashaCher
sashaCher reviewed Dec 12, 2021
View reviewed changes
conjur-cli.gemspec Outdated Show resolved Hide resolved
tzheleznyak
tzheleznyak previously approved these changes Jan 17, 2022
View reviewed changes
Copy link

@tzheleznyak tzheleznyak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sashaCher
sashaCher reviewed Jan 17, 2022
View reviewed changes
Copy link

@sashaCher sashaCher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to get some clarifications regarding gem spec file.

conjur-cli.gemspec Outdated Show resolved Hide resolved
conjur-cli.gemspec Outdated Show resolved Hide resolved
@codeclimate
Copy link

codeclimate bot commented Jan 19, 2022

Code Climate has analyzed commit e7c3c0b and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 51.2% (0.0% change).

View more on Code Climate.

sashaCher
sashaCher reviewed Jan 30, 2022
View reviewed changes
Copy link

@sashaCher sashaCher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some additional comments mostly related to dependencies

Dockerfile Outdated Show resolved Hide resolved
Gemfile Show resolved Hide resolved
conjur-cli.gemspec Outdated Show resolved Hide resolved
@sashaCher
Copy link

Please align commit history

sashaCher
sashaCher previously approved these changes Jan 31, 2022
View reviewed changes
Copy link

@sashaCher sashaCher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sashaCher
sashaCher previously approved these changes Jan 31, 2022
View reviewed changes
Copy link

@sashaCher sashaCher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sashaCher
sashaCher previously approved these changes Jan 31, 2022
View reviewed changes
Copy link

@sashaCher sashaCher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mbenita-Cyberark
mbenita-Cyberark approved these changes Jan 31, 2022
View reviewed changes
Copy link

@mbenita-Cyberark mbenita-Cyberark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sasha already approved

@semyon-estrin semyon-estrin merged commit f48b8e1 into main Jan 31, 2022
@semyon-estrin semyon-estrin deleted the bump-version-6.2.6 branch January 31, 2022 20:19
@gl-johnson gl-johnson mentioned this pull request Aug 23, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mbenita-Cyberark mbenita-Cyberark mbenita-Cyberark approved these changes

@sashaCher sashaCher sashaCher left review comments

@tzheleznyak tzheleznyak tzheleznyak left review comments

@jtuttle jtuttle Awaiting requested review from jtuttle

Assignees

@semyon-estrin semyon-estrin

Labels
ruby-3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@semyon-estrin @sashaCher @tzheleznyak @mbenita-Cyberark