CONJSE-1783: Support plural syntax for revoke and deny #2901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 4b724b5)
The prior PR #2818 updated our cucumber tests to use multiple processes, running tests in parallel. This required parameterizing several of the test resources to support two parallel sets of tests. This rest helper was missed in the prior PR and was using only one environment's authn-local socket rather than the socket for the given test environment. This caused some tests to fail depending on the environment in which they ran. (cherry picked from commit 7658e5d)
sofiadimant1
approved these changes
Aug 10, 2023
|
@egvili @sofiadimant1 Thanks for merging this back in, the contribution is much appreciated! I do want to let you know that we got pinged by Infosec because this PR published an internal Jira domain. In the future, we will just have to be a bit careful about scrubbing those domains from Cloud changes before we commit them to the OSS repos. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Desired Outcome
Please describe the desired outcome for this PR. Said another way, what was
the original request that resulted in these code changes? Feel free to copy
this information from the connected issue.
Implemented Changes
Describe how the desired outcome above has been achieved with this PR. In
particular, consider:
Connected Issue/Story
Resolves #[relevant GitHub issue(s), e.g. 76]
CyberArk internal issue ID: [insert issue ID]
Definition of Done
At least 1 todo must be completed in the sections below for the PR to be
merged.
Changelog
CHANGELOG update
Test coverage
changes, or
Documentation
READMEs) were updated in this PRBehavior
Security