Add flag to conjurctl server to skip migrations #2895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
telday
force-pushed
the
CNJR-1599-follower-db-updates
branch
2 times, most recently
from
5612744 to
016489c
Compare
|
@telday I think we may need some tests added to |
micahlee
reviewed
Aug 9, 2023
telday
force-pushed
the
CNJR-1599-follower-db-updates
branch
2 times, most recently
from
30a5fe9 to
8ac49d3
Compare
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -42,6 +42,10 @@ | |||
| c.default_value(ENV['PORT'] || '80') | |||
| c.flag [ :p, :port ] | |||
|
|
|||
| c.desc 'Skip running database migrations on start' | |||
| c.default_value false | |||
There was a problem hiding this comment.
Use parentheses for method calls with arguments.
| @@ -15,6 +15,11 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. | |||
| - Telemetry support | |||
| [cyberark/conjur#2854](https://github.com/cyberark/conjur/pull/2854) | |||
|
|
|||
| ### Added | |||
| - New flag to `conjurctl server` command called `--no-migrate` which allows for skipping | |||
There was a problem hiding this comment.
Lists should be surrounded by blank lines
telday
force-pushed
the
CNJR-1599-follower-db-updates
branch
from
8ac49d3 to
1e8d9a3
Compare
telday
force-pushed
the
CNJR-1599-follower-db-updates
branch
from
1e8d9a3 to
2324d85
Compare
imheresamir
approved these changes
Aug 9, 2023
|
Code Climate has analyzed commit 2324d85 and detected 4 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 88.4% (-0.2% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Desired Outcome
Adds new flag to the
conjurctl servercommand which allows for skipping the migrations step even when the Sequel gem would normally think we need to. This change is required by a k8s follower using selective replication. When a k8s follower boots with selective replication enabled it performs a schema dump instead of a full database backup which means theschema_migrationsandschema_infotables containing what migrations the database has had applied is missing and therefore the Sequel gem attempts to apply all of them. This then causes errors when the migration attempts to create schema elements already present in the database.Implemented Changes
If the new
--no-migrateflag is used the migration step is skipped when booting Conjur.Connected Issue/Story
Resolves #[relevant GitHub issue(s), e.g. 76]
CyberArk internal issue ID: [CNJR-1599]
Definition of Done
Changelog
CHANGELOG update
Test coverage
changes, or
Documentation
READMEs) were updated in this PRBehavior
Security