Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a resource for the account admin user #2757

Merged
merged 1 commit into from
Mar 27, 2023

Conversation

micahlee
Copy link
Contributor

@micahlee micahlee commented Mar 23, 2023

Desired Outcome

The desired outcome of this PR is for the account admin to list its grants.

Implemented Changes

This PR adds the account admin as a Resource in the Conjur database so that all existing authorization controls apply to it as well.

Connected Issue/Story

Follow up to #2755

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be
merged.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: [insert issue ID]
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@micahlee micahlee force-pushed the account-admin-resource branch from 7271012 to 5d1d96a Compare March 23, 2023 20:40
@micahlee micahlee changed the title Create a resource for the admin user Create a resource for the account admin user Mar 23, 2023
@micahlee micahlee marked this pull request as ready for review March 23, 2023 20:45
@micahlee micahlee requested a review from a team as a code owner March 23, 2023 20:45
An owner may be assigned, or it may be self-owned.
@imheresamir imheresamir force-pushed the account-admin-resource branch from 5d1d96a to 26e689d Compare March 27, 2023 17:33
Copy link
Contributor

@imheresamir imheresamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@codeclimate
Copy link

codeclimate bot commented Mar 27, 2023

Code Climate has analyzed commit 26e689d and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 90.3% (-1.6% change).

View more on Code Climate.

@imheresamir imheresamir merged commit e72ad29 into master Mar 27, 2023
@imheresamir imheresamir deleted the account-admin-resource branch March 27, 2023 18:20
john-odonnell added a commit to cyberark/conjur-sdk-java that referenced this pull request Apr 24, 2023
Admin users now have a corresponding resource:
cyberark/conjur#2757
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants