-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: audit event to GET /roles/:account/:kind/*identifier?memberships #2693
Conversation
d06df5f
to
eb12ca7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for getting this functional gap filled!
f743de0
to
37bc28a
Compare
d41a8b8
to
f909e65
Compare
@@ -0,0 +1,89 @@ | |||
module Audit | |||
module Event |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 2 locations. Consider refactoring.
64465e1
to
93c3b84
Compare
Add: audit event to GET /roles/:account/:kind/*identifier
93c3b84
to
8e6a0f4
Compare
Code Climate has analyzed commit 8e6a0f4 and detected 4 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 81.2% (50% is the threshold). This pull request will bring the total coverage in the repository to 90.0% (-1.7% change). View more on Code Climate. |
Desired Outcome
This PR adds an audit log message for list members using the API endpoint
GET /roles/{account}/{kind}/{identifier}?memberships
Implemented Changes
Describe how the desired outcome above has been achieved with this PR. In
particular, consider:
Audit Example:
Connected Issue/Story
Resolves ONYX-26177
Definition of Done
At least 1 todo must be completed in the sections below for the PR to be
merged.
Changelog
CHANGELOG update
Test coverage
changes, or
Documentation
README
s) were updated in this PRBehavior
Security