JWT Authenticator supports public-keys variable
#2463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sashaCher
force-pushed
the
integrate-public-keys-flow
branch
from
6f42359 to
71097ea
Compare
sashaCher
force-pushed
the
authn-jwt-all-signing-key-settings
branch
from
54d0c93 to
3d446df
Compare
sashaCher
force-pushed
the
integrate-public-keys-flow
branch
from
71097ea to
3d265d6
Compare
sashaCher
force-pushed
the
authn-jwt-all-signing-key-settings
branch
from
3d446df to
ba79c6f
Compare
sashaCher
force-pushed
the
integrate-public-keys-flow
branch
from
3d265d6 to
5f835ea
Compare
sashaCher
force-pushed
the
authn-jwt-all-signing-key-settings
branch
from
ba79c6f to
5fabe9a
Compare
sashaCher
force-pushed
the
integrate-public-keys-flow
branch
from
5f835ea to
ff5d70d
Compare
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -6,6 +6,18 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. | |||
|
|
|||
| ## [Unreleased] | |||
|
|
|||
| ### Added | |||
| - Added an ability to JWT generic vendor configuration to receive signing keys for | |||
There was a problem hiding this comment.
Lists should be surrounded by blank lines
When Conjur is unable to reach remote JWKS URI endpoint public-keys variable can be used in order to provide static JWK Set to the authenticator. Variable value is a JSON object contains two fields: type and value. The type filed should be set to "jwks" string and the value field should be set to a relevant JWKS set.
sashaCher
force-pushed
the
integrate-public-keys-flow
branch
from
ff5d70d to
2a2354d
Compare
|
Code Climate has analyzed commit 2a2354d and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 91.2% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Desired Outcome
Enable JWT authenticator to receive static signing keys via
public-keysvariable.Implemented Changes
CreateSigningKeyProvidercreates and returnsFetchPublicKeysSigningKeyclassConnected Issue/Story
ONYX-15388
Definition of Done
Changelog
CHANGELOG update
Test coverage
changes, or
Documentation
READMEs) were updated in this PRBehavior
Security