Bugfix status cache #2356
Merged
Bugfix status cache #2356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nessiLahav
force-pushed
the
bugfix-status-cache
branch
from
fb559fc to
20e4784
Compare
sashaCher
reviewed
Aug 9, 2021
| @@ -3,6 +3,16 @@ module AuthnJwt | |||
|
|
|||
| ValidateStatus = CommandClass.new( | |||
| dependencies: { | |||
| fetch_signing_key: ::Util::ConcurrencyLimitedCache.new( | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
@nessiLahav rebase the bugfix branch to you branch
sashaCher
reviewed
Aug 9, 2021
Comment on lines
108
to
111
| def fetch_jwt_claims_to_validate | ||
| @fetch_jwt_claims_to_validate ||= ::Authentication::AuthnJwt::ValidateAndDecode::FetchJwtClaimsToValidate.new | ||
| end | ||
|
|
sashaCher
reviewed
Aug 9, 2021
sashaCher
reviewed
Aug 9, 2021
tzheleznyak
reviewed
Aug 9, 2021
nessiLahav
force-pushed
the
bugfix-status-cache
branch
2 times, most recently
from
7cff142 to
7f16dc1
Compare
nessiLahav
force-pushed
the
bugfix-status-cache
branch
from
7f16dc1 to
b1bbbd9
Compare
tzheleznyak
added a commit
that referenced
this pull request
Aug 10, 2021
* Fix cache of signing key * Adjust ValidateAndDecodeToken UTs * Bugfix status cache (#2356) * ONYX-11330: Fix cache of signing key * Fix cache bug in authn-jwt status flow * Fixes according to PR comments Co-authored-by: Tamir Zheleznyak <[email protected]> * Fix signing_key UTs * Fix by PR comments Co-authored-by: Sasha Chernomordik <[email protected]> Co-authored-by: Nessi Lahav <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix cache bug in authn-jwt status flow
What ticket does this PR close?
Resolves #[relevant GitHub issues, eg 76]
Checklists
Change log
Test coverage
Documentation
READMEs) were updated in this PR, and/or there is a follow-on issue to update docs, orAPI Changes