Skip to content
This repository has been archived by the owner on Dec 2, 2024. It is now read-only.

Address Snyk issues #331

Merged
merged 1 commit into from
Jun 5, 2023
Merged

Address Snyk issues #331

merged 1 commit into from
Jun 5, 2023

Conversation

juniortaeza
Copy link
Contributor

@juniortaeza juniortaeza commented May 26, 2023

Desired Outcome

This pull request addresses the Snyk issues outlined in this repository.

Implemented Changes

  • upgrades ruby to 3.2 in Dockerfile, Dockerfile.dev, and Dockerfile.test
  • upgrades Go base image in buildpack-health-check/Dockerfile to 1.20-alpine
  • upgrades golang.org/x/sys to v0.8.0

As discussed with @gl-johnson and @andytinkham, upgrading rack to 3.x is currently infeasible as rails, actionpack, and other dependencies require rack < 3. Currently, the build (tests) are failing due to this incompatibility of rack >= 3 and rails/etc.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: [insert issue ID]
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@juniortaeza juniortaeza requested a review from a team as a code owner May 26, 2023 16:39
@juniortaeza juniortaeza force-pushed the snyk-issues-branch branch from 72ef96e to 29f529d Compare May 26, 2023 16:40
@juniortaeza juniortaeza requested a review from gl-johnson May 26, 2023 16:50
@juniortaeza
Copy link
Contributor Author

Requesting @gl-johnson's review to confirm proper switch to 'roda' from 'sinatra'

@juniortaeza juniortaeza force-pushed the snyk-issues-branch branch 3 times, most recently from 6a63455 to 588d71e Compare May 31, 2023 21:04
@juniortaeza juniortaeza force-pushed the snyk-issues-branch branch from 588d71e to 18890e2 Compare May 31, 2023 21:06
Copy link
Contributor

@gl-johnson gl-johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juniortaeza juniortaeza merged commit 683eb40 into main Jun 5, 2023
@juniortaeza juniortaeza deleted the snyk-issues-branch branch June 5, 2023 19:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants