Add telemetry to quickstart #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doodlesbykumbi
force-pushed
the
telemetry
branch
4 times, most recently
from
dc9b426 to
8a99b4e
Compare
gl-johnson
reviewed
Oct 18, 2022
| @@ -0,0 +1,27 @@ | |||
| groups: | |||
| - name: Hardware alerts | |||
There was a problem hiding this comment.
Just curious how these alerts get handled as I haven't looked into it yet. Do they appear in the dashboard or logs, or does it require additional config to an actual notification system?
There was a problem hiding this comment.
Additional config... Prometheus has an alert manager to deal with dispatching alerts based on rules, see https://prometheus.io/docs/alerting/latest/alertmanager/
doodlesbykumbi
force-pushed
the
telemetry
branch
9 times, most recently
from
4808346 to
ff54e87
Compare
|
@gl-johnson and @doodlesbykumbi, any idea why this wasn't merged? |
13 tasks
gl-johnson
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Desired Outcome
Please describe the desired outcome for this PR. Said another way, what was
the original request that resulted in these code changes? Feel free to copy
this information from the connected issue.
Implemented Changes
Describe how the desired outcome above has been achieved with this PR. In
particular, consider:
Connected Issue/Story
Resolves #[relevant GitHub issue(s), e.g. 76]
CyberArk internal issue link: insert issue ID
Definition of Done
At least 1 todo must be completed in the sections below for the PR to be
merged.
Changelog
CHANGELOG update
Test coverage
changes, or
Documentation
READMEs) were updated in this PRBehavior
Security