Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ruby base image #259

Merged
merged 3 commits into from
Aug 23, 2023
Merged

Upgrade ruby base image #259

merged 3 commits into from
Aug 23, 2023

Conversation

gl-johnson
Copy link
Contributor

@gl-johnson gl-johnson commented Jun 21, 2023

Desired Outcome

Fix buidling of the PDK image, and upgrade the Dockerfile base image to 3.3-rc-slim

Includes changes from #257

NOTE: Due to recurring issues with provisioning Windows nodes in CI we are skipping the integration tests for now, but it is highly unlikely that these changes will have impacted the modules functionality.

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be
merged.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: [insert issue ID]
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@gl-johnson gl-johnson force-pushed the build-fix branch 5 times, most recently from 58c194e to 9819f2f Compare July 6, 2023 14:01
@gl-johnson gl-johnson marked this pull request as ready for review August 22, 2023 21:10
@gl-johnson gl-johnson requested a review from a team as a code owner August 22, 2023 21:10
@gl-johnson gl-johnson mentioned this pull request Aug 22, 2023
Copy link
Contributor

@juniortaeza juniortaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Ruby upgrade with corresponding syntax changes and temporary disabling of the Windows Node executors all look good.

This should also close out my upgrade branch/ticket from a while back so I'll mark my ticket for that as 'Done'.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants