Prep for v3.0.0 release #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TBD if we can also update the README to say |
izgeri
suggested changes
Sep 17, 2020
There was a problem hiding this comment.
Looking good, but can you please also:
- Change the README to say Trusted (you can copy/paste from here)
- Review the README to ensure there's not any lingering
cert_filecontent that should be held off until Finish support forcert_fileparameter #224 gets merged
CHANGELOG was compressed to show only v2->v3 changes and metadata was updated to refer to the v3 non-RC version.
This is not a completed feature yet so it's being pulled from the docs for now.
sgnn7
force-pushed
the
219-v3-release
branch
from
71a7b31 to
0c8b3be
Compare
izgeri
approved these changes
Sep 17, 2020
alexkalish
previously requested changes
Sep 17, 2020
| @@ -41,6 +42,14 @@ secrets from Conjur. | |||
|
|
|||
| You can find our official distributable releases on Puppet Forge under [`cyberark/conjur`](https://forge.puppet.com/cyberark/conjur). | |||
|
|
|||
| ## Certification level | |||
There was a problem hiding this comment.
With the addition of the certification level section, the caveat about Puppet v6 support being community level under "Setup Requirements" should be removed.
Also, you may want to move the section about "Certified Version" below up to this area, so that there is only a single part of the README dedicated to certification level. @izgeri, WDYT?
This project is now certified as Trusted so we added this info to the README.
Relative links don't work on Puppet Forge so their instances in README were changed to absolute links.
This change changes the basic usage examples to use the same language as the headers for their respective sections.
sgnn7
force-pushed
the
219-v3-release
branch
from
678f016 to
55136e7
Compare
izgeri
approved these changes
Sep 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG was compressed to show only v2->v3 changes and metadata was
updated to refer to the v3 non-RC version.
What ticket does this PR close?
Connected to #219
Checklists
Change log
Test coverage
Documentation
READMEs) were updated in this PR, and/or there is a follow-on issue to update docs, or