Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for cert_file on Windows #126

Merged
merged 1 commit into from
Jul 14, 2020
Merged

Add support for cert_file on Windows #126

merged 1 commit into from
Jul 14, 2020

Conversation

doodlesbykumbi
Copy link
Contributor

What does this PR do?

  • Add support for cert_file on Windows and to the conjur class
  • Update README with description and examples of cert_file

What ticket does this PR close?

Connected to #113

Checklists

Change log

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR, and/or there is a follow-on issue to update docs, or
  • This PR does not require updating any documentation

@doodlesbykumbi doodlesbykumbi requested a review from a team as a code owner July 14, 2020 10:57
@doodlesbykumbi doodlesbykumbi linked an issue Jul 14, 2020 that may be closed by this pull request
Add support for cert_file on Windows #113
Closed
3 tasks
@sgnn7
Copy link
Contributor

sgnn7 commented Jul 14, 2020 •
edited
Loading

@doodlesbykumbi This LGTM but can we open an issue (or reuse/edit #125) to add this as a test case once we have automation?

Ignore this - I added this change to the #125 to save us time.

sgnn7
sgnn7 approved these changes Jul 14, 2020
View reviewed changes
Copy link
Contributor

@sgnn7 sgnn7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@doodlesbykumbi LGTM!

@sgnn7 sgnn7 merged commit bfcedc9 into master Jul 14, 2020
@sgnn7 sgnn7 deleted the cert_file_windows branch July 14, 2020 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgnn7 sgnn7 sgnn7 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for cert_file on Windows
2 participants
@doodlesbykumbi @sgnn7