Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script to enable authn-jwt flow #169

Merged
merged 1 commit into from
Jan 11, 2022
Merged

Add script to enable authn-jwt flow #169

merged 1 commit into from
Jan 11, 2022

Conversation

tzheleznyak
Copy link
Contributor

Added JWT enable to the example scripts for usage of automation of conjur-authn-k8s-client

@tzheleznyak tzheleznyak requested review from a team January 10, 2022 19:44
Copy link
Contributor

@szh szh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just left a comment about a comment 🔁

@@ -45,3 +45,6 @@
# Configuration for Conjur authn-k8s
#export ANNOTATION_BASED_AUTHN="<true-or-false-defaults-to-true>"
#export AUTHENTICATOR_ID="<authenticator-id-string-defaults-to-my-authenticator-id>"

# Default authn strategy is authn-k8s. But we want to support ad of authn-jwt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you clarify the last part of this comment? I'm not 100% sure what it's trying to say

@tzheleznyak tzheleznyak force-pushed the enable-authn-jwt branch 3 times, most recently from 6043d5e to b83e47b Compare January 11, 2022 21:22
Can be used in automation that uses this helm chart
Copy link
Contributor

@szh szh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants