Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements role parameter in check command in CLI #75

Merged
merged 2 commits into from
Jan 26, 2023

Conversation

juniortaeza
Copy link
Contributor

@juniortaeza juniortaeza commented Jan 10, 2023

Desired Outcome

Depends on conjur-api-go#153

This pull request adds a role parameter to the 'check' command for the Go CLI.

Implemented Changes

  • Updated 'check' to include role flag
  • Updated check_tests to test full API & CLI functionality of flag and command

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be
merged.

Changelog (need a Changelog)

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: insert issue ID
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@juniortaeza juniortaeza requested a review from a team as a code owner January 10, 2023 17:06
@juniortaeza juniortaeza force-pushed the check-role-cli-branch branch 2 times, most recently from 685a919 to f08d61e Compare January 10, 2023 17:17
Copy link
Contributor

@szh szh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just needs a rebase

@john-odonnell john-odonnell force-pushed the check-role-cli-branch branch 2 times, most recently from 8b727d7 to 5c97ee9 Compare January 25, 2023 19:05
Copy link
Contributor

@szh szh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, needs a rebase.

@codeclimate
Copy link

codeclimate bot commented Jan 26, 2023

Code Climate has analyzed commit 9b48fee and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 92.8% (50% is the threshold).

This pull request will bring the total coverage in the repository to 69.2% (0.2% change).

View more on Code Climate.

Copy link
Contributor

@szh szh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@john-odonnell john-odonnell merged commit c3add76 into master Jan 26, 2023
@john-odonnell john-odonnell deleted the check-role-cli-branch branch January 26, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants