Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNJR-2306: Make log level configurable #522

Merged
merged 1 commit into from
Jul 19, 2023
Merged

CNJR-2306: Make log level configurable #522

merged 1 commit into from
Jul 19, 2023

Conversation

szh
Copy link
Contributor

@szh szh commented Jul 13, 2023

Desired Outcome

Make log level configurable.
Currently there are only two options for logging: debug-logging on or off. There is a customer request to allow minimizing logs to only warnings or errors, with the option to enable info level logs as well. This will cut down on the amount of noise coming from secrets rotations, where the number of log messages will be amplified due to continual refresh.

Implemented Changes

  • Added new configuration option, "LOG_LEVEL" / "conjur.org/log-level"
    • Valid options are "debug", "info", "warn", "error"
  • Deprecated "DEBUG" / "conjur.org/debug-logging" configuration option

Connected Issue/Story

CyberArk internal issue ID: CNJR-2306

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: [insert issue ID]
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@szh szh self-assigned this Jul 13, 2023
@szh szh changed the title Make log level configurable CNJR-2306: Make log level configurable Jul 18, 2023
@szh szh force-pushed the log-level branch 2 times, most recently from debeb13 to 53c5d64 Compare July 18, 2023 14:56
@szh szh marked this pull request as ready for review July 18, 2023 14:56
@szh szh requested a review from a team as a code owner July 18, 2023 14:56
Copy link
Contributor

@gl-johnson gl-johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small comment on unit tests but otherwise LGTM

pkg/authenticator/config/configuration_factory_test.go Outdated Show resolved Hide resolved
@szh szh requested a review from gl-johnson July 19, 2023 19:06
@szh szh merged commit 2e702dd into master Jul 19, 2023
@szh szh deleted the log-level branch July 19, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants