Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the docs for service account secret #509

Closed
wants to merge 1 commit into from

Conversation

rpothier
Copy link
Contributor

@rpothier rpothier commented Apr 10, 2023

Desired Outcome

Update the docs for Service Account Secrets

Implemented Changes

Added a note about the service account secret

Connected Issue/Story

CyberArk internal issue ID: CNJR-467

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be
merged.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: [insert issue ID]
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@rpothier rpothier self-assigned this Apr 10, 2023
@rpothier rpothier force-pushed the update-docs-for-service-account-secret branch 3 times, most recently from c6e8d0d to 886dcbe Compare April 11, 2023 14:51
@rpothier rpothier marked this pull request as ready for review April 11, 2023 14:52
@rpothier rpothier requested a review from a team as a code owner April 11, 2023 14:52
@rpothier rpothier force-pushed the update-docs-for-service-account-secret branch from 886dcbe to 157950e Compare April 13, 2023 16:00
juniortaeza
juniortaeza previously approved these changes Apr 13, 2023
Copy link
Contributor

@juniortaeza juniortaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! My build in PR #508 is failing because of the '--helm3' flag but it looks like this PR addresses it. Thanks!

@rpothier rpothier force-pushed the update-docs-for-service-account-secret branch from 157950e to 6c289f9 Compare April 13, 2023 21:33
@rpothier rpothier marked this pull request as draft April 13, 2023 21:38
@john-odonnell
Copy link
Contributor

Merged into #508

@szh szh deleted the update-docs-for-service-account-secret branch April 20, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants