Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a wait for the master before deploying the follower #499

Merged
merged 1 commit into from
Jan 30, 2023

Conversation

rpothier
Copy link
Contributor

Desired Outcome

Seeing the following error with the latest CI runs.

[2023-01-27T15:00:55.464Z] psql: could not connect to server: No such file or directory
[2023-01-27T15:00:55.464Z]     Is the server running locally and accepting
[2023-01-27T15:00:55.464Z]     connections on Unix domain socket "/var/run/postgresql/.s.PGSQL.5432"?

Implemented Changes

Added a wait for the master before provisioning the follower

Connected Issue/Story

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be
merged.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: [insert issue ID]
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@rpothier rpothier self-assigned this Jan 27, 2023
@rpothier rpothier marked this pull request as ready for review January 27, 2023 23:56
@rpothier rpothier requested a review from a team as a code owner January 27, 2023 23:56
Copy link
Contributor

@micahlee micahlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @rpothier!

@micahlee micahlee merged commit 1362fa9 into master Jan 30, 2023
@rpothier rpothier deleted the fix-build-error branch January 30, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants